{"id":902,"url":"https://patchwork.libcamera.org/api/patches/902/?format=json","web_url":"https://patchwork.libcamera.org/patch/902/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190403102545.7143-3-kieran.bingham@ideasonboard.com>","date":"2019-04-03T10:25:45","name":"[libcamera-devel,2/2] qcam: meson: Use pkg-config method for qt5 dependencies","commit_ref":"d5ca33f6c7b0cd1ca20ec5dc7131aeedf1503080","pull_url":null,"state":"accepted","archived":false,"hash":"0a32c60bf5c56f4aad2f75e06cedc72b1eceeece","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/902/mbox/","series":[{"id":236,"url":"https://patchwork.libcamera.org/api/series/236/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=236","date":"2019-04-03T10:25:43","name":"Cleanups - for buildroot","version":1,"mbox":"https://patchwork.libcamera.org/series/236/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/902/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/902/checks/","tags":{},"headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F0DE16110E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  3 Apr 2019 12:25:59 +0200 (CEST)","from Q.imgcgcw.net (unknown [147.50.13.10])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 547349B6;\n\tWed,  3 Apr 2019 12:25:57 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1554287159;\n\tbh=FD1XdkfazQVqMRserQj3la/+Jp8ST8QPFmxEg4EPbdY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=al1pHU9EQMCEEWHeLXejf1VbWRvN2LyvX9MmRYdhL0ekuwmphy1FtzuYZ8iXYz4wr\n\tVQgHPvSpWJjzOL0pd9DBZlRGErqmfznkCBtU+gZiC40LntF18Gb2Namry9xp+w3m2O\n\tpud+X9UuUJG8U69ABu30yiQ8qIVmahU8hr7hALxk=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Date":"Wed,  3 Apr 2019 17:25:45 +0700","Message-Id":"<20190403102545.7143-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.19.1","In-Reply-To":"<20190403102545.7143-1-kieran.bingham@ideasonboard.com>","References":"<20190403102545.7143-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] qcam: meson: Use pkg-config method\n\tfor qt5 dependencies","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 03 Apr 2019 10:26:00 -0000"},"content":"Meson searches for qmake to determine if QT5 is available to support the\noptional qcam component.\n\nWhen cross compiling, meson can incorrectly identify the host qmake\nwhich will cause incorrect linkage and usage of system headers.\n\nSet the dependency method to specify pkg-config which resolves the\nissue.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/qcam/meson.build | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/src/qcam/meson.build b/src/qcam/meson.build\nindex 8a71cda3dfe5..3d8b1b3b759d 100644\n--- a/src/qcam/meson.build\n+++ b/src/qcam/meson.build\n@@ -8,7 +8,10 @@ qcam_sources = files([\n ])\n \n import('qt5')\n-qt5_dep = dependency('qt5', modules: ['Core', 'Gui', 'Widgets'], required : false)\n+qt5_dep = dependency('qt5',\n+                     method : 'pkg-config',\n+                     modules : ['Core', 'Gui', 'Widgets'],\n+                     required : false)\n \n if qt5_dep.found()\n     qcam  = executable('qcam', qcam_sources,\n","prefixes":["libcamera-devel","2/2"]}