[{"id":11682,"web_url":"https://patchwork.libcamera.org/comment/11682/","msgid":"<20200728235938.GC151012@oden.dyn.berto.se>","date":"2020-07-28T23:59:38","subject":"Re: [libcamera-devel] [PATCH 3/5] android: camera_device: Add (max, \n\tmax) FPS range","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-07-25 18:42:41 +0200, Jacopo Mondi wrote:\n> Add to the static camera characteristics metadata pack an additional\n> FPS range entry which report the (max, max) FPS range, which is now\n> fixed to 30 frames per second.\n> \n> The (max, max) FPS range will be used to construct the request\n> template for the video recording capture intent, which requires the\n> FPS range to be a single value.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index de18d1dbe299..ca746b685c26 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -377,7 +377,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t * Currently: 50 entries, 647 bytes of static metadata\n> \t */\n> \tuint32_t numEntries = 50;\n> -\tuint32_t byteSize = 671;\n> +\tuint32_t byteSize = 679;\n> \n> \t/*\n> \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -446,6 +446,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \n> \tstd::vector availableAeFpsTarget = {\n> \t\t15, 30,\n> +\t\t30, 30,\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_AVAILABLE_TARGET_FPS_RANGES,\n> \t\t\t\t availableAeFpsTarget.data(),\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81B75BD878\n\tfor ;\n\tTue, 28 Jul 2020 23:59:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1AAB860535;\n\tWed, 29 Jul 2020 01:59:41 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2C4860535\n\tfor ;\n\tWed, 29 Jul 2020 01:59:39 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id x9so23096600ljc.5\n\tfor ;\n\tTue, 28 Jul 2020 16:59:39 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tt24sm42891ljc.125.2020.07.28.16.59.38\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 28 Jul 2020 16:59:38 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"erFAUsp6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=xctu4yCMFqtn4DtKOPaNPP53H6g6vRIxISJ73Lc0wjs=;\n\tb=erFAUsp6Y56o0qZ8V7o+gWoUtHYlK+O7ndqSEkXQE9qMxyMd6xfy02EnPl3YcV0rKM\n\tFKRPaoBiMgivnPiO9F62vVdL/hDlRf4EoYLZsza4uGygWHpfFildiJw6HxV6zpPoJ3y1\n\tRM00udURG/xu48IKuLWui7HJQsonjdsxeAv5CO5RWQmcwHeLRhupWKYlMzjqkQp8zPO+\n\tiIl6luS8vVMEtenrrsnWWGZuCzXGgOl1D0J4NTEfmp33uEhieeL4oECYu4dI3znytTek\n\tA5/vOvsvCs32SsuQMXKec0ZscrYUC1NM0kozjT86GqQCjFS/ZSBLkr98gRa7hwDGRZJq\n\tZl+g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=xctu4yCMFqtn4DtKOPaNPP53H6g6vRIxISJ73Lc0wjs=;\n\tb=L54JrpMF0/1sLoM2YvlKBzJMSHHFPp15W6rGRsFlLfPYJBcebGdL9AvYivKDre5lg3\n\t45VR7T4i13HNEMUPX2c+1TbGS1TPOwAom8s88mtbIv6l3erfLNK3wVyuXdwdB1s5t2Cy\n\tkhNerwiiEGJeULiJeYy5H/Qj4ydzu/d5JpNJLjNyFqk/TtWgDc8yz0XIJUtk0OJMw4H4\n\tLQRsmhcZ6ndwPJDkJH5WySAObas4HnJoL1op+eqOukHP1GRMAmAVUyB7Yi+zlDw24pzf\n\tfObPr5mjzOru6i12kLWOgifd2V8YA7Tjif7JEPH2ITBlySdxy+ryNR7VBQ08jcT/ohX2\n\ti1KQ==","X-Gm-Message-State":"AOAM530ZxPBN+QzbJCjpF/7xvwvMzP2bLYZHL5t33fL5Ht++hVr2spuI\n\tK03snoflyaIGUN8GAMAUnyoKOQ==","X-Google-Smtp-Source":"ABdhPJx3r5SKE+iEqMiWZqA0RF+dVfLxUKiEA3x5ATS5DthzEbicwtJuOaPqyvQETqMW+3m2uhByDw==","X-Received":"by 2002:a2e:9684:: with SMTP id\n\tq4mr12442538lji.459.1595980779000; \n\tTue, 28 Jul 2020 16:59:39 -0700 (PDT)","Date":"Wed, 29 Jul 2020 01:59:38 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200728235938.GC151012@oden.dyn.berto.se>","References":"<20200725164243.168297-1-jacopo@jmondi.org>\n\t<20200725164243.168297-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200725164243.168297-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 3/5] android: camera_device: Add (max, \n\tmax) FPS range","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]