{"id":9010,"url":"https://patchwork.libcamera.org/api/patches/9010/?format=json","web_url":"https://patchwork.libcamera.org/patch/9010/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200725164243.168297-4-jacopo@jmondi.org>","date":"2020-07-25T16:42:41","name":"[libcamera-devel,3/5] android: camera_device: Add (max, max) FPS range","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"5cd19a40e9f8113bd5fff9f423e5adf36ec8d756","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/9010/mbox/","series":[{"id":1147,"url":"https://patchwork.libcamera.org/api/series/1147/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1147","date":"2020-07-25T16:42:38","name":"android: cts: Fix Manual and VideoRecording templates","version":1,"mbox":"https://patchwork.libcamera.org/series/1147/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9010/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9010/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA0B0BD86F\n\tfor ;\n\tSat, 25 Jul 2020 16:39:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C306F6123B;\n\tSat, 25 Jul 2020 18:39:16 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7596B61212\n\tfor ;\n\tSat, 25 Jul 2020 18:39:12 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id E64F2E0003;\n\tSat, 25 Jul 2020 16:39:11 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 25 Jul 2020 18:42:41 +0200","Message-Id":"<20200725164243.168297-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200725164243.168297-1-jacopo@jmondi.org>","References":"<20200725164243.168297-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 3/5] android: camera_device: Add (max,\n\tmax) FPS range","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add to the static camera characteristics metadata pack an additional\nFPS range entry which report the (max, max) FPS range, which is now\nfixed to 30 frames per second.\n\nThe (max, max) FPS range will be used to construct the request\ntemplate for the video recording capture intent, which requires the\nFPS range to be a single value.\n\nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex de18d1dbe299..ca746b685c26 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -377,7 +377,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n \t * Currently: 50 entries, 647 bytes of static metadata\n \t */\n \tuint32_t numEntries = 50;\n-\tuint32_t byteSize = 671;\n+\tuint32_t byteSize = 679;\n \n \t/*\n \t * Calculate space occupation in bytes for dynamically built metadata\n@@ -446,6 +446,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \n \tstd::vector availableAeFpsTarget = {\n \t\t15, 30,\n+\t\t30, 30,\n \t};\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_AE_AVAILABLE_TARGET_FPS_RANGES,\n \t\t\t\t availableAeFpsTarget.data(),\n","prefixes":["libcamera-devel","3/5"]}