[{"id":1246,"web_url":"https://patchwork.libcamera.org/comment/1246/","msgid":"<20190403103548.GG12646@pendragon.ideasonboard.com>","date":"2019-04-03T10:35:48","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: ipu3: Catch return\n\tvalue when disabling links","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Wed, Apr 03, 2019 at 05:25:44PM +0700, Kieran Bingham wrote:\n> Ensure that any error from the disableLinks() call during match() is\n> propogated to the caller.\n> \n> Fixes: d698ed27494a (\"libcamera: ipu3: Create ImgUDevice class\")\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ++-\n>  1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 164e187c769d..fed04ce50387 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -511,7 +511,8 @@ bool PipelineHandlerIPU3::match(DeviceEnumerator *enumerator)\n>  \t * going through a library teardown->match() sequence would fail\n>  \t * at the moment.\n>  \t */\n> -\tif (imguMediaDev_->disableLinks())\n> +\tret = imguMediaDev_->disableLinks();\n> +\tif (ret)\n>  \t\tgoto error;\n>  \n>  \tret = registerCameras();","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5303600FD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed,  3 Apr 2019 12:35:59 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5325E9AA;\n\tWed,  3 Apr 2019 12:35:59 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1554287759;\n\tbh=wWO39SaHbKq4NANvxAeRDPkn3WjlEsWL5F4s2dKdYhM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CGFV0bFWSOyBjBmT8z+N+Y/5C6+H8j16My/z/xsXaTUIP2uoIQCirDMRBelgpYB6U\n\tnCJFt6SMXseUOhdDhGSdcHE+uibLSGZOp6YW1YemAIv793Nhuaym95v1jWp07Ov3Tl\n\tC+V7Bz9g2iH3YuZs3FCH/waBT1tM1KmYS0veSC5g=","Date":"Wed, 3 Apr 2019 13:35:48 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190403103548.GG12646@pendragon.ideasonboard.com>","References":"<20190403102545.7143-1-kieran.bingham@ideasonboard.com>\n\t<20190403102545.7143-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190403102545.7143-2-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: ipu3: Catch return\n\tvalue when disabling links","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Wed, 03 Apr 2019 10:36:00 -0000"}}]