{"id":901,"url":"https://patchwork.libcamera.org/api/patches/901/?format=json","web_url":"https://patchwork.libcamera.org/patch/901/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190403102545.7143-2-kieran.bingham@ideasonboard.com>","date":"2019-04-03T10:25:44","name":"[libcamera-devel,1/2] libcamera: ipu3: Catch return value when disabling links","commit_ref":"78552c818b8b9f9ea3b1a244e4d5ba2c86b07ce6","pull_url":null,"state":"accepted","archived":false,"hash":"63f954f234c1fa7cd602753ac15a021c455f1475","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/901/mbox/","series":[{"id":236,"url":"https://patchwork.libcamera.org/api/series/236/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=236","date":"2019-04-03T10:25:43","name":"Cleanups - for buildroot","version":1,"mbox":"https://patchwork.libcamera.org/series/236/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/901/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/901/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB62F6110E\n\tfor ;\n\tWed, 3 Apr 2019 12:25:57 +0200 (CEST)","from Q.imgcgcw.net (unknown [147.50.13.10])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A77A9AA;\n\tWed, 3 Apr 2019 12:25:55 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1554287157;\n\tbh=aFtJTRlak4oEQjDY4ywqQ2zlXRKvGj+Yg0DShaQGbO4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Eisuneg++3pLmQ10HQbxlKow3Nc//EkGm82s8VS+ELJxpZhkcugCt6EtqsImJC6bu\n\tjZfpXWJdf9cyKdg2QvrvtyQIyI/9SDClkG1E9CcWxPo96zGVt0Q/ZHx6RpwYQ6ld0W\n\tyMAyUs33XNL6GPCdHpxYewscHTOYbv2rOfmPYI2Q=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Wed, 3 Apr 2019 17:25:44 +0700","Message-Id":"<20190403102545.7143-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.19.1","In-Reply-To":"<20190403102545.7143-1-kieran.bingham@ideasonboard.com>","References":"<20190403102545.7143-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] libcamera: ipu3: Catch return value\n\twhen disabling links","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 03 Apr 2019 10:25:58 -0000"},"content":"Ensure that any error from the disableLinks() call during match() is\npropogated to the caller.\n\nFixes: d698ed27494a (\"libcamera: ipu3: Create ImgUDevice class\")\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 164e187c769d..fed04ce50387 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -511,7 +511,8 @@ bool PipelineHandlerIPU3::match(DeviceEnumerator *enumerator)\n \t * going through a library teardown->match() sequence would fail\n \t * at the moment.\n \t */\n-\tif (imguMediaDev_->disableLinks())\n+\tret = imguMediaDev_->disableLinks();\n+\tif (ret)\n \t\tgoto error;\n \n \tret = registerCameras();\n","prefixes":["libcamera-devel","1/2"]}