[{"id":11604,"web_url":"https://patchwork.libcamera.org/comment/11604/","msgid":"<20200725161748.GC6253@pendragon.ideasonboard.com>","date":"2020-07-25T16:17:48","subject":"Re: [libcamera-devel] [PATCH v2 3/6] andrdid: camera_device: Store\n\tconst templates","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nReviewed-by: Laurent Pinchart \n\nOn Sat, Jul 25, 2020 at 04:40:55PM +0200, Jacopo Mondi wrote:\n> The request capture templates stored in the\n> CameraDevice::requestTemplates_ should not be modified once created.\n> \n> Store a const pointer to the request templates in the class member\n> map.\n> \n> Reviewed-by: Laurent Pinchart /\n\n> Reviewed-by: Kieran Bingham \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_device.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index 5b8b9c3e26e2..af1b58ab6b4e 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -95,7 +95,7 @@ private:\n> \tstd::unique_ptr config_;\n> \n> \tCameraMetadata *staticMetadata_;\n> -\tstd::map requestTemplates_;\n> +\tstd::map requestTemplates_;\n> \tconst camera3_callback_ops_t *callbacks_;\n> \n> \tstd::vector streamConfigurations_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F318BD878\n\tfor ;\n\tSat, 25 Jul 2020 16:18:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B21F611A2;\n\tSat, 25 Jul 2020 18:18:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 99E8760399\n\tfor ;\n\tSat, 25 Jul 2020 18:17:58 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9759023D;\n\tSat, 25 Jul 2020 18:17:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RUsXOJT3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595693875;\n\tbh=MUUI3/2QAF0QV25JyTFPiNxCBP8i+/1WoWSohu2WsRE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RUsXOJT3UqJbxEsSIv1x4VrB6G9dL3hpjuhTA8EWMyYZpZfUzRfAufo6ozcE+f9Ly\n\tdKO6XconLmt4PIwQ8rsda5+ryS/T5z6dAh9HBz0ZXS4LM48mF6ePe081T3JoYq0ON3\n\tuSa5ea1Fht+Yl1SByj8yHonr4vP6IKp4qEVbuNC4=","Date":"Sat, 25 Jul 2020 19:17:48 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200725161748.GC6253@pendragon.ideasonboard.com>","References":"<20200725144058.129388-1-jacopo@jmondi.org>\n\t<20200725144058.129388-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200725144058.129388-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 3/6] andrdid: camera_device: Store\n\tconst templates","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]