[{"id":11603,"web_url":"https://patchwork.libcamera.org/comment/11603/","msgid":"<20200725161654.GB6253@pendragon.ideasonboard.com>","date":"2020-07-25T16:16:54","subject":"Re: [libcamera-devel] [PATCH v2 2/6] android: camera_metadata: Add\n\tconst version of get()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nReviewed-by: Laurent Pinchart \n\nOn Sat, Jul 25, 2020 at 04:40:54PM +0200, Jacopo Mondi wrote:\n> Add a const version of the CameraMetadata::get() method to retrieve\n> a const reference to the camera metadata wrapped by the class instance.\n\ns/reference/pointer/ ?\n\n> \n> Reviewed-by: Laurent Pinchart /\n\n> Reviewed-by: Kieran Bingham \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_metadata.cpp | 5 +++++\n> src/android/camera_metadata.h | 1 +\n> 2 files changed, 6 insertions(+)\n> \n> diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\n> index 47b2e4ef117a..ea33e9c2de25 100644\n> --- a/src/android/camera_metadata.cpp\n> +++ b/src/android/camera_metadata.cpp\n> @@ -50,3 +50,8 @@ camera_metadata_t *CameraMetadata::get()\n> {\n> \treturn valid_ ? metadata_ : nullptr;\n> }\n> +\n> +const camera_metadata_t *CameraMetadata::get() const\n> +{\n> +\treturn valid_ ? metadata_ : nullptr;\n> +}\n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index 348a018165ef..f16dd27bbf44 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -21,6 +21,7 @@ public:\n> \tbool addEntry(uint32_t tag, const void *data, size_t data_count);\n> \n> \tcamera_metadata_t *get();\n> +\tconst camera_metadata_t *get() const;\n> \n> private:\n> \tcamera_metadata_t *metadata_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CACF8BD878\n\tfor ;\n\tSat, 25 Jul 2020 16:17:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 99A6261223;\n\tSat, 25 Jul 2020 18:17:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3ECF60399\n\tfor ;\n\tSat, 25 Jul 2020 18:17:04 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 32DCB23D;\n\tSat, 25 Jul 2020 18:17:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BoS/e+nO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595693821;\n\tbh=epRJ0jDulbLz657yxiJgx9ETCjAsWPye5PrK1CbYhVg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BoS/e+nOoGsEGF8b97+brH6FBr/rHv2UtcU00chEHOvzsLSLXRHlQIujR8xxhESX+\n\t2uMrppvmyKVguZENq8TuBsfnuaqW55c/8mgrkdeKL4Mh6I7CEeGTXkmleGSRVHZloq\n\tCE7/KQXE93xAzwx854F9A7jzfEBo2AYiy2BHacU4=","Date":"Sat, 25 Jul 2020 19:16:54 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200725161654.GB6253@pendragon.ideasonboard.com>","References":"<20200725144058.129388-1-jacopo@jmondi.org>\n\t<20200725144058.129388-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200725144058.129388-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 2/6] android: camera_metadata: Add\n\tconst version of get()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11605,"web_url":"https://patchwork.libcamera.org/comment/11605/","msgid":"<20200725163059.gvaxptcowfjhucle@uno.localdomain>","date":"2020-07-25T16:30:59","subject":"Re: [libcamera-devel] [PATCH v2 2/6] android: camera_metadata: Add\n\tconst version of get()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Sat, Jul 25, 2020 at 07:16:54PM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Reviewed-by: Laurent Pinchart \n>\n> On Sat, Jul 25, 2020 at 04:40:54PM +0200, Jacopo Mondi wrote:\n> > Add a const version of the CameraMetadata::get() method to retrieve\n> > a const reference to the camera metadata wrapped by the class instance.\n>\n> s/reference/pointer/ ?\n>\n> >\n> > Reviewed-by: Laurent Pinchart \n> Here too, s/comR/com>/\n>\n\nUps, I copied and pasted tags\nSorry\n\n> > Reviewed-by: Kieran Bingham \n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/android/camera_metadata.cpp | 5 +++++\n> > src/android/camera_metadata.h | 1 +\n> > 2 files changed, 6 insertions(+)\n> >\n> > diff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\n> > index 47b2e4ef117a..ea33e9c2de25 100644\n> > --- a/src/android/camera_metadata.cpp\n> > +++ b/src/android/camera_metadata.cpp\n> > @@ -50,3 +50,8 @@ camera_metadata_t *CameraMetadata::get()\n> > {\n> > \treturn valid_ ? metadata_ : nullptr;\n> > }\n> > +\n> > +const camera_metadata_t *CameraMetadata::get() const\n> > +{\n> > +\treturn valid_ ? metadata_ : nullptr;\n> > +}\n> > diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> > index 348a018165ef..f16dd27bbf44 100644\n> > --- a/src/android/camera_metadata.h\n> > +++ b/src/android/camera_metadata.h\n> > @@ -21,6 +21,7 @@ public:\n> > \tbool addEntry(uint32_t tag, const void *data, size_t data_count);\n> >\n> > \tcamera_metadata_t *get();\n> > +\tconst camera_metadata_t *get() const;\n> >\n> > private:\n> > \tcamera_metadata_t *metadata_;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6597FBD86F\n\tfor ;\n\tSat, 25 Jul 2020 16:27:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0410461223;\n\tSat, 25 Jul 2020 18:27:24 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AADBB60399\n\tfor ;\n\tSat, 25 Jul 2020 18:27:22 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 2258B240008;\n\tSat, 25 Jul 2020 16:27:21 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Sat, 25 Jul 2020 18:30:59 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Message-ID":"<20200725163059.gvaxptcowfjhucle@uno.localdomain>","References":"<20200725144058.129388-1-jacopo@jmondi.org>\n\t<20200725144058.129388-3-jacopo@jmondi.org>\n\t<20200725161654.GB6253@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200725161654.GB6253@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/6] android: camera_metadata: Add\n\tconst version of get()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]