[{"id":11602,"web_url":"https://patchwork.libcamera.org/comment/11602/","msgid":"<20200725161547.GA6253@pendragon.ideasonboard.com>","date":"2020-07-25T16:15:47","subject":"Re: [libcamera-devel] [PATCH v2 1/6] android: camera_metadata: Mark\n\tisValid() as const","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Sat, Jul 25, 2020 at 04:40:53PM +0200, Jacopo Mondi wrote:\n> The CameraMetadata::isValid() method does not modify the object state\n> and can be called on const instances of the CameraMetadata class.\n> \n> Mark the method as const to allow that.\n> \n> Reviewed-by: Laurent Pinchart /\n\n> Reviewed-by: Kieran Bingham \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/android/camera_metadata.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\n> index 75a9d7066f31..348a018165ef 100644\n> --- a/src/android/camera_metadata.h\n> +++ b/src/android/camera_metadata.h\n> @@ -17,7 +17,7 @@ public:\n> \tCameraMetadata(size_t entryCapacity, size_t dataCapacity);\n> \t~CameraMetadata();\n> \n> -\tbool isValid() { return valid_; }\n> +\tbool isValid() const { return valid_; }\n> \tbool addEntry(uint32_t tag, const void *data, size_t data_count);\n> \n> \tcamera_metadata_t *get();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 59318BD86F\n\tfor ;\n\tSat, 25 Jul 2020 16:16:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C965761223;\n\tSat, 25 Jul 2020 18:16:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59CD560399\n\tfor ;\n\tSat, 25 Jul 2020 18:15:58 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 93C7023D;\n\tSat, 25 Jul 2020 18:15:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PYHKbH/W\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595693757;\n\tbh=RuEZIjfAFKvg0eP031M7aPQj/u5Nubgqd9/oL8MSmUk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PYHKbH/WMwxk6448xgfcvvswOYS7aoHd1021/vB+46eo2fPB9NCvuelSm3yWWq9oj\n\tZapgmfw9EoshAYVuOxU5dTKI5O0+6MO5K3MPioiuhaJX0FD3VM5rIe34EdqAwOEOVx\n\tdPydWhZy3QMUSCHrvNB1/r9zzBIZuQrJk4vFkdmY=","Date":"Sat, 25 Jul 2020 19:15:47 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200725161547.GA6253@pendragon.ideasonboard.com>","References":"<20200725144058.129388-1-jacopo@jmondi.org>\n\t<20200725144058.129388-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200725144058.129388-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 1/6] android: camera_metadata: Mark\n\tisValid() as const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]