{"id":9001,"url":"https://patchwork.libcamera.org/api/patches/9001/?format=json","web_url":"https://patchwork.libcamera.org/patch/9001/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200725144058.129388-2-jacopo@jmondi.org>","date":"2020-07-25T14:40:53","name":"[libcamera-devel,v2,1/6] android: camera_metadata: Mark isValid() as const","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"26b759d77b4cb99fe3f3d39f69a3c04df7420870","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/9001/mbox/","series":[{"id":1146,"url":"https://patchwork.libcamera.org/api/series/1146/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1146","date":"2020-07-25T14:40:52","name":"android: camera_device: Generate correct preview template","version":2,"mbox":"https://patchwork.libcamera.org/series/1146/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/9001/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/9001/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 25A04BD86F\n\tfor ;\n\tSat, 25 Jul 2020 14:37:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0223E612F1;\n\tSat, 25 Jul 2020 16:37:29 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7B33611A2\n\tfor ;\n\tSat, 25 Jul 2020 16:37:26 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id E671C240008;\n\tSat, 25 Jul 2020 14:37:25 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 25 Jul 2020 16:40:53 +0200","Message-Id":"<20200725144058.129388-2-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200725144058.129388-1-jacopo@jmondi.org>","References":"<20200725144058.129388-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 1/6] android: camera_metadata: Mark\n\tisValid() as const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CameraMetadata::isValid() method does not modify the object state\nand can be called on const instances of the CameraMetadata class.\n\nMark the method as const to allow that.\n\nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_metadata.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_metadata.h b/src/android/camera_metadata.h\nindex 75a9d7066f31..348a018165ef 100644\n--- a/src/android/camera_metadata.h\n+++ b/src/android/camera_metadata.h\n@@ -17,7 +17,7 @@ public:\n \tCameraMetadata(size_t entryCapacity, size_t dataCapacity);\n \t~CameraMetadata();\n \n-\tbool isValid() { return valid_; }\n+\tbool isValid() const { return valid_; }\n \tbool addEntry(uint32_t tag, const void *data, size_t data_count);\n \n \tcamera_metadata_t *get();\n","prefixes":["libcamera-devel","v2","1/6"]}