[{"id":11610,"web_url":"https://patchwork.libcamera.org/comment/11610/","msgid":"<20200726235830.GN28704@pendragon.ideasonboard.com>","date":"2020-07-26T23:58:30","subject":"Re: [libcamera-devel] [PATCH 3/3] test: list-cameras: skip if no\n\tcamera is available","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi You-Sheng,\n\nThank you for the patch.\n\nOn Sat, Jul 25, 2020 at 08:24:42PM +0800, You-Sheng Yang wrote:\n> Signed-off-by: You-Sheng Yang \n> ---\n> test/list-cameras.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/list-cameras.cpp b/test/list-cameras.cpp\n> index e6a407a..f4cd3b7 100644\n> --- a/test/list-cameras.cpp\n> +++ b/test/list-cameras.cpp\n> @@ -26,7 +26,7 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> -\t\treturn 0;\n> +\t\treturn cm_->cameras().size() ? TestPass : TestSkip;\n\nI think this test should instead be dropped completely. It's the first\ntest case we've added, in order to start development of the unit tests,\nand it doesn't serve much purpose anymore as we have a bunch of other\ntests that exercise the same API, and more.\n\n> \t}\n> \n> \tint run()","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAFD0BD86F\n\tfor ;\n\tSun, 26 Jul 2020 23:58:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E5A861223;\n\tMon, 27 Jul 2020 01:58:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A29DE60399\n\tfor ;\n\tMon, 27 Jul 2020 01:58:38 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1530E304;\n\tMon, 27 Jul 2020 01:58:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FVpRNoax\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595807918;\n\tbh=HtrKpOTiYfe4rvMO/sFTIvecBq4xFX7XKI6QczQ6T2A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FVpRNoaxENAPRpWoNBL3vps6mqZL7YXeQ+XqiG4LU88nPMNzSzf96SYQPjWKUtF/7\n\t4vyE0S35X1EijJykezYj4+f82WPmHO0VDiyCyPtL651wzvg9qwrfcp06ftUqAbvDic\n\tM+yKK1PlUVF+HwMjrSI5tjGtE9oyrDzuO2HxlFeA=","Date":"Mon, 27 Jul 2020 02:58:30 +0300","From":"Laurent Pinchart ","To":"You-Sheng Yang ","Message-ID":"<20200726235830.GN28704@pendragon.ideasonboard.com>","References":"<20200725122442.1679820-1-vicamo.yang@canonical.com>\n\t<20200725122442.1679820-4-vicamo.yang@canonical.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200725122442.1679820-4-vicamo.yang@canonical.com>","Subject":"Re: [libcamera-devel] [PATCH 3/3] test: list-cameras: skip if no\n\tcamera is available","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]