{"id":8982,"url":"https://patchwork.libcamera.org/api/patches/8982/?format=json","web_url":"https://patchwork.libcamera.org/patch/8982/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200724171404.736509-3-niklas.soderlund@ragnatech.se>","date":"2020-07-24T17:14:04","name":"[libcamera-devel,v2,2/2] libcamera: Add support for 16-bit Bayer formats","commit_ref":"3437067e9bd923ee4dce857d83d7bce0f791537d","pull_url":null,"state":"accepted","archived":false,"hash":"9ea6bcdd7a00ab1a4f2ef42e35e691d8e7699458","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8982/mbox/","series":[{"id":1140,"url":"https://patchwork.libcamera.org/api/series/1140/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1140","date":"2020-07-24T17:14:02","name":"libcamera: Add support for 16-bit Bayer formats","version":2,"mbox":"https://patchwork.libcamera.org/series/1140/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8982/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8982/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1BB19BD86F\n\tfor ;\n\tFri, 24 Jul 2020 17:14:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EB13761236;\n\tFri, 24 Jul 2020 19:14:19 +0200 (CEST)","from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 831056039B\n\tfor ;\n\tFri, 24 Jul 2020 19:14:16 +0200 (CEST)","from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid 19808760-cdd1-11ea-933e-005056917a89;\n\tFri, 24 Jul 2020 19:14:15 +0200 (CEST)"],"X-Halon-ID":"19808760-cdd1-11ea-933e-005056917a89","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 24 Jul 2020 19:14:04 +0200","Message-Id":"<20200724171404.736509-3-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200724171404.736509-1-niklas.soderlund@ragnatech.se>","References":"<20200724171404.736509-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 2/2] libcamera: Add support for 16-bit\n\tBayer formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add support for 16-bit Bayer formats.\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/formats.cpp | 40 ++++++++++++++++++++++++++++++\n src/libcamera/formats.yaml | 9 +++++++\n src/libcamera/v4l2_pixelformat.cpp | 4 +++\n 3 files changed, 53 insertions(+)","diff":"diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 11774b0cfb123f58..cd63c15cb926d569 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -563,6 +563,46 @@ const std::map pixelFormatInfo{\n \t\t.pixelsPerGroup = 2,\n \t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n+\t{ formats::SBGGR16, {\n+\t\t.name = \"SBGGR16\",\n+\t\t.format = formats::SBGGR16,\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_SBGGR16),\n+\t\t.bitsPerPixel = 16,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n+\t{ formats::SGBRG16, {\n+\t\t.name = \"SGBRG16\",\n+\t\t.format = formats::SGBRG16,\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_SGBRG16),\n+\t\t.bitsPerPixel = 16,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n+\t{ formats::SGRBG16, {\n+\t\t.name = \"SGRBG16\",\n+\t\t.format = formats::SGRBG16,\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_SGRBG16),\n+\t\t.bitsPerPixel = 16,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n+\t{ formats::SRGGB16, {\n+\t\t.name = \"SRGGB16\",\n+\t\t.format = formats::SRGGB16,\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_SRGGB16),\n+\t\t.bitsPerPixel = 16,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 2,\n+\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \t{ formats::SBGGR10_IPU3, {\n \t\t.name = \"SBGGR10_IPU3\",\n \t\t.format = formats::SBGGR10_IPU3,\ndiff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\nindex 3a69c05fcc04fb93..6a2fb721b7c649b6 100644\n--- a/src/libcamera/formats.yaml\n+++ b/src/libcamera/formats.yaml\n@@ -93,6 +93,15 @@ formats:\n - SBGGR12:\n fourcc: DRM_FORMAT_SBGGR12\n \n+ - SRGGB16:\n+ fourcc: DRM_FORMAT_SRGGB16\n+ - SGRBG16:\n+ fourcc: DRM_FORMAT_SGRBG16\n+ - SGBRG16:\n+ fourcc: DRM_FORMAT_SGBRG16\n+ - SBGGR16:\n+ fourcc: DRM_FORMAT_SBGGR16\n+\n - SRGGB10_CSI2P:\n fourcc: DRM_FORMAT_SRGGB10\n mod: MIPI_FORMAT_MOD_CSI2_PACKED\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex c8f69ee9654223b3..8391ec48ac1009b6 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -92,6 +92,10 @@ const std::map vpf2pf{\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG12P), formats::SGBRG12_CSI2P },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG12P), formats::SGRBG12_CSI2P },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB12P), formats::SRGGB12_CSI2P },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR16), formats::SBGGR16 },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG16), formats::SGBRG16 },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG16), formats::SGRBG16 },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB16), formats::SRGGB16 },\n \n \t/* Compressed formats. */\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_MJPEG), formats::MJPEG },\n","prefixes":["libcamera-devel","v2","2/2"]}