[{"id":11581,"web_url":"https://patchwork.libcamera.org/comment/11581/","msgid":"<20200724172625.GU5921@pendragon.ideasonboard.com>","date":"2020-07-24T17:26:25","subject":"Re: [libcamera-devel] [PATCH v2 1/2] include: drm_fourcc: Add\n\t16-bit Bayer FourCC","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Jul 24, 2020 at 07:14:03PM +0200, Niklas Söderlund wrote:\n> The patch trying to upstream Bayer formats to the DRM FourCC header file\n> in Linux left out the 16-bit formats, add them. This addition will be\n> included in the next version of the DRM Bayer patch sent out.\n> \n> Intention is to merge this in libcamera and update the header file once\n> the upstream patch is picked up.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> * Changes since v1\n> - Use non conflicting FourCC for DRM_FORMAT_SRGGB16.\n> ---\n> include/linux/drm_fourcc.h | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h\n> index 69240dfe1df0df28..72453692bdefacc4 100644\n> --- a/include/linux/drm_fourcc.h\n> +++ b/include/linux/drm_fourcc.h\n> @@ -344,6 +344,12 @@ extern \"C\" {\n> #define DRM_FORMAT_SGBRG14\tfourcc_code('G', 'B', '1', '4')\n> #define DRM_FORMAT_SBGGR14\tfourcc_code('B', 'G', '1', '4')\n> \n> +/* 16-bit Bayer formats */\n> +#define DRM_FORMAT_SRGGB16\tfourcc_code('R', 'G', 'B', '6')\n> +#define DRM_FORMAT_SGRBG16\tfourcc_code('G', 'R', '1', '6')\n> +#define DRM_FORMAT_SGBRG16\tfourcc_code('G', 'B', '1', '6')\n> +#define DRM_FORMAT_SBGGR16\tfourcc_code('B', 'Y', 'R', '2')\n> +\n> /*\n> * Format Modifiers:\n> *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D848BD878\n\tfor ;\n\tFri, 24 Jul 2020 17:26:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 36EED6121D;\n\tFri, 24 Jul 2020 19:26:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CEFD46039B\n\tfor ;\n\tFri, 24 Jul 2020 19:26:32 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 645A5538;\n\tFri, 24 Jul 2020 19:26:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BuNhfCEI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595611592;\n\tbh=+0Ili6EZwHTpX8A99Sgw13RdrYPLyMGOzutgfoE7IQE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BuNhfCEIHMjgQ03GJT/RDpEpE4Qks57ymqj2XiY8pUnUsDZyAaRgcvbRhyDZZvHJB\n\twRvWBQTFjMzQO0NBERYC9bAOIFPQ+9DWBlx9hrjOH7MDOWzCrhICNWq/rAJ+bmT6vC\n\tcZcl56MrK+dlj3GcmGPgH3dugjq0IfAS6zRo6vZ0=","Date":"Fri, 24 Jul 2020 20:26:25 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200724172625.GU5921@pendragon.ideasonboard.com>","References":"<20200724171404.736509-1-niklas.soderlund@ragnatech.se>\n\t<20200724171404.736509-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200724171404.736509-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] include: drm_fourcc: Add\n\t16-bit Bayer FourCC","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]