[{"id":11588,"web_url":"https://patchwork.libcamera.org/comment/11588/","msgid":"<20200724214747.GG5921@pendragon.ideasonboard.com>","date":"2020-07-24T21:47:47","subject":"Re: [libcamera-devel] [PATCH v2 3/3] libcamera: qcam: Improve\n\tcolour information in DNG files","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Fri, Jul 24, 2020 at 03:56:18PM +0100, David Plowman wrote:\n> This patch improves the colour information recorded in DNG files using\n> the ColourCorrectionMatrix metadata for the image. Note that we are\n> not supplying a full calibration using two illuminants, nonetheless\n> the single matrix here appears to be respected by a number of tools.\n> \n> Signed-off-by: David Plowman \n> ---\n> src/qcam/dng_writer.cpp | 138 ++++++++++++++++++++++++++++++++++++++++\n> 1 file changed, 138 insertions(+)\n> \n> diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\n> index 61505d3..4f638ec 100644\n> --- a/src/qcam/dng_writer.cpp\n> +++ b/src/qcam/dng_writer.cpp\n> @@ -34,6 +34,97 @@ struct FormatInfo {\n> \t\t\t unsigned int stride);\n> };\n> \n> +struct Matrix3d {\n> +\tMatrix3d()\n> +\t{\n> +\t}\n> +\n> +\tMatrix3d(float m0, float m1, float m2,\n> +\t\t float m3, float m4, float m5,\n> +\t\t float m6, float m7, float m8)\n> +\t{\n> +\t\tm[0] = m0, m[1] = m1, m[2] = m2;\n> +\t\tm[3] = m3, m[4] = m4, m[5] = m5;\n> +\t\tm[6] = m6, m[7] = m7, m[8] = m8;\n> +\t}\n> +\n> +\tMatrix3d(Span const &span)\n\nWe usually put the const keyword before the type.\n\n> +\t\t: Matrix3d(span[0], span[1], span[2],\n> +\t\t\t span[3], span[4], span[5],\n> +\t\t\t span[6], span[7], span[8])\n> +\t{\n> +\t}\n> +\n> +\tstatic Matrix3d diag(float diag0, float diag1, float diag2)\n> +\t{\n> +\t\treturn Matrix3d(diag0, 0, 0, 0, diag1, 0, 0, 0, diag2);\n> +\t}\n> +\n> +\tstatic Matrix3d identity()\n> +\t{\n> +\t\treturn Matrix3d(1, 0, 0, 0, 1, 0, 0, 0, 1);\n> +\t}\n> +\n> +\tMatrix3d transpose() const\n> +\t{\n> +\t\treturn { m[0], m[3], m[6], m[1], m[4], m[7], m[2], m[5], m[8] };\n> +\t}\n> +\n> +\tMatrix3d cofactors() const\n> +\t{\n> +\t\treturn { m[4] * m[8] - m[5] * m[7],\n> +\t\t\t -(m[3] * m[8] - m[5] * m[6]),\n> +\t\t\t m[3] * m[7] - m[4] * m[6],\n> +\t\t\t -(m[1] * m[8] - m[2] * m[7]),\n> +\t\t\t m[0] * m[8] - m[2] * m[6],\n> +\t\t\t -(m[0] * m[7] - m[1] * m[6]),\n> +\t\t\t m[1] * m[5] - m[2] * m[4],\n> +\t\t\t -(m[0] * m[5] - m[2] * m[3]),\n> +\t\t\t m[0] * m[4] - m[1] * m[3] };\n> +\t}\n> +\n> +\tMatrix3d adjugate() const\n> +\t{\n> +\t\treturn cofactors().transpose();\n> +\t}\n> +\n> +\tfloat determinant() const\n> +\t{\n> +\t\treturn m[0] * (m[4] * m[8] - m[5] * m[7]) -\n> +\t\t m[1] * (m[3] * m[8] - m[5] * m[6]) +\n> +\t\t m[2] * (m[3] * m[7] - m[4] * m[6]);\n> +\t}\n> +\n> +\tMatrix3d inverse() const\n> +\t{\n> +\t\treturn adjugate() * (1.0 / determinant());\n> +\t}\n> +\n> +\tMatrix3d operator*(Matrix3d const &other) const\n\nSame here.\n\n> +\t{\n> +\t\tMatrix3d result;\n> +\t\tfor (unsigned int i = 0; i < 3; i++) {\n> +\t\t\tfor (unsigned int j = 0; j < 3; j++) {\n> +\t\t\t\tresult.m[i * 3 + j] =\n> +\t\t\t\t\tm[i * 3 + 0] * other.m[0 + j] +\n> +\t\t\t\t\tm[i * 3 + 1] * other.m[3 + j] +\n> +\t\t\t\t\tm[i * 3 + 2] * other.m[6 + j];\n> +\t\t\t}\n> +\t\t}\n> +\t\treturn result;\n> +\t}\n> +\n> +\tMatrix3d operator*(float f) const\n> +\t{\n> +\t\tMatrix3d result;\n> +\t\tfor (unsigned int i = 0; i < 9; i++)\n> +\t\t\tresult.m[i] = m[i] * f;\n> +\t\treturn result;\n> +\t}\n> +\n> +\tfloat m[9];\n> +};\n\nA couple of comments if we later want a 3x3 matrix implementation in\nlibcamera:\n\n- The inverse function should guard against division by 0\n- Most functions should be constexpr\n\nNot something we need to address now.\n\n> +\n> void packScanlineSBGGR10P(void *output, const void *input, unsigned int width)\n> {\n> \tconst uint8_t *in = static_cast(input);\n> @@ -315,6 +406,53 @@ int DNGWriter::write(const char *filename, const Camera *camera,\n> \tTIFFSetField(tif, TIFFTAG_PLANARCONFIG, PLANARCONFIG_CONTIG);\n> \tTIFFSetField(tif, TIFFTAG_SAMPLEFORMAT, SAMPLEFORMAT_UINT);\n> \n> +\t/*\n> +\t * Fill in some reasonable colour information in the DNG. We supply\n> +\t * the \"neutral\" colour values which determine the white balance, and the\n> +\t * \"ColorMatrix1\" which converts XYZ to (un-white-balanced) camera RGB.\n> +\t * Note that this is not a \"proper\" colour calibration for the DNG,\n> +\t * nonetheless, many tools should be able to render the colours better.\n> +\t */\n> +\tfloat neutral[3] = { 1, 1, 1 };\n> +\tMatrix3d wbGain = Matrix3d::identity();\n> +\t/* From http://www.brucelindbloom.com/index.html?Eqn_RGB_XYZ_Matrix.html */\n> +\tconst Matrix3d rgb2xyz(0.4124564, 0.3575761, 0.1804375,\n> +\t\t\t 0.2126729, 0.7151522, 0.0721750,\n> +\t\t\t 0.0193339, 0.1191920, 0.9503041);\n> +\tMatrix3d ccm = Matrix3d::identity();\n> +\t/*\n> +\t * Pick a reasonable number eps to protect against singularities. It\n> +\t * should be comfortably larger than the point at which we run into\n> +\t * numerical trouble, yet smaller than any plausible gain that we might\n> +\t * apply to a colour, either explicitly or as part of the colour matrix.\n> +\t */\n> +\tconst double eps = 1e-2;\n> +\n> +\tif (metadata.contains(controls::ColourGains)) {\n> +\t\tSpan const &colourGains = metadata.get(controls::ColourGains);\n> +\t\tif (colourGains[0] > eps && colourGains[1] > eps) {\n> +\t\t\twbGain = Matrix3d::diag(colourGains[0], 1, colourGains[1]);\n> +\t\t\tneutral[0] = 1.0 / colourGains[0]; /* red */\n> +\t\t\tneutral[2] = 1.0 / colourGains[1]; /* blue */\n> +\t\t}\n> +\t}\n> +\tif (metadata.contains(controls::ColourCorrectionMatrix)) {\n> +\t\tSpan const &coeffs = metadata.get(controls::ColourCorrectionMatrix);\n> +\t\tMatrix3d ccm_supplied(coeffs);\n\ns/ccm_supplied/ccmSupplied/\n\nReviewed-by: Laurent Pinchart \n\nI've addressed those small issues when applying the patches, I'll push\nright after testing.\n\n> +\t\tif (ccm_supplied.determinant() > eps)\n> +\t\t\tccm = ccm_supplied;\n> +\t}\n> +\n> +\t/*\n> +\t * rgb2xyz is known to be invertible, and we've ensured above that both\n> +\t * the ccm and wbGain matrices are non-singular, so the product of all\n> +\t * three is guaranteed to be invertible too.\n> +\t */\n> +\tMatrix3d colorMatrix1 = (rgb2xyz * ccm * wbGain).inverse();\n> +\n> +\tTIFFSetField(tif, TIFFTAG_COLORMATRIX1, 9, colorMatrix1.m);\n> +\tTIFFSetField(tif, TIFFTAG_ASSHOTNEUTRAL, 3, neutral);\n> +\n> \t/*\n> \t * Reserve space for the SubIFD and ExifIFD tags, pointing to the IFD\n> \t * for the raw image and EXIF data respectively. The real offsets will","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2AADBBD878\n\tfor ;\n\tFri, 24 Jul 2020 21:47:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 833716121D;\n\tFri, 24 Jul 2020 23:47:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 297C56039B\n\tfor ;\n\tFri, 24 Jul 2020 23:47:55 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 94E48538;\n\tFri, 24 Jul 2020 23:47:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GY4HAgbq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595627274;\n\tbh=WQa5wDU4jag2JS7/N4j5vj0+CF+Os6am+ENUIJZuK3U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GY4HAgbqr0kPk4scn8mfS/jeM04OP2s1gq92zdnzHNq/Y31dfqlsOKV8YZis6RXxT\n\tNgMjNpxsfOR9ml2lKIVusFkqgpu8qzhNbLdigC5Fm005LvXXbkxvjZWIdrYL4XzSn8\n\t5Wi0DWp5cRrZLRwCFbs7ypkJqdbVst+7R8ARtpoQ=","Date":"Sat, 25 Jul 2020 00:47:47 +0300","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"<20200724214747.GG5921@pendragon.ideasonboard.com>","References":"<20200724145618.26304-1-david.plowman@raspberrypi.com>\n\t<20200724145618.26304-4-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200724145618.26304-4-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/3] libcamera: qcam: Improve\n\tcolour information in DNG files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11589,"web_url":"https://patchwork.libcamera.org/comment/11589/","msgid":"","date":"2020-07-24T23:04:01","subject":"Re: [libcamera-devel] [PATCH v2 3/3] libcamera: qcam: Improve\n\tcolour information in DNG files","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Laurent\n\nThanks for taking care of those remaining issues, I shall work on\nimproving my bad habits!\n\nBest regards (and have a good weekend!)\nDavid\n\nOn Fri, 24 Jul 2020 at 22:47, Laurent Pinchart\n wrote:\n>\n> Hi David,\n>\n> Thank you for the patch.\n>\n> On Fri, Jul 24, 2020 at 03:56:18PM +0100, David Plowman wrote:\n> > This patch improves the colour information recorded in DNG files using\n> > the ColourCorrectionMatrix metadata for the image. Note that we are\n> > not supplying a full calibration using two illuminants, nonetheless\n> > the single matrix here appears to be respected by a number of tools.\n> >\n> > Signed-off-by: David Plowman \n> > ---\n> > src/qcam/dng_writer.cpp | 138 ++++++++++++++++++++++++++++++++++++++++\n> > 1 file changed, 138 insertions(+)\n> >\n> > diff --git a/src/qcam/dng_writer.cpp b/src/qcam/dng_writer.cpp\n> > index 61505d3..4f638ec 100644\n> > --- a/src/qcam/dng_writer.cpp\n> > +++ b/src/qcam/dng_writer.cpp\n> > @@ -34,6 +34,97 @@ struct FormatInfo {\n> > unsigned int stride);\n> > };\n> >\n> > +struct Matrix3d {\n> > + Matrix3d()\n> > + {\n> > + }\n> > +\n> > + Matrix3d(float m0, float m1, float m2,\n> > + float m3, float m4, float m5,\n> > + float m6, float m7, float m8)\n> > + {\n> > + m[0] = m0, m[1] = m1, m[2] = m2;\n> > + m[3] = m3, m[4] = m4, m[5] = m5;\n> > + m[6] = m6, m[7] = m7, m[8] = m8;\n> > + }\n> > +\n> > + Matrix3d(Span const &span)\n>\n> We usually put the const keyword before the type.\n>\n> > + : Matrix3d(span[0], span[1], span[2],\n> > + span[3], span[4], span[5],\n> > + span[6], span[7], span[8])\n> > + {\n> > + }\n> > +\n> > + static Matrix3d diag(float diag0, float diag1, float diag2)\n> > + {\n> > + return Matrix3d(diag0, 0, 0, 0, diag1, 0, 0, 0, diag2);\n> > + }\n> > +\n> > + static Matrix3d identity()\n> > + {\n> > + return Matrix3d(1, 0, 0, 0, 1, 0, 0, 0, 1);\n> > + }\n> > +\n> > + Matrix3d transpose() const\n> > + {\n> > + return { m[0], m[3], m[6], m[1], m[4], m[7], m[2], m[5], m[8] };\n> > + }\n> > +\n> > + Matrix3d cofactors() const\n> > + {\n> > + return { m[4] * m[8] - m[5] * m[7],\n> > + -(m[3] * m[8] - m[5] * m[6]),\n> > + m[3] * m[7] - m[4] * m[6],\n> > + -(m[1] * m[8] - m[2] * m[7]),\n> > + m[0] * m[8] - m[2] * m[6],\n> > + -(m[0] * m[7] - m[1] * m[6]),\n> > + m[1] * m[5] - m[2] * m[4],\n> > + -(m[0] * m[5] - m[2] * m[3]),\n> > + m[0] * m[4] - m[1] * m[3] };\n> > + }\n> > +\n> > + Matrix3d adjugate() const\n> > + {\n> > + return cofactors().transpose();\n> > + }\n> > +\n> > + float determinant() const\n> > + {\n> > + return m[0] * (m[4] * m[8] - m[5] * m[7]) -\n> > + m[1] * (m[3] * m[8] - m[5] * m[6]) +\n> > + m[2] * (m[3] * m[7] - m[4] * m[6]);\n> > + }\n> > +\n> > + Matrix3d inverse() const\n> > + {\n> > + return adjugate() * (1.0 / determinant());\n> > + }\n> > +\n> > + Matrix3d operator*(Matrix3d const &other) const\n>\n> Same here.\n>\n> > + {\n> > + Matrix3d result;\n> > + for (unsigned int i = 0; i < 3; i++) {\n> > + for (unsigned int j = 0; j < 3; j++) {\n> > + result.m[i * 3 + j] =\n> > + m[i * 3 + 0] * other.m[0 + j] +\n> > + m[i * 3 + 1] * other.m[3 + j] +\n> > + m[i * 3 + 2] * other.m[6 + j];\n> > + }\n> > + }\n> > + return result;\n> > + }\n> > +\n> > + Matrix3d operator*(float f) const\n> > + {\n> > + Matrix3d result;\n> > + for (unsigned int i = 0; i < 9; i++)\n> > + result.m[i] = m[i] * f;\n> > + return result;\n> > + }\n> > +\n> > + float m[9];\n> > +};\n>\n> A couple of comments if we later want a 3x3 matrix implementation in\n> libcamera:\n>\n> - The inverse function should guard against division by 0\n> - Most functions should be constexpr\n>\n> Not something we need to address now.\n>\n> > +\n> > void packScanlineSBGGR10P(void *output, const void *input, unsigned int width)\n> > {\n> > const uint8_t *in = static_cast(input);\n> > @@ -315,6 +406,53 @@ int DNGWriter::write(const char *filename, const Camera *camera,\n> > TIFFSetField(tif, TIFFTAG_PLANARCONFIG, PLANARCONFIG_CONTIG);\n> > TIFFSetField(tif, TIFFTAG_SAMPLEFORMAT, SAMPLEFORMAT_UINT);\n> >\n> > + /*\n> > + * Fill in some reasonable colour information in the DNG. We supply\n> > + * the \"neutral\" colour values which determine the white balance, and the\n> > + * \"ColorMatrix1\" which converts XYZ to (un-white-balanced) camera RGB.\n> > + * Note that this is not a \"proper\" colour calibration for the DNG,\n> > + * nonetheless, many tools should be able to render the colours better.\n> > + */\n> > + float neutral[3] = { 1, 1, 1 };\n> > + Matrix3d wbGain = Matrix3d::identity();\n> > + /* From http://www.brucelindbloom.com/index.html?Eqn_RGB_XYZ_Matrix.html */\n> > + const Matrix3d rgb2xyz(0.4124564, 0.3575761, 0.1804375,\n> > + 0.2126729, 0.7151522, 0.0721750,\n> > + 0.0193339, 0.1191920, 0.9503041);\n> > + Matrix3d ccm = Matrix3d::identity();\n> > + /*\n> > + * Pick a reasonable number eps to protect against singularities. It\n> > + * should be comfortably larger than the point at which we run into\n> > + * numerical trouble, yet smaller than any plausible gain that we might\n> > + * apply to a colour, either explicitly or as part of the colour matrix.\n> > + */\n> > + const double eps = 1e-2;\n> > +\n> > + if (metadata.contains(controls::ColourGains)) {\n> > + Span const &colourGains = metadata.get(controls::ColourGains);\n> > + if (colourGains[0] > eps && colourGains[1] > eps) {\n> > + wbGain = Matrix3d::diag(colourGains[0], 1, colourGains[1]);\n> > + neutral[0] = 1.0 / colourGains[0]; /* red */\n> > + neutral[2] = 1.0 / colourGains[1]; /* blue */\n> > + }\n> > + }\n> > + if (metadata.contains(controls::ColourCorrectionMatrix)) {\n> > + Span const &coeffs = metadata.get(controls::ColourCorrectionMatrix);\n> > + Matrix3d ccm_supplied(coeffs);\n>\n> s/ccm_supplied/ccmSupplied/\n>\n> Reviewed-by: Laurent Pinchart \n>\n> I've addressed those small issues when applying the patches, I'll push\n> right after testing.\n>\n> > + if (ccm_supplied.determinant() > eps)\n> > + ccm = ccm_supplied;\n> > + }\n> > +\n> > + /*\n> > + * rgb2xyz is known to be invertible, and we've ensured above that both\n> > + * the ccm and wbGain matrices are non-singular, so the product of all\n> > + * three is guaranteed to be invertible too.\n> > + */\n> > + Matrix3d colorMatrix1 = (rgb2xyz * ccm * wbGain).inverse();\n> > +\n> > + TIFFSetField(tif, TIFFTAG_COLORMATRIX1, 9, colorMatrix1.m);\n> > + TIFFSetField(tif, TIFFTAG_ASSHOTNEUTRAL, 3, neutral);\n> > +\n> > /*\n> > * Reserve space for the SubIFD and ExifIFD tags, pointing to the IFD\n> > * for the raw image and EXIF data respectively. The real offsets will\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AAC6ABD86F\n\tfor ;\n\tFri, 24 Jul 2020 23:04:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 16FB361223;\n\tSat, 25 Jul 2020 01:04:16 +0200 (CEST)","from mail-oi1-x242.google.com (mail-oi1-x242.google.com\n\t[IPv6:2607:f8b0:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E70C60496\n\tfor ;\n\tSat, 25 Jul 2020 01:04:14 +0200 (CEST)","by mail-oi1-x242.google.com with SMTP id h17so9395613oie.3\n\tfor ;\n\tFri, 24 Jul 2020 16:04:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ndfJX0/8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=3gbj9RnjBkNG4K5cPj/ImQGAXvMfeZlHbIuM+SpHrHI=;\n\tb=ndfJX0/86H5rFgLu9/RBN1MBn7eI//hZgfgeG1zhruA5FVMK9Ti+n/53fxijHBijuS\n\tcaqUa7Y6FDNM87R/WUjv6Osl8gv98+0hqWn20OQyqmfmCP1jxY9a+8PtGWLb98m1RMBy\n\tq8Nyem1PSPM1ztguAiSU+jO4TQjKKIXDEuHfAyQAyqvpZ3U5q09sOaRJ2y93Wbi07R/X\n\t2pmtDEHzEp/OpSNQiQBYtEx15IC1okxA0b+Og4VxDjtz4KZcdCsNv3Lx/AeD0/tku61n\n\tUWMNYUd/yjZmfKEzJnLGOhB5jwDRNaltM/xDZqqhurBQEsT56zBkvYmXcuzaG/UGYTYP\n\tPkMQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=3gbj9RnjBkNG4K5cPj/ImQGAXvMfeZlHbIuM+SpHrHI=;\n\tb=T+Ox5CB81iVBDWhawW5fnqI+HH3ROw9CzvQOmVm8J2RXN429rgmAZj7CMEuB+fs5ha\n\t+xCX7BaGWI/7UrQ9kRRlLjfxQkQBzdcWjTe9zCuXo0kz9VVNGR2VQesIEFY5a/To7rCb\n\tLswRfpqD4HBLNBUDX1mPv7S1QEridPYRhGklP9aobRUURSIpypxxEA8cnQcR5/iiBj2h\n\tegzCdOpttbKTXTwKEHebcBx29rkOwI3QxQTR0su10UpQwEEIGTQjmHoOVxl2F1je25NX\n\tUaf70xl+CCAWmhd1rg4wCujF0CRcVJlNdD/O/MIIZenHmpU0SjEm0UifwlfCva5J2GIN\n\tamaQ==","X-Gm-Message-State":"AOAM5316525CtSYl4FIxIvFh0Rvx3Klf+5HGeCEJc/C2elv8l79gjL9t\n\tBtevxeX5JC0r4ui9MDsZngNChXg5yiKj+p2nPKH7xQ==","X-Google-Smtp-Source":"ABdhPJxPSwgzAIKYxtBHo551474HiZ2nJprkxuYt9xU3ga/Ws+nyq43hYe1peSuQjt6UyNUd9UkuZ9wO1Hmy+lNbS64=","X-Received":"by 2002:aca:84e:: with SMTP id 75mr10403653oii.107.1595631852386;\n\tFri, 24 Jul 2020 16:04:12 -0700 (PDT)","MIME-Version":"1.0","References":"<20200724145618.26304-1-david.plowman@raspberrypi.com>\n\t<20200724145618.26304-4-david.plowman@raspberrypi.com>\n\t<20200724214747.GG5921@pendragon.ideasonboard.com>","In-Reply-To":"<20200724214747.GG5921@pendragon.ideasonboard.com>","From":"David Plowman ","Date":"Sat, 25 Jul 2020 00:04:01 +0100","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v2 3/3] libcamera: qcam: Improve\n\tcolour information in DNG files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]