[{"id":11551,"web_url":"https://patchwork.libcamera.org/comment/11551/","msgid":"<20200724113906.GB5921@pendragon.ideasonboard.com>","date":"2020-07-24T11:39:06","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add support for 16-bit\n\tBayer formats","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Jul 24, 2020 at 10:55:50AM +0200, Niklas Söderlund wrote:\n> Add support for 16-bit Bayer formats.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/formats.cpp | 40 ++++++++++++++++++++++++++++++\n> src/libcamera/formats.yaml | 9 +++++++\n> src/libcamera/v4l2_pixelformat.cpp | 4 +++\n> 3 files changed, 53 insertions(+)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 60b42ce23c2145fd..b8bed685029f655e 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -563,6 +563,46 @@ const std::map pixelFormatInfo{\n> \t\t.pixelsPerGroup = 2,\n> \t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> \t} },\n> +\t{ formats::SBGGR16, {\n> +\t\t.name = \"SBGGR16\",\n> +\t\t.format = formats::SBGGR16,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_SBGGR16),\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 2,\n> +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n> +\t{ formats::SGBRG16, {\n> +\t\t.name = \"SGBRG16\",\n> +\t\t.format = formats::SGBRG16,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_SGBRG16),\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 2,\n> +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n> +\t{ formats::SGRBG16, {\n> +\t\t.name = \"SGRBG16\",\n> +\t\t.format = formats::SGRBG16,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_SGRBG16),\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 2,\n> +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n> +\t{ formats::SRGGB16, {\n> +\t\t.name = \"SRGGB16\",\n> +\t\t.format = formats::SRGGB16,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_SRGGB16),\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 2,\n> +\t\t.planes = {{ { 4, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n> \t{ formats::SBGGR10_IPU3, {\n> \t\t.name = \"SBGGR10_IPU3\",\n> \t\t.format = formats::SBGGR10_IPU3,\n> diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\n> index 3a69c05fcc04fb93..6a2fb721b7c649b6 100644\n> --- a/src/libcamera/formats.yaml\n> +++ b/src/libcamera/formats.yaml\n> @@ -93,6 +93,15 @@ formats:\n> - SBGGR12:\n> fourcc: DRM_FORMAT_SBGGR12\n> \n> + - SRGGB16:\n> + fourcc: DRM_FORMAT_SRGGB16\n> + - SGRBG16:\n> + fourcc: DRM_FORMAT_SGRBG16\n> + - SGBRG16:\n> + fourcc: DRM_FORMAT_SGBRG16\n> + - SBGGR16:\n> + fourcc: DRM_FORMAT_SBGGR16\n> +\n> - SRGGB10_CSI2P:\n> fourcc: DRM_FORMAT_SRGGB10\n> mod: MIPI_FORMAT_MOD_CSI2_PACKED\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index c8f69ee9654223b3..8391ec48ac1009b6 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -92,6 +92,10 @@ const std::map vpf2pf{\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG12P), formats::SGBRG12_CSI2P },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG12P), formats::SGRBG12_CSI2P },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB12P), formats::SRGGB12_CSI2P },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR16), formats::SBGGR16 },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGBRG16), formats::SGBRG16 },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SGRBG16), formats::SGRBG16 },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_SRGGB16), formats::SRGGB16 },\n> \n> \t/* Compressed formats. */\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_MJPEG), formats::MJPEG },","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E38E6BD86F\n\tfor ;\n\tFri, 24 Jul 2020 11:39:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B2AD2611AA;\n\tFri, 24 Jul 2020 13:39:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E67DC6039B\n\tfor ;\n\tFri, 24 Jul 2020 13:39:12 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7E8BE538;\n\tFri, 24 Jul 2020 13:39:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GfZbVNRn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595590752;\n\tbh=/yj6JL6txf/g/ff7hx9PCthOlpG06KPIr8oPqgwS6/s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GfZbVNRnYVw8AE3zp+enB3wkqeGw4sC7x4lUUipmqHL8JaRd4rVxWTku2ph2DUf/2\n\tbJmW+DlkdiiObzdTIwFMZNpc+KucA4euLOCmeSz6kYxKrB8fnCH6WQEglcd5hu59cU\n\tv6uocwJGKXRlnoRzCZ2VCLuuqo/l3TXQwJ7YxZp0=","Date":"Fri, 24 Jul 2020 14:39:06 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200724113906.GB5921@pendragon.ideasonboard.com>","References":"<20200724085550.496484-1-niklas.soderlund@ragnatech.se>\n\t<20200724085550.496484-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200724085550.496484-3-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add support for 16-bit\n\tBayer formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]