[{"id":11550,"web_url":"https://patchwork.libcamera.org/comment/11550/","msgid":"<20200724113839.GA5921@pendragon.ideasonboard.com>","date":"2020-07-24T11:38:39","subject":"Re: [libcamera-devel] [PATCH 1/2] include: drm_fourcc: Add 16-bit\n\tBayer FourCC","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Fri, Jul 24, 2020 at 10:55:49AM +0200, Niklas Söderlund wrote:\n> The patch trying to upstream Bayer formats to the DRM FourCC header file\n> in Linux left out the 16-bit formats, add them. This addition will be\n> included in the next version of the DRM Bayer patch sent out.\n> \n> Intention is to merge this in libcamera and update the header file once\n> the upstream patch is picked up.\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> include/linux/drm_fourcc.h | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h\n> index 69240dfe1df0df28..baa3faecdf1575c7 100644\n> --- a/include/linux/drm_fourcc.h\n> +++ b/include/linux/drm_fourcc.h\n> @@ -344,6 +344,12 @@ extern \"C\" {\n> #define DRM_FORMAT_SGBRG14\tfourcc_code('G', 'B', '1', '4')\n> #define DRM_FORMAT_SBGGR14\tfourcc_code('B', 'G', '1', '4')\n> \n> +/* 16-bit Bayer formats */\n> +#define DRM_FORMAT_SRGGB16\tfourcc_code('R', 'G', '1', '6')\n\nThis conflicts with DRM_FORMAT_RGB565.\n\n> +#define DRM_FORMAT_SGRBG16\tfourcc_code('G', 'R', '1', '6')\n> +#define DRM_FORMAT_SGBRG16\tfourcc_code('G', 'B', '1', '6')\n> +#define DRM_FORMAT_SBGGR16\tfourcc_code('B', 'Y', 'R', '2')\n> +\n> /*\n> * Format Modifiers:\n> *","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5FC2BD86F\n\tfor ;\n\tFri, 24 Jul 2020 11:38:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5344C611AA;\n\tFri, 24 Jul 2020 13:38:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F9136039B\n\tfor ;\n\tFri, 24 Jul 2020 13:38:46 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ACCC1538;\n\tFri, 24 Jul 2020 13:38:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kF0kXQq5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595590725;\n\tbh=qrVQGO1RsrZxx3TJb1ycWG0OOVdzEF0E84fyx0BsoHk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=kF0kXQq5HR2hlipuOaTfxiGevNt++FfEM9ogrC925Ys05hEHIreDXWoZ3NZ5NWlox\n\t8xXwE6zHZg37scJL91EjRbUF9OcYo9XFCx4+f4dgGSCC4ilaVz6GX47euWlsNDKDfU\n\taAmi4LS5aJ8LgBFvV2hCAMmZDkT0o75+G8NOZPPM=","Date":"Fri, 24 Jul 2020 14:38:39 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200724113839.GA5921@pendragon.ideasonboard.com>","References":"<20200724085550.496484-1-niklas.soderlund@ragnatech.se>\n\t<20200724085550.496484-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200724085550.496484-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 1/2] include: drm_fourcc: Add 16-bit\n\tBayer FourCC","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11552,"web_url":"https://patchwork.libcamera.org/comment/11552/","msgid":"<20200724115640.GA2700096@oden.dyn.berto.se>","date":"2020-07-24T11:56:40","subject":"Re: [libcamera-devel] [PATCH 1/2] include: drm_fourcc: Add 16-bit\n\tBayer FourCC","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your feedback.\n\nOn 2020-07-24 14:38:39 +0300, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> Thank you for the patch.\n> \n> On Fri, Jul 24, 2020 at 10:55:49AM +0200, Niklas Söderlund wrote:\n> > The patch trying to upstream Bayer formats to the DRM FourCC header file\n> > in Linux left out the 16-bit formats, add them. This addition will be\n> > included in the next version of the DRM Bayer patch sent out.\n> > \n> > Intention is to merge this in libcamera and update the header file once\n> > the upstream patch is picked up.\n> > \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > include/linux/drm_fourcc.h | 6 ++++++\n> > 1 file changed, 6 insertions(+)\n> > \n> > diff --git a/include/linux/drm_fourcc.h b/include/linux/drm_fourcc.h\n> > index 69240dfe1df0df28..baa3faecdf1575c7 100644\n> > --- a/include/linux/drm_fourcc.h\n> > +++ b/include/linux/drm_fourcc.h\n> > @@ -344,6 +344,12 @@ extern \"C\" {\n> > #define DRM_FORMAT_SGBRG14\tfourcc_code('G', 'B', '1', '4')\n> > #define DRM_FORMAT_SBGGR14\tfourcc_code('B', 'G', '1', '4')\n> > \n> > +/* 16-bit Bayer formats */\n> > +#define DRM_FORMAT_SRGGB16\tfourcc_code('R', 'G', '1', '6')\n> \n> This conflicts with DRM_FORMAT_RGB565.\n\nCrap, how did I miss that? I will make this\n\n#define DRM_FORMAT_SRGGB16 fourcc_code('R', 'G', 'B', '6')\n\nin v2.\n\n> \n> > +#define DRM_FORMAT_SGRBG16\tfourcc_code('G', 'R', '1', '6')\n> > +#define DRM_FORMAT_SGBRG16\tfourcc_code('G', 'B', '1', '6')\n> > +#define DRM_FORMAT_SBGGR16\tfourcc_code('B', 'Y', 'R', '2')\n> > +\n> > /*\n> > * Format Modifiers:\n> > *\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAB95BD878\n\tfor ;\n\tFri, 24 Jul 2020 11:56:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5DB8160535;\n\tFri, 24 Jul 2020 13:56:44 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E43426039B\n\tfor ;\n\tFri, 24 Jul 2020 13:56:42 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id f5so9672278ljj.10\n\tfor ;\n\tFri, 24 Jul 2020 04:56:42 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ti10sm197731ljg.80.2020.07.24.04.56.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 24 Jul 2020 04:56:41 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"W2lO/rpS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=/c35oW3YEg/QeeTTSEoCw8P6/CvQmykE7IjG73BBZYs=;\n\tb=W2lO/rpSWMse35KX8/e5RefiyFzx6G8ouzTOcBQAZiVXO/CdsTmraI90eIXirkssUT\n\tpULtLrGubQvsRQ7DWftcx9r+ZZeZ2OsWzU69PXKkGtl3urggecyMkvq1PJJXysVLRLzj\n\tdiBBT82/TBfp23x4SH0O/dH/0tCRJYO/KnZF2WaMyzA+abriWdo+ZkEJDX+ZnC6rIJRk\n\tPCYqySeVqVpRNAcy13VsiGDQRLA4BZHt6KGCkoB8EAnmNZ9GH/7ehZ3O3EvRpmBbiwIc\n\trfD8r5rh7lglp4IGb8q7bL5TA2KifL/6+J27xeueQUZ9Y9w6jc9WAOQpQn4MCB9bszxh\n\tJh3g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=/c35oW3YEg/QeeTTSEoCw8P6/CvQmykE7IjG73BBZYs=;\n\tb=XT518S5N0U6FS8nILHkqda9f4oAoLL9QoDhAGbk6TA/b4XxW+jlRHb9v31dlt/Y1qx\n\t8QJ7m9muPh9rikW7RgmeKZ5C0KG5Hx4XsEqj4cDV/Pt6JhuZRMFM5FuCz47UyWPcXm9k\n\tltU4111GsdRdIyUBfVEilnc2PdWlRUoG2hwxMlPlO7GzDc9xnaPqc7iKC/gwxGCe6ilv\n\tBOcoEcl7N/7ACy9gB7Ys8JozXdR6gcX25yUsLBOhlS1o6mPGOuwS3FK3uDgWqPEoUwsS\n\tLe/dYYIh3sEqRJZZv3xTRxVrpRm/3dF5Lz+vNboV8PM1/N1JwRh1lga2X3UqVrC5ohtL\n\t/IOQ==","X-Gm-Message-State":"AOAM530qy2334HXTiH1o5za6/mb6S+kNujSD3nJCgmFm98qH2T/kaoGx\n\t7LF8RmiHiEeX1UGHrld/i695ryVvFRw=","X-Google-Smtp-Source":"ABdhPJz/3mu7Nq5DywqhBfard81XN1rpVhLg19a0gPXCfMSQilpIx6Gtk4oKS//gPOAQm921S150TA==","X-Received":"by 2002:a2e:9b06:: with SMTP id u6mr3950227lji.24.1595591802127; \n\tFri, 24 Jul 2020 04:56:42 -0700 (PDT)","Date":"Fri, 24 Jul 2020 13:56:40 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200724115640.GA2700096@oden.dyn.berto.se>","References":"<20200724085550.496484-1-niklas.soderlund@ragnatech.se>\n\t<20200724085550.496484-2-niklas.soderlund@ragnatech.se>\n\t<20200724113839.GA5921@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200724113839.GA5921@pendragon.ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] include: drm_fourcc: Add 16-bit\n\tBayer FourCC","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]