[{"id":11544,"web_url":"https://patchwork.libcamera.org/comment/11544/","msgid":"<3aa978d2-4cc5-b99b-ccba-1197c7470e5c@ideasonboard.com>","date":"2020-07-24T09:46:56","subject":"Re: [libcamera-devel] [PATCH v5 03/10] libcamera: request: Add log\n\tpoint on a completed request","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 24/07/2020 08:22, Naushir Patuck wrote:\n> Add a debug log point to indicate a request has completed.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/request.cpp | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 6b9e0b4a..cba1715e 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -212,6 +212,9 @@ void Request::complete()\n> {\n> \tASSERT(!hasPendingBuffers());\n> \tstatus_ = cancelled_ ? RequestCancelled : RequestComplete;\n> +\n> +\tLOG(Request, Debug) << \"Request has completed - cookie: \"\n> +\t\t\t << cookie_;\n\nsorry to extend this with feature creep, but if we're reporting a\ncompletion here, and we've just calculated the status_, should we print\nthe result?\n\nOr perhaps, only print [Cancelled] if it was a cancelled ...\n\nWould this make sense, or be helpful? (untested)\n\n << cancelled_ ? \" [Cancelled]\" : \"\";\n\n\nWe could swap out the 'has completed' for 'has been cancelled', but I\nwould think it might be useful to be easy to spot cancelled requests.\n\n> }\n> \n> /**\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50B64BD86F\n\tfor ;\n\tFri, 24 Jul 2020 09:47:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A6832611AA;\n\tFri, 24 Jul 2020 11:47:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0C8C6118A\n\tfor ;\n\tFri, 24 Jul 2020 11:46:59 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BB90D538;\n\tFri, 24 Jul 2020 11:46:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GqM8wkvW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595584018;\n\tbh=sXEarWoVL3hjpbnS7ZkypqeTgjt6fn48HQ895t3nhpI=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=GqM8wkvWR4HyEqNoqYFbfAHNO4MyiM9U5crz/N5Vle7u2nMtRq0uJlqn2oIvZmmgp\n\t8wITvycXAntGRQx+UgrTpVSk1NrUhKCUW7YXar+edYPYfd0GjZTHe18sGaEBECg2oH\n\t+maE8ql3noyFwN9ZiM8CFR2mEplxiDD6BEiDK3/Q=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200724072218.943245-1-naush@raspberrypi.com>\n\t<20200724072218.943245-4-naush@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<3aa978d2-4cc5-b99b-ccba-1197c7470e5c@ideasonboard.com>","Date":"Fri, 24 Jul 2020 10:46:56 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200724072218.943245-4-naush@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v5 03/10] libcamera: request: Add log\n\tpoint on a completed request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11547,"web_url":"https://patchwork.libcamera.org/comment/11547/","msgid":"","date":"2020-07-24T10:23:54","subject":"Re: [libcamera-devel] [PATCH v5 03/10] libcamera: request: Add log\n\tpoint on a completed request","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nOn Fri, 24 Jul 2020 at 10:46, Kieran Bingham\n wrote:\n>\n> Hi Naush,\n>\n> On 24/07/2020 08:22, Naushir Patuck wrote:\n> > Add a debug log point to indicate a request has completed.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/libcamera/request.cpp | 3 +++\n> > 1 file changed, 3 insertions(+)\n> >\n> > diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> > index 6b9e0b4a..cba1715e 100644\n> > --- a/src/libcamera/request.cpp\n> > +++ b/src/libcamera/request.cpp\n> > @@ -212,6 +212,9 @@ void Request::complete()\n> > {\n> > ASSERT(!hasPendingBuffers());\n> > status_ = cancelled_ ? RequestCancelled : RequestComplete;\n> > +\n> > + LOG(Request, Debug) << \"Request has completed - cookie: \"\n> > + << cookie_;\n>\n> sorry to extend this with feature creep, but if we're reporting a\n> completion here, and we've just calculated the status_, should we print\n> the result?\n>\n> Or perhaps, only print [Cancelled] if it was a cancelled ...\n>\n> Would this make sense, or be helpful? (untested)\n>\n> << cancelled_ ? \" [Cancelled]\" : \"\";\n>\n>\n> We could swap out the 'has completed' for 'has been cancelled', but I\n> would think it might be useful to be easy to spot cancelled requests.\n>\n\nSure, that seems like a useful thing to do. New patchset incoming...\n\nRegards,\nNaush\n\n\n> > }\n> >\n> > /**\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8F89BD878\n\tfor ;\n\tFri, 24 Jul 2020 10:24:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A30860535;\n\tFri, 24 Jul 2020 12:24:13 +0200 (CEST)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 42B196039B\n\tfor ;\n\tFri, 24 Jul 2020 12:24:12 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id 140so4924291lfi.5\n\tfor ;\n\tFri, 24 Jul 2020 03:24:12 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"N2bPbQmf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=ulBziSbQ1/aH5fjJH4AmiqHbMm7guiHHRmB2DcR0Kk8=;\n\tb=N2bPbQmfarfOEPexXE4ybzpojSZqy9V31ubC7sOw6RGxycKQpVLhKJ2ZwmnGujtLzt\n\tOZ9eYPVbd0fM8x9+UH7IBd38GmgfYwts1nuzyKib7hTuL9Jz2bNWM8KsMzTrU+f9P19z\n\tSBlHejo+PG9mQsfuKcrxR4PN1w7zxVT1xIauZZwOk/ikKt5TJNKMT70AALZTFt7DBr8L\n\tH7P61Lu6lFNwF9UlJbsd2N4cp7ZR2B9NbVs8D2wXquwBM7ztlRuFEnZgspNfnj6pxkgP\n\tYsxkS6e3pXO980S/i5wBtIY2ldMjF2LJS4QAuxCp321ZLtwa8Jo6P8jWWwgPNsn/JaMY\n\tgP2Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ulBziSbQ1/aH5fjJH4AmiqHbMm7guiHHRmB2DcR0Kk8=;\n\tb=rIPg2AFtR4tuaZBxImUdhhx/SdufX+O1+oHb17l3t1cWJFI+eBaHmRIDA8oxFgQUeo\n\t15ibxnT+/N3+TdSlEEHPWos84mlCfANex6UoWsrEspzufVivEkSFX9YVQNXtrlv4EAvh\n\tG2mvKpZSo3TryZX9mGM/rKz2U2Qj9Djeppvo0nRZPvGbhkY/UEA+qCl6TIIu+lgUmicU\n\tjn8PT2Pybbag1xMgBOPahO7weazDTVwf6nhjYKvnmrj95wiJ3P7D999SOTnmjh+tdfjS\n\tWNneQQY+6TP0RXMtpa6uE0IyGd+jjAbKoibwaYJwm4QU7YJyUVG1DusZVzNOlILR9zBK\n\tr55w==","X-Gm-Message-State":"AOAM533M7/ZQqNrSsNdEK473giUQGt0HUrTjSz5/+P72Hm16NfOK2+QN\n\tNbAswf6H5vHVEabPvhDp1HvMJdDHR564QpmXH/WmjBa4bOA=","X-Google-Smtp-Source":"ABdhPJyJRSWUgrEjblStE8tKbaJVu660GiTUMJZ2msu6m5naMuUCIOr0a3/nfoT3gRFFt8U6kAikiWBTpObZqdx33kU=","X-Received":"by 2002:a19:4f5d:: with SMTP id\n\ta29mr4620404lfk.107.1595586251424; \n\tFri, 24 Jul 2020 03:24:11 -0700 (PDT)","MIME-Version":"1.0","References":"<20200724072218.943245-1-naush@raspberrypi.com>\n\t<20200724072218.943245-4-naush@raspberrypi.com>\n\t<3aa978d2-4cc5-b99b-ccba-1197c7470e5c@ideasonboard.com>","In-Reply-To":"<3aa978d2-4cc5-b99b-ccba-1197c7470e5c@ideasonboard.com>","From":"Naushir Patuck ","Date":"Fri, 24 Jul 2020 11:23:54 +0100","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH v5 03/10] libcamera: request: Add log\n\tpoint on a completed request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11548,"web_url":"https://patchwork.libcamera.org/comment/11548/","msgid":"<04111d68-0e1e-9ece-1c4e-785abcc62d59@ideasonboard.com>","date":"2020-07-24T10:28:32","subject":"Re: [libcamera-devel] [PATCH v5 03/10] libcamera: request: Add log\n\tpoint on a completed request","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 24/07/2020 11:23, Naushir Patuck wrote:\n> Hi Kieran,\n> \n> On Fri, 24 Jul 2020 at 10:46, Kieran Bingham\n> wrote:\n>>\n>> Hi Naush,\n>>\n>> On 24/07/2020 08:22, Naushir Patuck wrote:\n>>> Add a debug log point to indicate a request has completed.\n>>>\n>>> Signed-off-by: Naushir Patuck \n>>> ---\n>>> src/libcamera/request.cpp | 3 +++\n>>> 1 file changed, 3 insertions(+)\n>>>\n>>> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n>>> index 6b9e0b4a..cba1715e 100644\n>>> --- a/src/libcamera/request.cpp\n>>> +++ b/src/libcamera/request.cpp\n>>> @@ -212,6 +212,9 @@ void Request::complete()\n>>> {\n>>> ASSERT(!hasPendingBuffers());\n>>> status_ = cancelled_ ? RequestCancelled : RequestComplete;\n>>> +\n>>> + LOG(Request, Debug) << \"Request has completed - cookie: \"\n>>> + << cookie_;\n>>\n>> sorry to extend this with feature creep, but if we're reporting a\n>> completion here, and we've just calculated the status_, should we print\n>> the result?\n>>\n>> Or perhaps, only print [Cancelled] if it was a cancelled ...\n>>\n>> Would this make sense, or be helpful? (untested)\n>>\n>> << cancelled_ ? \" [Cancelled]\" : \"\";\n>>\n>>\n>> We could swap out the 'has completed' for 'has been cancelled', but I\n>> would think it might be useful to be easy to spot cancelled requests.\n>>\n> \n> Sure, that seems like a useful thing to do. New patchset incoming...\n\n\nNo need to resend this whole series yet for this, you can just repost\nthis one patch ...\n\nMark it as v5.1 or something ;-)\n\n> \n> Regards,\n> Naush\n> \n> \n>>> }\n>>>\n>>> /**\n>>>\n>>\n>> --\n>> Regards\n>> --\n>> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 576DEBD86F\n\tfor ;\n\tFri, 24 Jul 2020 10:28:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DD1E2611AA;\n\tFri, 24 Jul 2020 12:28:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC7A26039B\n\tfor ;\n\tFri, 24 Jul 2020 12:28:36 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 18B9A538;\n\tFri, 24 Jul 2020 12:28:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vxEgfrqn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595586516;\n\tbh=CY47r3HUOSwT0IBAh/SYfRcsGYIpWJNjPyVoWQ2dnCc=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=vxEgfrqndBLNETIow5vQ4xIJSxX2fjrRHp5Y/aA69OXH+Br40zz/gi/Qwqet8IwB8\n\tuTmW4cyzO9k5xvhF3LnSyZDQKw/jDE662aPn7uCFXXsCmGu+Wo8Cf4lUYI2kF9a7I6\n\tLVcDKakUVOW7d19fIlRTyF4SSD9/W1CW3vAAOjqE=","To":"Naushir Patuck ","References":"<20200724072218.943245-1-naush@raspberrypi.com>\n\t<20200724072218.943245-4-naush@raspberrypi.com>\n\t<3aa978d2-4cc5-b99b-ccba-1197c7470e5c@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<04111d68-0e1e-9ece-1c4e-785abcc62d59@ideasonboard.com>","Date":"Fri, 24 Jul 2020 11:28:32 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v5 03/10] libcamera: request: Add log\n\tpoint on a completed request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11549,"web_url":"https://patchwork.libcamera.org/comment/11549/","msgid":"<5979fb78-5e66-92a7-291a-22c45526f238@ideasonboard.com>","date":"2020-07-24T10:29:42","subject":"Re: [libcamera-devel] [PATCH v5 03/10] libcamera: request: Add log\n\tpoint on a completed request","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 24/07/2020 11:28, Kieran Bingham wrote:\n> Hi Naush,\n> \n> On 24/07/2020 11:23, Naushir Patuck wrote:\n>> Hi Kieran,\n>>\n>> On Fri, 24 Jul 2020 at 10:46, Kieran Bingham\n>> wrote:\n>>>\n>>> Hi Naush,\n>>>\n>>> On 24/07/2020 08:22, Naushir Patuck wrote:\n>>>> Add a debug log point to indicate a request has completed.\n>>>>\n>>>> Signed-off-by: Naushir Patuck \n>>>> ---\n>>>> src/libcamera/request.cpp | 3 +++\n>>>> 1 file changed, 3 insertions(+)\n>>>>\n>>>> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n>>>> index 6b9e0b4a..cba1715e 100644\n>>>> --- a/src/libcamera/request.cpp\n>>>> +++ b/src/libcamera/request.cpp\n>>>> @@ -212,6 +212,9 @@ void Request::complete()\n>>>> {\n>>>> ASSERT(!hasPendingBuffers());\n>>>> status_ = cancelled_ ? RequestCancelled : RequestComplete;\n>>>> +\n>>>> + LOG(Request, Debug) << \"Request has completed - cookie: \"\n>>>> + << cookie_;\n>>>\n>>> sorry to extend this with feature creep, but if we're reporting a\n>>> completion here, and we've just calculated the status_, should we print\n>>> the result?\n>>>\n>>> Or perhaps, only print [Cancelled] if it was a cancelled ...\n>>>\n>>> Would this make sense, or be helpful? (untested)\n>>>\n>>> << cancelled_ ? \" [Cancelled]\" : \"\";\n>>>\n>>>\n>>> We could swap out the 'has completed' for 'has been cancelled', but I\n>>> would think it might be useful to be easy to spot cancelled requests.\n>>>\n>>\n>> Sure, that seems like a useful thing to do. New patchset incoming...\n> \n> \n> No need to resend this whole series yet for this, you can just repost\n> this one patch ...\n> \n> Mark it as v5.1 or something ;-)\n\n\nOh - and you can add\n\n--in-reply-to=\"<20200724072218.943245-4-naush@raspberrypi.com>\" to\ngit-send-email to make it follow your v5 ;-)\n\n\n\n> \n>>\n>> Regards,\n>> Naush\n>>\n>>\n>>>> }\n>>>>\n>>>> /**\n>>>>\n>>>\n>>> --\n>>> Regards\n>>> --\n>>> Kieran\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A57BABD86F\n\tfor ;\n\tFri, 24 Jul 2020 10:29:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 716B7611AA;\n\tFri, 24 Jul 2020 12:29:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C6596039B\n\tfor ;\n\tFri, 24 Jul 2020 12:29:46 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AD4F1538;\n\tFri, 24 Jul 2020 12:29:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KytBBYh3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595586585;\n\tbh=Nw1LaixOgPV2JUJV//92+YG6ZC8ZEw+MpBfsMr1fuRg=;\n\th=Reply-To:Subject:From:To:Cc:References:Date:In-Reply-To:From;\n\tb=KytBBYh3VRwi4ewO4+xKiAwHO1oDrqjLB9QnxVqQJZwbKRaxCiArLzHnE++Fn8ZM5\n\trR6FPD6TWkIHR4W2AKeROFhy14Ng+5xfo3uGNEGRVGSv2psq2Jd+QrTlwQG1wjVtHA\n\t9ntAQcHxahX94quKxA4kz5ONzPV+sjAe0SKPPo9s=","From":"Kieran Bingham ","To":"Naushir Patuck ","References":"<20200724072218.943245-1-naush@raspberrypi.com>\n\t<20200724072218.943245-4-naush@raspberrypi.com>\n\t<3aa978d2-4cc5-b99b-ccba-1197c7470e5c@ideasonboard.com>\n\t\n\t<04111d68-0e1e-9ece-1c4e-785abcc62d59@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<5979fb78-5e66-92a7-291a-22c45526f238@ideasonboard.com>","Date":"Fri, 24 Jul 2020 11:29:42 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<04111d68-0e1e-9ece-1c4e-785abcc62d59@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v5 03/10] libcamera: request: Add log\n\tpoint on a completed request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]