[{"id":11533,"web_url":"https://patchwork.libcamera.org/comment/11533/","msgid":"<20200724071704.GA2420270@oden.dyn.berto.se>","date":"2020-07-24T07:17:04","subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Remove\n\tunnecessary explicit constructor calls","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-07-24 02:38:52 +0300, Laurent Pinchart wrote:\n> When initializing the PixelFormatInfo::format field with a PixelFormat,\n> there's no need to cal the PixelFormat (copy) constructor explicitly.\n> Remove the unnecessary calls.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/formats.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 60b42ce23c21..11774b0cfb12 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -321,7 +321,7 @@ const std::map pixelFormatInfo{\n> \t} },\n> \t{ formats::YUV420, {\n> \t\t.name = \"YUV420\",\n> -\t\t.format = PixelFormat(formats::YUV420),\n> +\t\t.format = formats::YUV420,\n> \t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YUV420),\n> \t\t.bitsPerPixel = 12,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> @@ -331,7 +331,7 @@ const std::map pixelFormatInfo{\n> \t} },\n> \t{ formats::YVU420, {\n> \t\t.name = \"YVU420\",\n> -\t\t.format = PixelFormat(formats::YVU420),\n> +\t\t.format = formats::YVU420,\n> \t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YVU420),\n> \t\t.bitsPerPixel = 12,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> @@ -341,7 +341,7 @@ const std::map pixelFormatInfo{\n> \t} },\n> \t{ formats::YUV422, {\n> \t\t.name = \"YUV422\",\n> -\t\t.format = PixelFormat(formats::YUV422),\n> +\t\t.format = formats::YUV422,\n> \t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YUV422P),\n> \t\t.bitsPerPixel = 16,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98AADBD878\n\tfor ;\n\tFri, 24 Jul 2020 07:17:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D8C361167;\n\tFri, 24 Jul 2020 09:17:08 +0200 (CEST)","from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B15460923\n\tfor ;\n\tFri, 24 Jul 2020 09:17:06 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id u12so4665716lff.2\n\tfor ;\n\tFri, 24 Jul 2020 00:17:06 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id f14sm27697lfd.2.2020.07.24.00.17.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 24 Jul 2020 00:17:04 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"OGk/ypoB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=tRYX9TIFl04+uEyfGmTPUp0sBckhjFp/zQon2TsE1So=;\n\tb=OGk/ypoBYXSKT6SqAPYV++Nt+6X7LjFDCOwWULDbPS/tad5OE4jRrcXnXq+Dky9jgz\n\teNPASF/xciZ+QLHzj2WcBDnuN+S1hCzkCvsMpKu+MUmjwqjqrr9+5FsjKtLgvRlBt/JT\n\tiDhErLj7rCTqntS3OLAakpqoIyNEwP5MFLLeQkoZngDW3349D00N/WS820bg+xgRTehs\n\t1jJrM1/sV1Kmc8z9SAIWSKkv7TTa7bEsAu4tqPnqWeGeuliCcab/eb48ohWkE3Uo2f+Y\n\tAbyn/oDCc+F8l4sVTR614O7SvJsdsneVnwjir/NHmw4v6q18BK3hxik/6MbNwWdkBp7X\n\tKIrw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=tRYX9TIFl04+uEyfGmTPUp0sBckhjFp/zQon2TsE1So=;\n\tb=iSwZm3PdQpdawKEL1HBF4OtitTTJ9wPHPoDIdktTobtUdFBBv+rKgglgHhihmffush\n\t9OZdS1jqhzvW25h6bCejm41j78i1tTheCSQXyAQWw/mjb8okjeAMccfqr+ydWI8SAuJB\n\tCQdsPIqj3TgUbUb+M2xycU5pX+VW2I4tHZHgrg2/nwgFgF8xKF4/dgRv39IKwu/UCjnw\n\tOVDGrSG+CfpuFZTLWAOSGOTdPQqygaNVFhHT/bg7WzZ1FAcdYXEasEgtoAHcEvn9vSHj\n\t1MOZNyFekfw6rPMt2ky4+pFeOjwiXsjG39hCQILDBJ+KuyYe0F3YD/c81i+DoDVr+CnC\n\tQlug==","X-Gm-Message-State":"AOAM532jNtJ9MtSzEDVMQoCMRc6dnfg8gzLstif2HI3k1OJnQUQbVXOV\n\t/pajJhI1A+mNMAtaj3mIAEpJpsjuEXo=","X-Google-Smtp-Source":"ABdhPJw9/w7y9WuR/yTZHF2yetVkaL35Difu72UgqHC5rQdm/zu7Ql4pFuz463mVeAzx/pVCixNXlg==","X-Received":"by 2002:ac2:5f64:: with SMTP id c4mr4464199lfc.170.1595575025508;\n\tFri, 24 Jul 2020 00:17:05 -0700 (PDT)","Date":"Fri, 24 Jul 2020 09:17:04 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200724071704.GA2420270@oden.dyn.berto.se>","References":"<20200723233852.17415-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200723233852.17415-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Remove\n\tunnecessary explicit constructor calls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11543,"web_url":"https://patchwork.libcamera.org/comment/11543/","msgid":"<197f3fdd-69e5-dcf5-4f2c-8b23f4b2af66@ideasonboard.com>","date":"2020-07-24T09:41:39","subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Remove\n\tunnecessary explicit constructor calls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 24/07/2020 00:38, Laurent Pinchart wrote:\n> When initializing the PixelFormatInfo::format field with a PixelFormat,\n> there's no need to cal the PixelFormat (copy) constructor explicitly.\n\ns/cal/call/\n\n> Remove the unnecessary calls.\n> \n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/formats.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 60b42ce23c21..11774b0cfb12 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -321,7 +321,7 @@ const std::map pixelFormatInfo{\n> \t} },\n> \t{ formats::YUV420, {\n> \t\t.name = \"YUV420\",\n> -\t\t.format = PixelFormat(formats::YUV420),\n> +\t\t.format = formats::YUV420,\n> \t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YUV420),\n> \t\t.bitsPerPixel = 12,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> @@ -331,7 +331,7 @@ const std::map pixelFormatInfo{\n> \t} },\n> \t{ formats::YVU420, {\n> \t\t.name = \"YVU420\",\n> -\t\t.format = PixelFormat(formats::YVU420),\n> +\t\t.format = formats::YVU420,\n> \t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YVU420),\n> \t\t.bitsPerPixel = 12,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> @@ -341,7 +341,7 @@ const std::map pixelFormatInfo{\n> \t} },\n> \t{ formats::YUV422, {\n> \t\t.name = \"YUV422\",\n> -\t\t.format = PixelFormat(formats::YUV422),\n> +\t\t.format = formats::YUV422,\n> \t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YUV422P),\n> \t\t.bitsPerPixel = 16,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 311E6BD878\n\tfor ;\n\tFri, 24 Jul 2020 09:41:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B7DB611AA;\n\tFri, 24 Jul 2020 11:41:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C0586118A\n\tfor ;\n\tFri, 24 Jul 2020 11:41:43 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 76F80538;\n\tFri, 24 Jul 2020 11:41:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RbzJo2D1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595583702;\n\tbh=q1IsB+4bKWfsfiRlkj+ymzF7GGT+5tWoOaMY6eVWXbg=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=RbzJo2D1p07sZxeJ5l45Mr6bVBBYFnDwI6kXRZdrO/Pin7KgDUWPr260EhccOUuMV\n\typmsEGy7JtmfCqtoIbd4JRPWdEEbXNqR0UD15LhzE2terAfQqm71CTUDfQm3Cy9B4b\n\tb3XtJlxWl61fJYyhXHAN9wEOYjV+RA0MUWsKoppw=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200723233852.17415-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<197f3fdd-69e5-dcf5-4f2c-8b23f4b2af66@ideasonboard.com>","Date":"Fri, 24 Jul 2020 10:41:39 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200723233852.17415-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Remove\n\tunnecessary explicit constructor calls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]