[{"id":11538,"web_url":"https://patchwork.libcamera.org/comment/11538/","msgid":"<20200724084609.o63eqc76ikzikvir@uno.localdomain>","date":"2020-07-24T08:46:09","subject":"Re: [libcamera-devel] [PATCH 4/4] android: camera_device: Add\n\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Thu, Jul 23, 2020 at 07:39:42PM +0200, Niklas Söderlund wrote:\n> Define the ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS to zero to inform users\n> the HAL does not support any reprocessing.\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/android/camera_device.cpp | 10 ++++++++--\n> 1 file changed, 8 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index d9fdaf44b2803399..0e9fc216d2b54a1a 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -370,8 +370,8 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t * \\todo Keep this in sync with the actual number of entries.\n> \t * Currently: 50 entries, 647 bytes of static metadata\n> \t */\n> -\tuint32_t numEntries = 49;\n> -\tuint32_t byteSize = 647;\n> +\tuint32_t numEntries = 50;\n> +\tuint32_t byteSize = 648;\n\nAccording to the above comment, this should be 651 (647 + 4)\n>\n> \t/*\n> \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -699,6 +699,11 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> \t\t\t\t &maxPipelineDepth, 1);\n>\n> +\t/* LIMITED does not support reprocessing. */\n> +\tuint8_t maxNumInputStreams = 0;\n\nI see this being of type int32_t\n\nBefore leaving a tag, can I ask what use cases requires this ? It's a\ntag required for FULL level, which we don't claim to support at the\nmoment.\n\nThanks\n j\n\n> +\tstaticMetadata_->addEntry(ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> +\t\t\t\t &maxNumInputStreams, 1);\n> +\n> \tstd::vector availableCapabilities = {\n> \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE,\n> \t};\n> @@ -752,6 +757,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n> \t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> \t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> +\t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CHARACTERISTICS_KEYS,\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 491CBBD878\n\tfor ;\n\tFri, 24 Jul 2020 08:42:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BFFFE611AA;\n\tFri, 24 Jul 2020 10:42:33 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BBF26118A\n\tfor ;\n\tFri, 24 Jul 2020 10:42:32 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id BD7CC1BF20D;\n\tFri, 24 Jul 2020 08:42:31 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 24 Jul 2020 10:46:09 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200724084609.o63eqc76ikzikvir@uno.localdomain>","References":"<20200723173942.98182-1-niklas.soderlund@ragnatech.se>\n\t<20200723173942.98182-5-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200723173942.98182-5-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 4/4] android: camera_device: Add\n\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11540,"web_url":"https://patchwork.libcamera.org/comment/11540/","msgid":"<20200724084540.GC2420270@oden.dyn.berto.se>","date":"2020-07-24T08:45:40","subject":"Re: [libcamera-devel] [PATCH 4/4] android: camera_device: Add\n\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-07-24 10:46:09 +0200, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Thu, Jul 23, 2020 at 07:39:42PM +0200, Niklas Söderlund wrote:\n> > Define the ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS to zero to inform users\n> > the HAL does not support any reprocessing.\n> >\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/android/camera_device.cpp | 10 ++++++++--\n> > 1 file changed, 8 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index d9fdaf44b2803399..0e9fc216d2b54a1a 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -370,8 +370,8 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> > \t * \\todo Keep this in sync with the actual number of entries.\n> > \t * Currently: 50 entries, 647 bytes of static metadata\n> > \t */\n> > -\tuint32_t numEntries = 49;\n> > -\tuint32_t byteSize = 647;\n> > +\tuint32_t numEntries = 50;\n> > +\tuint32_t byteSize = 648;\n> \n> According to the above comment, this should be 651 (647 + 4)\n\nThanks for spotting this, will fix in next version.\n\n\n> >\n> > \t/*\n> > \t * Calculate space occupation in bytes for dynamically built metadata\n> > @@ -699,6 +699,11 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> > \tstaticMetadata_->addEntry(ANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> > \t\t\t\t &maxPipelineDepth, 1);\n> >\n> > +\t/* LIMITED does not support reprocessing. */\n> > +\tuint8_t maxNumInputStreams = 0;\n> \n> I see this being of type int32_t\n> \n> Before leaving a tag, can I ask what use cases requires this ? It's a\n> tag required for FULL level, which we don't claim to support at the\n> moment.\n\nWithout this tag Open Camera crashes and since I use that to verify RAW \nI thought I upstream it. As we set it to 0 I don't think it do any harm?\n\n> \n> Thanks\n> j\n> \n> > +\tstaticMetadata_->addEntry(ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> > +\t\t\t\t &maxNumInputStreams, 1);\n> > +\n> > \tstd::vector availableCapabilities = {\n> > \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE,\n> > \t};\n> > @@ -752,6 +757,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> > \t\tANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n> > \t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> > \t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> > +\t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> > \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> > \t};\n> > \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CHARACTERISTICS_KEYS,\n> > --\n> > 2.27.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50F42BD878\n\tfor ;\n\tFri, 24 Jul 2020 08:45:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E780611AA;\n\tFri, 24 Jul 2020 10:45:44 +0200 (CEST)","from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D8186118A\n\tfor ;\n\tFri, 24 Jul 2020 10:45:42 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id y18so4765522lfh.11\n\tfor ;\n\tFri, 24 Jul 2020 01:45:42 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ty24sm91745ljy.91.2020.07.24.01.45.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 24 Jul 2020 01:45:41 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"ChLYVPgp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=vs8EidahRyD2YnZPH+164ss/YduiHZeqQoHt3NoYKcI=;\n\tb=ChLYVPgpvE+PbKO3aLxP4vDY2R2s0KJlbNXD7HJpDjqzfi/RFVgIWGogsyPXGj982H\n\tYZzLH3W3NkazlWX6IFz7WU1NmhmhbMwxl8f9UZ7YgcsxOBSF9qGts8GzXEhfR09ZbunW\n\t2zjVHfXmx0wDxDrIri0A8l0NdcIkHGP93nrz00YtEe188pVGeWc1RJXcXBIUKiyt4veI\n\tokOS051zGyKwSoKOdbyv4DU/mPf1RxQi6VT9K+yHr2uC/wyj3gPHavdPkKQX4SZVj1C1\n\tJBgNDDDF/iQm3fTvUcfTAPE0qt5yxkfw7uDcIFpGK8HfD+KUC5Usrf+jhn5Dv+Pwp1vF\n\t7Mlw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=vs8EidahRyD2YnZPH+164ss/YduiHZeqQoHt3NoYKcI=;\n\tb=hD2csVloBqDKr9SYfYenDWomOU6fllOVsWdolGOTNsFHuWLnVLlCOyTdnu4RSJwrwK\n\tsJkBH8qgaj6WxNOgCK04VtLKJVJUfioKcBk6LDfx8X2Ndv7kDpWw2YlQFK3H1eRqBZ/B\n\t4y/NVK926KGaLqG3WaBplNVKUyi4kvzBWMqvacoVF4g1frXFHG1TZH49JImJ0CL36caK\n\t7/TKIDzPyAQZzTNRP4wILRQH6wk3ze9ZTKyUKZwtdhSdmNXNHnTSYWBlIsTL85iVO4yF\n\t80OkmNDBHEIY0twlKrA+brEk76G8nbBtgMhjV7NtFvWJ++ClUWjtCOpHq4ObUkplK/Wm\n\tTz7Q==","X-Gm-Message-State":"AOAM531vkdEcf3oAjVNVO0JeHQFHUXaTSFUaN5xD/MQetgQls4OKi1sX\n\t2RNEn2ZBdUQUS92M5cwgWNgM+3fMJ8k=","X-Google-Smtp-Source":"ABdhPJwRnposWNQwqVVYRnuoauF9rcyJNGe3jQb4QuISRxBfWHomdx2HfEBoMpN5sRpnmxWU3+9SIg==","X-Received":"by 2002:ac2:4158:: with SMTP id\n\tc24mr4475894lfi.109.1595580341799; \n\tFri, 24 Jul 2020 01:45:41 -0700 (PDT)","Date":"Fri, 24 Jul 2020 10:45:40 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200724084540.GC2420270@oden.dyn.berto.se>","References":"<20200723173942.98182-1-niklas.soderlund@ragnatech.se>\n\t<20200723173942.98182-5-niklas.soderlund@ragnatech.se>\n\t<20200724084609.o63eqc76ikzikvir@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200724084609.o63eqc76ikzikvir@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 4/4] android: camera_device: Add\n\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11541,"web_url":"https://patchwork.libcamera.org/comment/11541/","msgid":"<20200724085732.sc2xqpvh6ycuz66o@uno.localdomain>","date":"2020-07-24T08:57:32","subject":"Re: [libcamera-devel] [PATCH 4/4] android: camera_device: Add\n\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"On Fri, Jul 24, 2020 at 10:45:40AM +0200, Niklas Söderlund wrote:\n> Hi Jacopo,\n>\n> Thanks for your work.\n>\n> On 2020-07-24 10:46:09 +0200, Jacopo Mondi wrote:\n> > Hi Niklas,\n> >\n> > On Thu, Jul 23, 2020 at 07:39:42PM +0200, Niklas Söderlund wrote:\n> > > Define the ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS to zero to inform users\n> > > the HAL does not support any reprocessing.\n> > >\n> > > Signed-off-by: Niklas Söderlund \n> > > ---\n> > > src/android/camera_device.cpp | 10 ++++++++--\n> > > 1 file changed, 8 insertions(+), 2 deletions(-)\n> > >\n> > > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > > index d9fdaf44b2803399..0e9fc216d2b54a1a 100644\n> > > --- a/src/android/camera_device.cpp\n> > > +++ b/src/android/camera_device.cpp\n> > > @@ -370,8 +370,8 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> > > \t * \\todo Keep this in sync with the actual number of entries.\n> > > \t * Currently: 50 entries, 647 bytes of static metadata\n> > > \t */\n> > > -\tuint32_t numEntries = 49;\n> > > -\tuint32_t byteSize = 647;\n> > > +\tuint32_t numEntries = 50;\n> > > +\tuint32_t byteSize = 648;\n> >\n> > According to the above comment, this should be 651 (647 + 4)\n>\n> Thanks for spotting this, will fix in next version.\n>\n>\n> > >\n> > > \t/*\n> > > \t * Calculate space occupation in bytes for dynamically built metadata\n> > > @@ -699,6 +699,11 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> > > \tstaticMetadata_->addEntry(ANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> > > \t\t\t\t &maxPipelineDepth, 1);\n> > >\n> > > +\t/* LIMITED does not support reprocessing. */\n> > > +\tuint8_t maxNumInputStreams = 0;\n> >\n> > I see this being of type int32_t\n> >\n> > Before leaving a tag, can I ask what use cases requires this ? It's a\n> > tag required for FULL level, which we don't claim to support at the\n> > moment.\n>\n> Without this tag Open Camera crashes and since I use that to verify RAW\n> I thought I upstream it. As we set it to 0 I don't think it do any harm?\n>\n\nAbsolutely, just wanted to know what requires this to be present.\n\nPlease add my\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> >\n> > Thanks\n> > j\n> >\n> > > +\tstaticMetadata_->addEntry(ANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> > > +\t\t\t\t &maxNumInputStreams, 1);\n> > > +\n> > > \tstd::vector availableCapabilities = {\n> > > \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE,\n> > > \t};\n> > > @@ -752,6 +757,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> > > \t\tANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n> > > \t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> > > \t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> > > +\t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> > > \t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> > > \t};\n> > > \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CHARACTERISTICS_KEYS,\n> > > --\n> > > 2.27.0\n> > >\n> > > _______________________________________________\n> > > libcamera-devel mailing list\n> > > libcamera-devel@lists.libcamera.org\n> > > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AFD6CBD86F\n\tfor ;\n\tFri, 24 Jul 2020 08:53:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32028611AA;\n\tFri, 24 Jul 2020 10:53:57 +0200 (CEST)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4C596118A\n\tfor ;\n\tFri, 24 Jul 2020 10:53:55 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id D53C0E0004;\n\tFri, 24 Jul 2020 08:53:54 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 24 Jul 2020 10:57:32 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200724085732.sc2xqpvh6ycuz66o@uno.localdomain>","References":"<20200723173942.98182-1-niklas.soderlund@ragnatech.se>\n\t<20200723173942.98182-5-niklas.soderlund@ragnatech.se>\n\t<20200724084609.o63eqc76ikzikvir@uno.localdomain>\n\t<20200724084540.GC2420270@oden.dyn.berto.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200724084540.GC2420270@oden.dyn.berto.se>","Subject":"Re: [libcamera-devel] [PATCH 4/4] android: camera_device: Add\n\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]