[{"id":11535,"web_url":"https://patchwork.libcamera.org/comment/11535/","msgid":"<20200724083457.n3idnnufybxl2oou@uno.localdomain>","date":"2020-07-24T08:34:57","subject":"Re: [libcamera-devel] [PATCH 2/4] android: camera_device: Use\n\tHAL_PIXEL_FORMAT_* defines for formats","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Thu, Jul 23, 2020 at 07:39:40PM +0200, Niklas Söderlund wrote:\n> The documentation says the HAL_PIXEL_FORMAT_* defines shall be used for\n> formats instead of ANDROID_SCALER_AVAILABLE_FORMATS_* for the\n> ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS and\n> ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS tags.\n>\n> This have worked in the past as the numerical value of the two sets are\n> the same for the formats supported.\n\nI don't find any mention of this in the documentation, but as the\nnumerical values are the same (very nice Android, yes...) if this\nallow removing the scaler formats, I think that's ok\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/android/camera_device.cpp | 8 ++++----\n> src/android/camera_device.h | 2 +-\n> 2 files changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 6e7673583f6a8f85..96dd8d5a99082966 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -317,14 +317,14 @@ int CameraDevice::initializeStreamConfigurations()\n> \t\t\t status != CameraConfiguration::Valid)\n> \t\t\t\tcontinue;\n>\n> -\t\t\tstreamConfigurations_.push_back({ res, camera3Format.scalerFormat });\n> +\t\t\tstreamConfigurations_.push_back({ res, androidFormat });\n> \t\t}\n> \t}\n>\n> \tLOG(HAL, Debug) << \"Collected stream configuration map: \";\n> \tfor (const auto &entry : streamConfigurations_)\n> \t\tLOG(HAL, Debug) << \"{ \" << entry.resolution.toString() << \" - \"\n> -\t\t\t\t<< utils::hex(entry.androidScalerCode) << \" }\";\n> +\t\t\t\t<< utils::hex(entry.androidFormat) << \" }\";\n>\n> \treturn 0;\n> }\n> @@ -658,7 +658,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstd::vector availableStreamConfigurations;\n> \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n> \tfor (const auto &entry : streamConfigurations_) {\n> -\t\tavailableStreamConfigurations.push_back(entry.androidScalerCode);\n> +\t\tavailableStreamConfigurations.push_back(entry.androidFormat);\n> \t\tavailableStreamConfigurations.push_back(entry.resolution.width);\n> \t\tavailableStreamConfigurations.push_back(entry.resolution.height);\n> \t\tavailableStreamConfigurations.push_back(\n> @@ -679,7 +679,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstd::vector minFrameDurations;\n> \tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n> \tfor (const auto &entry : streamConfigurations_) {\n> -\t\tminFrameDurations.push_back(entry.androidScalerCode);\n> +\t\tminFrameDurations.push_back(entry.androidFormat);\n> \t\tminFrameDurations.push_back(entry.resolution.width);\n> \t\tminFrameDurations.push_back(entry.resolution.height);\n> \t\tminFrameDurations.push_back(33333333);\n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index 5b8b9c3e26e2871e..00472c21938871a1 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -75,7 +75,7 @@ private:\n>\n> \tstruct Camera3StreamConfiguration {\n> \t\tlibcamera::Size resolution;\n> -\t\tint androidScalerCode;\n> +\t\tint androidFormat;\n> \t};\n>\n> \tint initializeStreamConfigurations();\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE8C8BD878\n\tfor ;\n\tFri, 24 Jul 2020 08:31:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 504DA611AA;\n\tFri, 24 Jul 2020 10:31:21 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3D0896118A\n\tfor ;\n\tFri, 24 Jul 2020 10:31:20 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 8965A20005;\n\tFri, 24 Jul 2020 08:31:19 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 24 Jul 2020 10:34:57 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200724083457.n3idnnufybxl2oou@uno.localdomain>","References":"<20200723173942.98182-1-niklas.soderlund@ragnatech.se>\n\t<20200723173942.98182-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200723173942.98182-3-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 2/4] android: camera_device: Use\n\tHAL_PIXEL_FORMAT_* defines for formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11537,"web_url":"https://patchwork.libcamera.org/comment/11537/","msgid":"<20200724084323.gplnummuhziesbh3@uno.localdomain>","date":"2020-07-24T08:43:23","subject":"Re: [libcamera-devel] [PATCH 2/4] android: camera_device: Use\n\tHAL_PIXEL_FORMAT_* defines for formats","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Thu, Jul 23, 2020 at 07:39:40PM +0200, Niklas Söderlund wrote:\n> The documentation says the HAL_PIXEL_FORMAT_* defines shall be used for\n> formats instead of ANDROID_SCALER_AVAILABLE_FORMATS_* for the\n> ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS and\n> ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS tags.\n>\n> This have worked in the past as the numerical value of the two sets are\n> the same for the formats supported.\n\nI wonder if in the future we would need scaler formats for other\nproperties, but as the numerical values are the same, we could use the\nHAL_PIXEL_FORMAT_* definitions.\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/android/camera_device.cpp | 8 ++++----\n> src/android/camera_device.h | 2 +-\n> 2 files changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 6e7673583f6a8f85..96dd8d5a99082966 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -317,14 +317,14 @@ int CameraDevice::initializeStreamConfigurations()\n> \t\t\t status != CameraConfiguration::Valid)\n> \t\t\t\tcontinue;\n>\n> -\t\t\tstreamConfigurations_.push_back({ res, camera3Format.scalerFormat });\n> +\t\t\tstreamConfigurations_.push_back({ res, androidFormat });\n> \t\t}\n> \t}\n>\n> \tLOG(HAL, Debug) << \"Collected stream configuration map: \";\n> \tfor (const auto &entry : streamConfigurations_)\n> \t\tLOG(HAL, Debug) << \"{ \" << entry.resolution.toString() << \" - \"\n> -\t\t\t\t<< utils::hex(entry.androidScalerCode) << \" }\";\n> +\t\t\t\t<< utils::hex(entry.androidFormat) << \" }\";\n>\n> \treturn 0;\n> }\n> @@ -658,7 +658,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstd::vector availableStreamConfigurations;\n> \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n> \tfor (const auto &entry : streamConfigurations_) {\n> -\t\tavailableStreamConfigurations.push_back(entry.androidScalerCode);\n> +\t\tavailableStreamConfigurations.push_back(entry.androidFormat);\n> \t\tavailableStreamConfigurations.push_back(entry.resolution.width);\n> \t\tavailableStreamConfigurations.push_back(entry.resolution.height);\n> \t\tavailableStreamConfigurations.push_back(\n> @@ -679,7 +679,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstd::vector minFrameDurations;\n> \tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n> \tfor (const auto &entry : streamConfigurations_) {\n> -\t\tminFrameDurations.push_back(entry.androidScalerCode);\n> +\t\tminFrameDurations.push_back(entry.androidFormat);\n> \t\tminFrameDurations.push_back(entry.resolution.width);\n> \t\tminFrameDurations.push_back(entry.resolution.height);\n> \t\tminFrameDurations.push_back(33333333);\n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index 5b8b9c3e26e2871e..00472c21938871a1 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -75,7 +75,7 @@ private:\n>\n> \tstruct Camera3StreamConfiguration {\n> \t\tlibcamera::Size resolution;\n> -\t\tint androidScalerCode;\n> +\t\tint androidFormat;\n> \t};\n>\n> \tint initializeStreamConfigurations();\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFB87BD86F\n\tfor ;\n\tFri, 24 Jul 2020 08:39:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7127C6118F;\n\tFri, 24 Jul 2020 10:39:47 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 35AFE6118A\n\tfor ;\n\tFri, 24 Jul 2020 10:39:46 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id F20FF240010;\n\tFri, 24 Jul 2020 08:39:44 +0000 (UTC)"],"Date":"Fri, 24 Jul 2020 10:43:23 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200724084323.gplnummuhziesbh3@uno.localdomain>","References":"<20200723173942.98182-1-niklas.soderlund@ragnatech.se>\n\t<20200723173942.98182-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200723173942.98182-3-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 2/4] android: camera_device: Use\n\tHAL_PIXEL_FORMAT_* defines for formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11539,"web_url":"https://patchwork.libcamera.org/comment/11539/","msgid":"<20200724084423.GB2420270@oden.dyn.berto.se>","date":"2020-07-24T08:44:23","subject":"Re: [libcamera-devel] [PATCH 2/4] android: camera_device: Use\n\tHAL_PIXEL_FORMAT_* defines for formats","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your feedback.\n\nOn 2020-07-24 10:43:23 +0200, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Thu, Jul 23, 2020 at 07:39:40PM +0200, Niklas Söderlund wrote:\n> > The documentation says the HAL_PIXEL_FORMAT_* defines shall be used for\n> > formats instead of ANDROID_SCALER_AVAILABLE_FORMATS_* for the\n> > ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS and\n> > ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS tags.\n> >\n> > This have worked in the past as the numerical value of the two sets are\n> > the same for the formats supported.\n> \n> I wonder if in the future we would need scaler formats for other\n> properties, but as the numerical values are the same, we could use the\n> HAL_PIXEL_FORMAT_* definitions.\n> \n> Reviewed-by: Jacopo Mondi \n\nWas this comment and tag indented for 3/4 ?\n\n> \n> Thanks\n> j\n> \n> >\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/android/camera_device.cpp | 8 ++++----\n> > src/android/camera_device.h | 2 +-\n> > 2 files changed, 5 insertions(+), 5 deletions(-)\n> >\n> > diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> > index 6e7673583f6a8f85..96dd8d5a99082966 100644\n> > --- a/src/android/camera_device.cpp\n> > +++ b/src/android/camera_device.cpp\n> > @@ -317,14 +317,14 @@ int CameraDevice::initializeStreamConfigurations()\n> > \t\t\t status != CameraConfiguration::Valid)\n> > \t\t\t\tcontinue;\n> >\n> > -\t\t\tstreamConfigurations_.push_back({ res, camera3Format.scalerFormat });\n> > +\t\t\tstreamConfigurations_.push_back({ res, androidFormat });\n> > \t\t}\n> > \t}\n> >\n> > \tLOG(HAL, Debug) << \"Collected stream configuration map: \";\n> > \tfor (const auto &entry : streamConfigurations_)\n> > \t\tLOG(HAL, Debug) << \"{ \" << entry.resolution.toString() << \" - \"\n> > -\t\t\t\t<< utils::hex(entry.androidScalerCode) << \" }\";\n> > +\t\t\t\t<< utils::hex(entry.androidFormat) << \" }\";\n> >\n> > \treturn 0;\n> > }\n> > @@ -658,7 +658,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> > \tstd::vector availableStreamConfigurations;\n> > \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n> > \tfor (const auto &entry : streamConfigurations_) {\n> > -\t\tavailableStreamConfigurations.push_back(entry.androidScalerCode);\n> > +\t\tavailableStreamConfigurations.push_back(entry.androidFormat);\n> > \t\tavailableStreamConfigurations.push_back(entry.resolution.width);\n> > \t\tavailableStreamConfigurations.push_back(entry.resolution.height);\n> > \t\tavailableStreamConfigurations.push_back(\n> > @@ -679,7 +679,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> > \tstd::vector minFrameDurations;\n> > \tminFrameDurations.reserve(streamConfigurations_.size() * 4);\n> > \tfor (const auto &entry : streamConfigurations_) {\n> > -\t\tminFrameDurations.push_back(entry.androidScalerCode);\n> > +\t\tminFrameDurations.push_back(entry.androidFormat);\n> > \t\tminFrameDurations.push_back(entry.resolution.width);\n> > \t\tminFrameDurations.push_back(entry.resolution.height);\n> > \t\tminFrameDurations.push_back(33333333);\n> > diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> > index 5b8b9c3e26e2871e..00472c21938871a1 100644\n> > --- a/src/android/camera_device.h\n> > +++ b/src/android/camera_device.h\n> > @@ -75,7 +75,7 @@ private:\n> >\n> > \tstruct Camera3StreamConfiguration {\n> > \t\tlibcamera::Size resolution;\n> > -\t\tint androidScalerCode;\n> > +\t\tint androidFormat;\n> > \t};\n> >\n> > \tint initializeStreamConfigurations();\n> > --\n> > 2.27.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8B62BD878\n\tfor ;\n\tFri, 24 Jul 2020 08:44:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 52454611AA;\n\tFri, 24 Jul 2020 10:44:27 +0200 (CEST)","from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B44FE6118A\n\tfor ;\n\tFri, 24 Jul 2020 10:44:25 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id b30so4770332lfj.12\n\tfor ;\n\tFri, 24 Jul 2020 01:44:25 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ty136sm79869lfa.79.2020.07.24.01.44.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 24 Jul 2020 01:44:24 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"zqxeb3OS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=gIL+FedgNtoBg00L6ELyYbkjxRbfHoxLY+qIj6zWU4U=;\n\tb=zqxeb3OSGJuePyn8+KQFa211GcproSEKgCv/eNa0wbrdzzBrt4iDZHqMW33qYN5Rw/\n\t0l86qk2SDa+N6dhJ9X7ocHtnrfwz5749wq6auUgGPfbS+aFj3MK3cXWxsowwZLTS7Z7L\n\tA22sN+XgF9ddCCOk3l04NEmiF1S4wuVmysDyFnplg90y/NXfZAbnOp5zxGUHqbZkK4Hn\n\te/Y11V2JDX1UZ6T1stVdKwYCee5nqPSfflH5vuYMovsYGlSL7fnWFCiVoNLgQoxkTQl0\n\tgCJbjEyC22ZXS8KUPIOMqeQOXXNNqbDUl93KsW7Ze2DiepQJG9H+7bhhqA6hEOJMaQ0c\n\tdy/g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=gIL+FedgNtoBg00L6ELyYbkjxRbfHoxLY+qIj6zWU4U=;\n\tb=q4Wny5eq5pAG72n2JOq3awivYI98yv4bhO4kEXy2e034oM3rpdZQXn0wV8wWw5I1/j\n\t0sGa6iInv+2Ji64G6V3gW3/mSlv8M9NWu2+xJCOApRXKRrd2D5B3Dzep3zJ3x/Z5Uro3\n\ti9/71lin/5hWfdqlHDa5RonMQTID/SILsCHVEtc0GyTVKauN0z8Ca9+YVA3S4wu2lgQH\n\tf+muepIx0yCCqw/MPszvUPyhhgeueYKsa5mGZzFiZ0d4mf+xfYgD2PUK8xaoRDws7Y4Z\n\tWGD5emx4z1OeRRVvMdRHQ0e+8mG/Urg3M/MaHFzv5itRXRVYdOB5YzbTVUjHewsHr4TG\n\tDWSQ==","X-Gm-Message-State":"AOAM530AOlvAVzmkoTKSFrIhLgG7XL4KV+UMrqy7kk0KgG/0TmyEA6Ux\n\tCeVcpr4znmpbicVtB8Vi3vEJqxD0eEI=","X-Google-Smtp-Source":"ABdhPJyLJzB9SViXkqWwWfK2aitz6oudpfpeLFG7SPDipNNRiAY7uj1pgr3yk6PHbZ609WKxDdN9aw==","X-Received":"by 2002:a19:8c07:: with SMTP id o7mr4468812lfd.97.1595580264996; \n\tFri, 24 Jul 2020 01:44:24 -0700 (PDT)","Date":"Fri, 24 Jul 2020 10:44:23 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200724084423.GB2420270@oden.dyn.berto.se>","References":"<20200723173942.98182-1-niklas.soderlund@ragnatech.se>\n\t<20200723173942.98182-3-niklas.soderlund@ragnatech.se>\n\t<20200724084323.gplnummuhziesbh3@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200724084323.gplnummuhziesbh3@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 2/4] android: camera_device: Use\n\tHAL_PIXEL_FORMAT_* defines for formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11542,"web_url":"https://patchwork.libcamera.org/comment/11542/","msgid":"<20200724090036.i7hbb3ylrparjmod@uno.localdomain>","date":"2020-07-24T09:00:36","subject":"Re: [libcamera-devel] [PATCH 2/4] android: camera_device: Use\n\tHAL_PIXEL_FORMAT_* defines for formats","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Fri, Jul 24, 2020 at 10:44:23AM +0200, Niklas Söderlund wrote:\n> Hi Jacopo,\n>\n> Thanks for your feedback.\n>\n> On 2020-07-24 10:43:23 +0200, Jacopo Mondi wrote:\n> > Hi Niklas,\n> >\n> > On Thu, Jul 23, 2020 at 07:39:40PM +0200, Niklas Söderlund wrote:\n> > > The documentation says the HAL_PIXEL_FORMAT_* defines shall be used for\n> > > formats instead of ANDROID_SCALER_AVAILABLE_FORMATS_* for the\n> > > ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS and\n> > > ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS tags.\n> > >\n> > > This have worked in the past as the numerical value of the two sets are\n> > > the same for the formats supported.\n> >\n> > I wonder if in the future we would need scaler formats for other\n> > properties, but as the numerical values are the same, we could use the\n> > HAL_PIXEL_FORMAT_* definitions.\n> >\n> > Reviewed-by: Jacopo Mondi \n>\n> Was this comment and tag indented for 3/4 ?\n>\n\nYes :)\n\nSorry for confusion","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ECB84BD878\n\tfor ;\n\tFri, 24 Jul 2020 08:56:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6E286118F;\n\tFri, 24 Jul 2020 10:56:59 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71A986118A\n\tfor ;\n\tFri, 24 Jul 2020 10:56:58 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id E964240012;\n\tFri, 24 Jul 2020 08:56:57 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 24 Jul 2020 11:00:36 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200724090036.i7hbb3ylrparjmod@uno.localdomain>","References":"<20200723173942.98182-1-niklas.soderlund@ragnatech.se>\n\t<20200723173942.98182-3-niklas.soderlund@ragnatech.se>\n\t<20200724084323.gplnummuhziesbh3@uno.localdomain>\n\t<20200724084423.GB2420270@oden.dyn.berto.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200724084423.GB2420270@oden.dyn.berto.se>","Subject":"Re: [libcamera-devel] [PATCH 2/4] android: camera_device: Use\n\tHAL_PIXEL_FORMAT_* defines for formats","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]