[{"id":11536,"web_url":"https://patchwork.libcamera.org/comment/11536/","msgid":"<20200724083547.jgpqo3cyvyc3ace5@uno.localdomain>","date":"2020-07-24T08:35:47","subject":"Re: [libcamera-devel] [PATCH 1/4] android: camera_device: Remove\n\tANDROID_SCALER_AVAILABLE_FORMATS","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Thu, Jul 23, 2020 at 07:39:39PM +0200, Niklas Söderlund wrote:\n> According to the documentation the tag\n> ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS deprecates the\n> ANDROID_SCALER_AVAILABLE_FORMATS tag. As the HAL implements both tags\n> remove the deprecated one.\n\nIndeed deprecated! Sorry I missed that\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/android/camera_device.cpp | 15 ++-------------\n> 1 file changed, 2 insertions(+), 13 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 48f8090a93db454d..6e7673583f6a8f85 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -376,7 +376,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t * \\todo Keep this in sync with the actual number of entries.\n> \t * Currently: 50 entries, 647 bytes of static metadata\n> \t */\n> -\tuint32_t numEntries = 50;\n> +\tuint32_t numEntries = 49;\n> \tuint32_t byteSize = 647;\n>\n> \t/*\n> @@ -385,10 +385,9 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t *\n> \t * Each stream configuration entry requires 52 bytes:\n> \t * 4 32bits integers for ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS\n> -\t * 1 32bits integer for ANDROID_SCALER_AVAILABLE_FORMATS\n> \t * 4 64bits integers for ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS\n> \t */\n> -\tbyteSize += streamConfigurations_.size() * 52;\n> +\tbyteSize += streamConfigurations_.size() * 48;\n>\n> \treturn std::make_tuple(numEntries, byteSize);\n> }\n> @@ -656,15 +655,6 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM,\n> \t\t\t\t &maxDigitalZoom, 1);\n>\n> -\tstd::vector availableStreamFormats;\n> -\tavailableStreamFormats.reserve(streamConfigurations_.size());\n> -\tstd::transform(streamConfigurations_.begin(), streamConfigurations_.end(),\n> -\t\t std::back_inserter(availableStreamFormats),\n> -\t\t [](const auto &entry) { return entry.androidScalerCode; });\n> -\tstaticMetadata_->addEntry(ANDROID_SCALER_AVAILABLE_FORMATS,\n> -\t\t\t\t availableStreamFormats.data(),\n> -\t\t\t\t availableStreamFormats.size());\n> -\n> \tstd::vector availableStreamConfigurations;\n> \tavailableStreamConfigurations.reserve(streamConfigurations_.size() * 4);\n> \tfor (const auto &entry : streamConfigurations_) {\n> @@ -761,7 +751,6 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_LENS_INFO_MINIMUM_FOCUS_DISTANCE,\n> \t\tANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n> \t\tANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM,\n> -\t\tANDROID_SCALER_AVAILABLE_FORMATS,\n> \t\tANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n> \t\tANDROID_SCALER_AVAILABLE_STALL_DURATIONS,\n> \t\tANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS,\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D16B2BD878\n\tfor ;\n\tFri, 24 Jul 2020 08:32:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ABEA1611AA;\n\tFri, 24 Jul 2020 10:32:11 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 22FC26118F\n\tfor ;\n\tFri, 24 Jul 2020 10:32:10 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 7CF4CC000E;\n\tFri, 24 Jul 2020 08:32:09 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Fri, 24 Jul 2020 10:35:47 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200724083547.jgpqo3cyvyc3ace5@uno.localdomain>","References":"<20200723173942.98182-1-niklas.soderlund@ragnatech.se>\n\t<20200723173942.98182-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200723173942.98182-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 1/4] android: camera_device: Remove\n\tANDROID_SCALER_AVAILABLE_FORMATS","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]