{"id":8912,"url":"https://patchwork.libcamera.org/api/patches/8912/?format=json","web_url":"https://patchwork.libcamera.org/patch/8912/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200721220126.202065-4-kieran.bingham@ideasonboard.com>","date":"2020-07-21T22:01:23","name":"[libcamera-devel,RFC,3/6] android: camera_device: Add ANDROID_JPEG_MAX_SIZE","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"5b793097d3f9de0d4664bf31c0fe612ff9416b32","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8912/mbox/","series":[{"id":1125,"url":"https://patchwork.libcamera.org/api/series/1125/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1125","date":"2020-07-21T22:01:20","name":"android: jpeg / software streams","version":1,"mbox":"https://patchwork.libcamera.org/series/1125/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8912/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8912/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAC48C2E68\n\tfor ;\n\tTue, 21 Jul 2020 22:01:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4FD0560943;\n\tWed, 22 Jul 2020 00:01:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E585C6093F\n\tfor ;\n\tWed, 22 Jul 2020 00:01:32 +0200 (CEST)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BAD281229;\n\tWed, 22 Jul 2020 00:01:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HYzu6UXY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595368891;\n\tbh=aR6pbl4HFuMWZ97vbpuQwd2fSxu2mCwmBotV6PbSAf4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HYzu6UXYO3bbiXXxsELF4itXM1xsUzL8R1dLSM8OeR5g3BA4I69GmuI5XxSVMzB2r\n\tHSEbGsOOuO3pE2bZcmAJSsN7Pv0EdYroMzvSKMLN+x0TSVfxXuCDW9PAiRcce281Xf\n\tIHS5HjagRbrGSoZlJ6DDj4zoSNhDUW6ZDlvXX8FQ=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Tue, 21 Jul 2020 23:01:23 +0100","Message-Id":"<20200721220126.202065-4-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200721220126.202065-1-kieran.bingham@ideasonboard.com>","References":"<20200721220126.202065-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH 3/6] android: camera_device: Add\n\tANDROID_JPEG_MAX_SIZE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide a key for ANDROID_JPEG_MAX_SIZE. The value of 13MB is currently\narbitrary, but taken from the USB Camera HAL in CrOS platform2:\n\n // android.jpeg\n update_static(ANDROID_JPEG_MAX_SIZE, int32_t{13 << 20});\n update_request(ANDROID_JPEG_QUALITY, uint8_t{90});\n update_request(ANDROID_JPEG_THUMBNAIL_QUALITY, uint8_t{90});\n update_request(ANDROID_JPEG_ORIENTATION, int32_t{0});\n\nNote: The metadata entries/size updates are probably wrong, and should\nbe automated.\n\nSigned-off-by: Kieran Bingham \n---\n src/android/camera_device.cpp | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 3f3d7857f0ab..56652ac57676 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -407,10 +407,10 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n {\n \t/*\n \t * \\todo Keep this in sync with the actual number of entries.\n-\t * Currently: 50 entries, 647 bytes of static metadata\n+\t * Currently: 51 entries, 651 bytes of static metadata\n \t */\n-\tuint32_t numEntries = 50;\n-\tuint32_t byteSize = 647;\n+\tuint32_t numEntries = 51;\n+\tuint32_t byteSize = 651;\n \n \t/*\n \t * Calculate space occupation in bytes for dynamically built metadata\n@@ -567,6 +567,9 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t\t\t availableThumbnailSizes.data(),\n \t\t\t\t availableThumbnailSizes.size());\n \n+\tint32_t jpegMaxSize = 13 << 20; /* 13631488 from USB HAL */\n+\tstaticMetadata_->addEntry(ANDROID_JPEG_MAX_SIZE, &jpegMaxSize, 1);\n+\n \t/* Sensor static metadata. */\n \tint32_t pixelArraySize[] = {\n \t\t2592, 1944,\n@@ -773,6 +776,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n \t\tANDROID_CONTROL_AVAILABLE_MODES,\n \t\tANDROID_JPEG_AVAILABLE_THUMBNAIL_SIZES,\n+\t\tANDROID_JPEG_MAX_SIZE,\n \t\tANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n \t\tANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n \t\tANDROID_SENSOR_INFO_SENSITIVITY_RANGE,\n","prefixes":["libcamera-devel","RFC","3/6"]}