[{"id":11479,"web_url":"https://patchwork.libcamera.org/comment/11479/","msgid":"<20200722103600.j35rzjn7zvzem5bf@uno.localdomain>","date":"2020-07-22T10:36:00","subject":"Re: [libcamera-devel] [RFC PATCH 2/6] android: camera_device:\n\tReport configuration changes from validate()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Tue, Jul 21, 2020 at 11:01:22PM +0100, Kieran Bingham wrote:\n> When we call validate on a configuration, if there are any adjustments\n> on the configuration, we fail without showing why.\n>\n> Display the stream configuration after the validate stage to aid\n> debugging stream startup failures.\n>\n> Signed-off-by: Kieran Bingham \n> ---\n> src/android/camera_device.cpp | 8 ++++++++\n> 1 file changed, 8 insertions(+)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index f51542b282d5..3f3d7857f0ab 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1032,6 +1032,14 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> \t\tbreak;\n> \tcase CameraConfiguration::Adjusted:\n> \t\tLOG(HAL, Info) << \"Camera configuration adjusted\";\n> +\n> +\t\tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n> +\t\t\tCameraStream *cameraStream = &streams_[i];\n> +\t\t\tStreamConfiguration &cfg = config_->at(cameraStream->index);\n> +\n> +\t\t\tLOG(HAL, Info) << i << \" : \" << cfg.toString();\n\nDebug maybe ?\n\n> +\t\t}\n> +\n> \t\tconfig_.reset();\n> \t\treturn -EINVAL;\n> \tcase CameraConfiguration::Invalid:\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46E0FC2E68\n\tfor ;\n\tWed, 22 Jul 2020 10:32:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1A1456093D;\n\tWed, 22 Jul 2020 12:32:25 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E7936039F\n\tfor ;\n\tWed, 22 Jul 2020 12:32:23 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id DAF5160006;\n\tWed, 22 Jul 2020 10:32:22 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 22 Jul 2020 12:36:00 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200722103600.j35rzjn7zvzem5bf@uno.localdomain>","References":"<20200721220126.202065-1-kieran.bingham@ideasonboard.com>\n\t<20200721220126.202065-3-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200721220126.202065-3-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 2/6] android: camera_device:\n\tReport configuration changes from validate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11481,"web_url":"https://patchwork.libcamera.org/comment/11481/","msgid":"<5088aa4a-ecec-c1b3-8b0d-11f64ffb3fdf@ideasonboard.com>","date":"2020-07-22T11:08:13","subject":"Re: [libcamera-devel] [RFC PATCH 2/6] android: camera_device:\n\tReport configuration changes from validate()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 22/07/2020 11:36, Jacopo Mondi wrote:\n> Hi Kieran,\n> \n> On Tue, Jul 21, 2020 at 11:01:22PM +0100, Kieran Bingham wrote:\n>> When we call validate on a configuration, if there are any adjustments\n>> on the configuration, we fail without showing why.\n>>\n>> Display the stream configuration after the validate stage to aid\n>> debugging stream startup failures.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> src/android/camera_device.cpp | 8 ++++++++\n>> 1 file changed, 8 insertions(+)\n>>\n>> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n>> index f51542b282d5..3f3d7857f0ab 100644\n>> --- a/src/android/camera_device.cpp\n>> +++ b/src/android/camera_device.cpp\n>> @@ -1032,6 +1032,14 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n>> \t\tbreak;\n>> \tcase CameraConfiguration::Adjusted:\n>> \t\tLOG(HAL, Info) << \"Camera configuration adjusted\";\n>> +\n>> +\t\tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n>> +\t\t\tCameraStream *cameraStream = &streams_[i];\n>> +\t\t\tStreamConfiguration &cfg = config_->at(cameraStream->index);\n>> +\n>> +\t\t\tLOG(HAL, Info) << i << \" : \" << cfg.toString();\n> \n> Debug maybe ?\n\nThis is on the fail path, so it's highly relevant to seeing why the\nstream was not constructed. The validation phase has failed. I chose\n'Info' to match the warning statement above.\n\nThis is a continuation of that statement IMO, It could be reduced to\nDebug ... but I would expect /any/ time this has printed, that it would\nbe relevant to know... I'd almost put it as a Warning....\n\nUnless Android uses this path as a means to test the capabilities of the\ndevice? If it's a 'probing' path and failures are expected then yes,\nthis could be a Debug print ... but I sort of thought this code path\nexpects success... so a validation failure is a fairly critical event.\n\nIf that is true, I'd even put the \"Camera configuration adjusted\" up to\nwarning/error though.\n\n\n> \n>> +\t\t}\n>> +\n>> \t\tconfig_.reset();\n>> \t\treturn -EINVAL;\n>> \tcase CameraConfiguration::Invalid:\n>> --\n>> 2.25.1\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5106C2E68\n\tfor ;\n\tWed, 22 Jul 2020 11:08:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 80AD96093D;\n\tWed, 22 Jul 2020 13:08:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 996616039F\n\tfor ;\n\tWed, 22 Jul 2020 13:08:16 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 07F71329;\n\tWed, 22 Jul 2020 13:08:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pHQMRxsu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595416096;\n\tbh=h3C5WuK/TbKd0F1OKED2e4rKnk8qnS7TSqdVwVfdOZk=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=pHQMRxsu785SkMTiTtSORktz8N/o2mDA9qQSnaUCc0ZcEpFcvqaFJS8exOwp0o6TA\n\tRTPlczx1kWbRBDFRLdXRM4NDiz3dIRKAWu3jNuFomOlEcSg4mBPFbUu8QQglZwit+0\n\tncLY8D47dj7zAXXrwB2hItQKZOm4fAtOAfBBCe4E=","To":"Jacopo Mondi ","References":"<20200721220126.202065-1-kieran.bingham@ideasonboard.com>\n\t<20200721220126.202065-3-kieran.bingham@ideasonboard.com>\n\t<20200722103600.j35rzjn7zvzem5bf@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<5088aa4a-ecec-c1b3-8b0d-11f64ffb3fdf@ideasonboard.com>","Date":"Wed, 22 Jul 2020 12:08:13 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200722103600.j35rzjn7zvzem5bf@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [RFC PATCH 2/6] android: camera_device:\n\tReport configuration changes from validate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11674,"web_url":"https://patchwork.libcamera.org/comment/11674/","msgid":"<20200728161619.mswy7ubuvk6ext4m@uno.localdomain>","date":"2020-07-28T16:16:19","subject":"Re: [libcamera-devel] [RFC PATCH 2/6] android: camera_device:\n\tReport configuration changes from validate()","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Wed, Jul 22, 2020 at 12:08:13PM +0100, Kieran Bingham wrote:\n> On 22/07/2020 11:36, Jacopo Mondi wrote:\n> > Hi Kieran,\n> >\n> > On Tue, Jul 21, 2020 at 11:01:22PM +0100, Kieran Bingham wrote:\n> >> When we call validate on a configuration, if there are any adjustments\n> >> on the configuration, we fail without showing why.\n> >>\n> >> Display the stream configuration after the validate stage to aid\n> >> debugging stream startup failures.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> src/android/camera_device.cpp | 8 ++++++++\n> >> 1 file changed, 8 insertions(+)\n> >>\n> >> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> >> index f51542b282d5..3f3d7857f0ab 100644\n> >> --- a/src/android/camera_device.cpp\n> >> +++ b/src/android/camera_device.cpp\n> >> @@ -1032,6 +1032,14 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n> >> \t\tbreak;\n> >> \tcase CameraConfiguration::Adjusted:\n> >> \t\tLOG(HAL, Info) << \"Camera configuration adjusted\";\n> >> +\n> >> +\t\tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n> >> +\t\t\tCameraStream *cameraStream = &streams_[i];\n> >> +\t\t\tStreamConfiguration &cfg = config_->at(cameraStream->index);\n> >> +\n> >> +\t\t\tLOG(HAL, Info) << i << \" : \" << cfg.toString();\n> >\n> > Debug maybe ?\n>\n> This is on the fail path, so it's highly relevant to seeing why the\n> stream was not constructed. The validation phase has failed. I chose\n> 'Info' to match the warning statement above.\n\nOh well, we fail on adjusted stream, so it makes sense, I was afraid\nof messages being duplicated between here and the pipeline handler.\n\n>\n> This is a continuation of that statement IMO, It could be reduced to\n> Debug ... but I would expect /any/ time this has printed, that it would\n> be relevant to know... I'd almost put it as a Warning....\n>\n> Unless Android uses this path as a means to test the capabilities of the\n> device? If it's a 'probing' path and failures are expected then yes,\n> this could be a Debug print ... but I sort of thought this code path\n> expects success... so a validation failure is a fairly critical event.\n\nI guess it does expect to succeed yes, as the HAL reports to the\nframework which streams are supported. Although their combination can\nfail, but I don't see Android application to 'try-and-see' up to the\npoint of flooding the log with this error message :)\n\n>\n> If that is true, I'd even put the \"Camera configuration adjusted\" up to\n> warning/error though.\n\nwe could, and if it's too invasive we can demote it later\n\nThanks\n j\n\n>\n>\n> >\n> >> +\t\t}\n> >> +\n> >> \t\tconfig_.reset();\n> >> \t\treturn -EINVAL;\n> >> \tcase CameraConfiguration::Invalid:\n> >> --\n> >> 2.25.1\n> >>\n> >> _______________________________________________\n> >> libcamera-devel mailing list\n> >> libcamera-devel@lists.libcamera.org\n> >> https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B152BD878\n\tfor ;\n\tTue, 28 Jul 2020 16:12:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2599613C6;\n\tTue, 28 Jul 2020 18:12:40 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 202A560923\n\tfor ;\n\tTue, 28 Jul 2020 18:12:40 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 6EC7A20000D;\n\tTue, 28 Jul 2020 16:12:39 +0000 (UTC)"],"Date":"Tue, 28 Jul 2020 18:16:19 +0200","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20200728161619.mswy7ubuvk6ext4m@uno.localdomain>","References":"<20200721220126.202065-1-kieran.bingham@ideasonboard.com>\n\t<20200721220126.202065-3-kieran.bingham@ideasonboard.com>\n\t<20200722103600.j35rzjn7zvzem5bf@uno.localdomain>\n\t<5088aa4a-ecec-c1b3-8b0d-11f64ffb3fdf@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<5088aa4a-ecec-c1b3-8b0d-11f64ffb3fdf@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 2/6] android: camera_device:\n\tReport configuration changes from validate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]