{"id":8911,"url":"https://patchwork.libcamera.org/api/patches/8911/?format=json","web_url":"https://patchwork.libcamera.org/patch/8911/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200721220126.202065-3-kieran.bingham@ideasonboard.com>","date":"2020-07-21T22:01:22","name":"[libcamera-devel,RFC,2/6] android: camera_device: Report configuration changes from validate()","commit_ref":null,"pull_url":null,"state":"rfc","archived":false,"hash":"e34dda00ba66bf17c24d7edebc06bb54b4a28903","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8911/mbox/","series":[{"id":1125,"url":"https://patchwork.libcamera.org/api/series/1125/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1125","date":"2020-07-21T22:01:20","name":"android: jpeg / software streams","version":1,"mbox":"https://patchwork.libcamera.org/series/1125/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8911/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8911/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6EAB0C2E68\n\tfor ;\n\tTue, 21 Jul 2020 22:01:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8FB67609A2;\n\tWed, 22 Jul 2020 00:01:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B586B6093B\n\tfor ;\n\tWed, 22 Jul 2020 00:01:32 +0200 (CEST)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 613ECA58;\n\tWed, 22 Jul 2020 00:01:31 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"a62ZyhAF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595368891;\n\tbh=WDrrFmfz091GJHNh2ME1Ki/sACWbRrIOaIjhNnjAkto=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=a62ZyhAFrUgbAV0tc8kttgfW5Um2f7IaSQy2EKoxzS5RPabLWKvOZHPnHf5N+MmWD\n\twH0N7WpL2TY3QT0IQsU/Nv3G4X3r+Jv/M6odRHEr4DR7WKZscJxdjNpe+QQ5RmqI6d\n\tzZPOjJTl5nRl3q5qqeUwrejhPdiAobD90JlkiVsk=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Tue, 21 Jul 2020 23:01:22 +0100","Message-Id":"<20200721220126.202065-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200721220126.202065-1-kieran.bingham@ideasonboard.com>","References":"<20200721220126.202065-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH 2/6] android: camera_device: Report\n\tconfiguration changes from validate()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When we call validate on a configuration, if there are any adjustments\non the configuration, we fail without showing why.\n\nDisplay the stream configuration after the validate stage to aid\ndebugging stream startup failures.\n\nSigned-off-by: Kieran Bingham \n---\n src/android/camera_device.cpp | 8 ++++++++\n 1 file changed, 8 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex f51542b282d5..3f3d7857f0ab 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1032,6 +1032,14 @@ int CameraDevice::configureStreams(camera3_stream_configuration_t *stream_list)\n \t\tbreak;\n \tcase CameraConfiguration::Adjusted:\n \t\tLOG(HAL, Info) << \"Camera configuration adjusted\";\n+\n+\t\tfor (unsigned int i = 0; i < stream_list->num_streams; ++i) {\n+\t\t\tCameraStream *cameraStream = &streams_[i];\n+\t\t\tStreamConfiguration &cfg = config_->at(cameraStream->index);\n+\n+\t\t\tLOG(HAL, Info) << i << \" : \" << cfg.toString();\n+\t\t}\n+\n \t\tconfig_.reset();\n \t\treturn -EINVAL;\n \tcase CameraConfiguration::Invalid:\n","prefixes":["libcamera-devel","RFC","2/6"]}