[{"id":11467,"web_url":"https://patchwork.libcamera.org/comment/11467/","msgid":"<20200721150913.nwrznv3ar4zp2n7b@uno.localdomain>","date":"2020-07-21T15:09:13","subject":"Re: [libcamera-devel] [PATCH v2 3/3] libcamera: v4l2_videodevice:\n\tAdd using statement for format map","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n happy to see the custom maps going away\n\nOn Tue, Jul 21, 2020 at 03:55:41PM +0200, Niklas Söderlund wrote:\n> Define a using statement for the format maps returned by\n> V4L2Device::formats() and use it in all call sites. There is no\n> functional change in this patch.\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> include/libcamera/internal/v4l2_videodevice.h | 4 +++-\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 13 ++++++-------\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 +--\n> src/libcamera/v4l2_videodevice.cpp | 9 +++++++--\n> 5 files changed, 18 insertions(+), 13 deletions(-)\n>\n> diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\n> index fb4c0aabdd46206c..40ed87e17cfa6d3c 100644\n> --- a/include/libcamera/internal/v4l2_videodevice.h\n> +++ b/include/libcamera/internal/v4l2_videodevice.h\n> @@ -168,6 +168,8 @@ public:\n> class V4L2VideoDevice : public V4L2Device\n> {\n> public:\n> +\tusing Formats = std::map>;\n> +\n> \texplicit V4L2VideoDevice(const std::string &deviceNode);\n> \texplicit V4L2VideoDevice(const MediaEntity *entity);\n> \tV4L2VideoDevice(const V4L2VideoDevice &) = delete;\n> @@ -188,7 +190,7 @@ public:\n> \tint getFormat(V4L2DeviceFormat *format);\n> \tint tryFormat(V4L2DeviceFormat *format);\n> \tint setFormat(V4L2DeviceFormat *format);\n> -\tstd::map> formats(uint32_t code = 0);\n> +\tFormats formats(uint32_t code = 0);\n>\n> \tint setSelection(unsigned int target, Rectangle *rect);\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index bf1c77144f855df9..82a0a4dfd6824fce 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -39,8 +39,6 @@ namespace libcamera {\n>\n> LOG_DEFINE_CATEGORY(RPI)\n>\n> -using V4L2PixFmtMap = std::map>;\n> -\n> namespace {\n>\n> bool isRaw(PixelFormat &pixFmt)\n> @@ -69,7 +67,8 @@ double scoreFormat(double desired, double actual)\n> \treturn score;\n> }\n>\n> -V4L2DeviceFormat findBestMode(V4L2PixFmtMap &formatsMap, const Size &req)\n> +V4L2DeviceFormat findBestMode(V4L2VideoDevice::Formats &formatsMap,\n> +\t\t\t const Size &req)\n> {\n> \tdouble bestScore = std::numeric_limits::max(), score;\n> \tV4L2DeviceFormat bestMode = {};\n> @@ -410,7 +409,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> \t\t\t * Calculate the best sensor mode we can use based on\n> \t\t\t * the user request.\n> \t\t\t */\n> -\t\t\tV4L2PixFmtMap fmts = data_->unicam_[Unicam::Image].dev()->formats();\n> +\t\t\tV4L2VideoDevice::Formats fmts = data_->unicam_[Unicam::Image].dev()->formats();\n> \t\t\tV4L2DeviceFormat sensorFormat = findBestMode(fmts, cfg.size);\n> \t\t\tint ret = data_->unicam_[Unicam::Image].dev()->tryFormat(&sensorFormat);\n> \t\t\tif (ret)\n> @@ -480,7 +479,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> \t\telse\n> \t\t\tdev = data_->isp_[Isp::Output1].dev();\n>\n> -\t\tV4L2PixFmtMap fmts = dev->formats();\n> +\t\tV4L2VideoDevice::Formats fmts = dev->formats();\n>\n> \t\tif (fmts.find(V4L2PixelFormat::fromPixelFormat(cfgPixFmt, false)) == fmts.end()) {\n> \t\t\t/* If we cannot find a native format, use a default one. */\n> @@ -517,7 +516,7 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,\n> \tV4L2DeviceFormat sensorFormat;\n> \tunsigned int bufferCount;\n> \tPixelFormat pixelFormat;\n> -\tV4L2PixFmtMap fmts;\n> +\tV4L2VideoDevice::Formats fmts;\n> \tSize size;\n>\n> \tif (roles.empty())\n> @@ -633,7 +632,7 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> \t}\n>\n> \t/* First calculate the best sensor mode we can use based on the user request. */\n> -\tV4L2PixFmtMap fmts = data->unicam_[Unicam::Image].dev()->formats();\n> +\tV4L2VideoDevice::Formats fmts = data->unicam_[Unicam::Image].dev()->formats();\n> \tV4L2DeviceFormat sensorFormat = findBestMode(fmts, rawStream ? sensorSize : maxSize);\n>\n> \t/*\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 28d367883323d855..5221ff3384923f56 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -275,7 +275,7 @@ int SimpleCameraData::init()\n> \t\t\treturn ret;\n> \t\t}\n>\n> -\t\tstd::map> videoFormats =\n> +\t\tV4L2VideoDevice::Formats videoFormats =\n> \t\t\tvideo_->formats(format.mbus_code);\n>\n> \t\tLOG(SimplePipeline, Debug)\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 47f383d1551d5193..93e3dc17e3a7105e 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -172,8 +172,7 @@ CameraConfiguration *PipelineHandlerUVC::generateConfiguration(Camera *camera,\n> \tif (roles.empty())\n> \t\treturn config;\n>\n> -\tstd::map> v4l2Formats =\n> -\t\tdata->video_->formats();\n> +\tV4L2VideoDevice::Formats v4l2Formats = data->video_->formats();\n> \tstd::map> deviceFormats;\n> \tfor (const auto &format : v4l2Formats) {\n> \t\tPixelFormat pixelFormat = format.first.toPixelFormat();\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index e0d2201269440795..9c4f3524af735598 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -461,6 +461,11 @@ const std::string V4L2DeviceFormat::toString() const\n> * \\context This class is \\threadbound.\n> */\n>\n> +/**\n> + * \\typedef V4L2VideoDevice::Formats\n> + * \\brief A map of supported V4L2 pixel formats to frame sizes\n> + */\n> +\n> /**\n> * \\brief Construct a V4L2VideoDevice\n> * \\param[in] deviceNode The file-system path to the video device node\n> @@ -951,9 +956,9 @@ int V4L2VideoDevice::trySetFormatSingleplane(V4L2DeviceFormat *format, bool set)\n> *\n> * \\return A list of the supported video device formats\n> */\n> -std::map> V4L2VideoDevice::formats(uint32_t code)\n> +V4L2VideoDevice::Formats V4L2VideoDevice::formats(uint32_t code)\n> {\n> -\tstd::map> formats;\n> +\tV4L2VideoDevice::Formats formats;\n\nI think this could just be 'Formats'\n\nnit apart\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> \tfor (V4L2PixelFormat pixelFormat : enumPixelformats(code)) {\n> \t\tstd::vector sizes = enumSizes(pixelFormat);\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22C35C2E68\n\tfor ;\n\tTue, 21 Jul 2020 15:05:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 84D8C60915;\n\tTue, 21 Jul 2020 17:05:38 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D26CC6053C\n\tfor ;\n\tTue, 21 Jul 2020 17:05:36 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 1CF2F4000E;\n\tTue, 21 Jul 2020 15:05:35 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Tue, 21 Jul 2020 17:09:13 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200721150913.nwrznv3ar4zp2n7b@uno.localdomain>","References":"<20200721135541.2931205-1-niklas.soderlund@ragnatech.se>\n\t<20200721135541.2931205-4-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200721135541.2931205-4-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2 3/3] libcamera: v4l2_videodevice:\n\tAdd using statement for format map","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11524,"web_url":"https://patchwork.libcamera.org/comment/11524/","msgid":"<20200723142103.GC5920@pendragon.ideasonboard.com>","date":"2020-07-23T14:21:03","subject":"Re: [libcamera-devel] [PATCH v2 3/3] libcamera: v4l2_videodevice:\n\tAdd using statement for format map","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Jul 21, 2020 at 03:55:41PM +0200, Niklas Söderlund wrote:\n> Define a using statement for the format maps returned by\n> V4L2Device::formats() and use it in all call sites. There is no\n> functional change in this patch.\n> \n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/internal/v4l2_videodevice.h | 4 +++-\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 13 ++++++-------\n> src/libcamera/pipeline/simple/simple.cpp | 2 +-\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 3 +--\n> src/libcamera/v4l2_videodevice.cpp | 9 +++++++--\n> 5 files changed, 18 insertions(+), 13 deletions(-)\n> \n> diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\n> index fb4c0aabdd46206c..40ed87e17cfa6d3c 100644\n> --- a/include/libcamera/internal/v4l2_videodevice.h\n> +++ b/include/libcamera/internal/v4l2_videodevice.h\n> @@ -168,6 +168,8 @@ public:\n> class V4L2VideoDevice : public V4L2Device\n> {\n> public:\n> +\tusing Formats = std::map>;\n> +\n> \texplicit V4L2VideoDevice(const std::string &deviceNode);\n> \texplicit V4L2VideoDevice(const MediaEntity *entity);\n> \tV4L2VideoDevice(const V4L2VideoDevice &) = delete;\n> @@ -188,7 +190,7 @@ public:\n> \tint getFormat(V4L2DeviceFormat *format);\n> \tint tryFormat(V4L2DeviceFormat *format);\n> \tint setFormat(V4L2DeviceFormat *format);\n> -\tstd::map> formats(uint32_t code = 0);\n> +\tFormats formats(uint32_t code = 0);\n> \n> \tint setSelection(unsigned int target, Rectangle *rect);\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index bf1c77144f855df9..82a0a4dfd6824fce 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -39,8 +39,6 @@ namespace libcamera {\n> \n> LOG_DEFINE_CATEGORY(RPI)\n> \n> -using V4L2PixFmtMap = std::map>;\n> -\n> namespace {\n> \n> bool isRaw(PixelFormat &pixFmt)\n> @@ -69,7 +67,8 @@ double scoreFormat(double desired, double actual)\n> \treturn score;\n> }\n> \n> -V4L2DeviceFormat findBestMode(V4L2PixFmtMap &formatsMap, const Size &req)\n> +V4L2DeviceFormat findBestMode(V4L2VideoDevice::Formats &formatsMap,\n> +\t\t\t const Size &req)\n> {\n> \tdouble bestScore = std::numeric_limits::max(), score;\n> \tV4L2DeviceFormat bestMode = {};\n> @@ -410,7 +409,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> \t\t\t * Calculate the best sensor mode we can use based on\n> \t\t\t * the user request.\n> \t\t\t */\n> -\t\t\tV4L2PixFmtMap fmts = data_->unicam_[Unicam::Image].dev()->formats();\n> +\t\t\tV4L2VideoDevice::Formats fmts = data_->unicam_[Unicam::Image].dev()->formats();\n> \t\t\tV4L2DeviceFormat sensorFormat = findBestMode(fmts, cfg.size);\n> \t\t\tint ret = data_->unicam_[Unicam::Image].dev()->tryFormat(&sensorFormat);\n> \t\t\tif (ret)\n> @@ -480,7 +479,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n> \t\telse\n> \t\t\tdev = data_->isp_[Isp::Output1].dev();\n> \n> -\t\tV4L2PixFmtMap fmts = dev->formats();\n> +\t\tV4L2VideoDevice::Formats fmts = dev->formats();\n> \n> \t\tif (fmts.find(V4L2PixelFormat::fromPixelFormat(cfgPixFmt, false)) == fmts.end()) {\n> \t\t\t/* If we cannot find a native format, use a default one. */\n> @@ -517,7 +516,7 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,\n> \tV4L2DeviceFormat sensorFormat;\n> \tunsigned int bufferCount;\n> \tPixelFormat pixelFormat;\n> -\tV4L2PixFmtMap fmts;\n> +\tV4L2VideoDevice::Formats fmts;\n> \tSize size;\n> \n> \tif (roles.empty())\n> @@ -633,7 +632,7 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n> \t}\n> \n> \t/* First calculate the best sensor mode we can use based on the user request. */\n> -\tV4L2PixFmtMap fmts = data->unicam_[Unicam::Image].dev()->formats();\n> +\tV4L2VideoDevice::Formats fmts = data->unicam_[Unicam::Image].dev()->formats();\n> \tV4L2DeviceFormat sensorFormat = findBestMode(fmts, rawStream ? sensorSize : maxSize);\n> \n> \t/*\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 28d367883323d855..5221ff3384923f56 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -275,7 +275,7 @@ int SimpleCameraData::init()\n> \t\t\treturn ret;\n> \t\t}\n> \n> -\t\tstd::map> videoFormats =\n> +\t\tV4L2VideoDevice::Formats videoFormats =\n> \t\t\tvideo_->formats(format.mbus_code);\n> \n> \t\tLOG(SimplePipeline, Debug)\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index 47f383d1551d5193..93e3dc17e3a7105e 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -172,8 +172,7 @@ CameraConfiguration *PipelineHandlerUVC::generateConfiguration(Camera *camera,\n> \tif (roles.empty())\n> \t\treturn config;\n> \n> -\tstd::map> v4l2Formats =\n> -\t\tdata->video_->formats();\n> +\tV4L2VideoDevice::Formats v4l2Formats = data->video_->formats();\n> \tstd::map> deviceFormats;\n> \tfor (const auto &format : v4l2Formats) {\n> \t\tPixelFormat pixelFormat = format.first.toPixelFormat();\n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index e0d2201269440795..9c4f3524af735598 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -461,6 +461,11 @@ const std::string V4L2DeviceFormat::toString() const\n> * \\context This class is \\threadbound.\n> */\n> \n> +/**\n> + * \\typedef V4L2VideoDevice::Formats\n> + * \\brief A map of supported V4L2 pixel formats to frame sizes\n> + */\n> +\n> /**\n> * \\brief Construct a V4L2VideoDevice\n> * \\param[in] deviceNode The file-system path to the video device node\n> @@ -951,9 +956,9 @@ int V4L2VideoDevice::trySetFormatSingleplane(V4L2DeviceFormat *format, bool set)\n> *\n> * \\return A list of the supported video device formats\n> */\n> -std::map> V4L2VideoDevice::formats(uint32_t code)\n> +V4L2VideoDevice::Formats V4L2VideoDevice::formats(uint32_t code)\n> {\n> -\tstd::map> formats;\n> +\tV4L2VideoDevice::Formats formats;\n> \n> \tfor (V4L2PixelFormat pixelFormat : enumPixelformats(code)) {\n> \t\tstd::vector sizes = enumSizes(pixelFormat);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A668CBD86F\n\tfor ;\n\tThu, 23 Jul 2020 14:21:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 736F561159;\n\tThu, 23 Jul 2020 16:21:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5E38E60493\n\tfor ;\n\tThu, 23 Jul 2020 16:21:09 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 00118279;\n\tThu, 23 Jul 2020 16:21:08 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FYYOHmBN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595514069;\n\tbh=ntUA/7mz72rSPRDmC5t8FfaBzP9ihatt8SVhiR9WBKU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FYYOHmBNYNwTdKnrwBYTyXzt3Bpk3Z8VogHjjLa0DNSVq5qEBkxuzbS/pRIi+p5qz\n\tCdZIHOdTBMvp2lzDr5ySxPUvc3lyiuIMam2SdK7f0pD4rRJ/z3lkslwKEYxR/g08FY\n\tbYDIzppZXAoqUDdJ+NQqZQd8u9ObWaWA2FL8GZkc=","Date":"Thu, 23 Jul 2020 17:21:03 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200723142103.GC5920@pendragon.ideasonboard.com>","References":"<20200721135541.2931205-1-niklas.soderlund@ragnatech.se>\n\t<20200721135541.2931205-4-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200721135541.2931205-4-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v2 3/3] libcamera: v4l2_videodevice:\n\tAdd using statement for format map","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]