[{"id":11575,"web_url":"https://patchwork.libcamera.org/comment/11575/","msgid":"<20200724170352.GQ5921@pendragon.ideasonboard.com>","date":"2020-07-24T17:03:52","subject":"Re: [libcamera-devel] [RFC PATCH 5/8] android: camera_device:\n\tReport an error in notifyError()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Mon, Jul 20, 2020 at 11:42:29PM +0100, Kieran Bingham wrote:\n> If an error is generated, try to be verbose about it in the libcamera logs.\n> \n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Niklas Söderlund \n> \n> ---\n> \n> A little unrelated from the RFC series, but in the tree and at v2, so\n> posted anyway.... This helps ;-)\n> \n> v2:\n> - Add todo to note possible debug info expansion\n> - Fix typo\n> - Print .toString() formatted pixel format\n> \n> src/android/camera_device.cpp | 7 +++++++\n> 1 file changed, 7 insertions(+)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 48f8090a93db..e5c50084e590 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1209,6 +1209,13 @@ void CameraDevice::notifyError(uint32_t frameNumber, camera3_stream_t *stream)\n> {\n> \tcamera3_notify_msg_t notify = {};\n> \n> +\t/*\n> +\t * \\todo: Report and identify the stream number or configuration to\n\ns/todo:/todo/\n\nReviewed-by: Laurent Pinchart \n\n> +\t * clarify the stream that failed.\n> +\t */\n> +\tLOG(HAL, Error) << \"Error occurred on frame \" << frameNumber << \" (\"\n> +\t\t\t<< toPixelFormat(stream->format).toString() << \")\";\n> +\n> \tnotify.type = CAMERA3_MSG_ERROR;\n> \tnotify.message.error.error_stream = stream;\n> \tnotify.message.error.frame_number = frameNumber;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 86264BD878\n\tfor ;\n\tFri, 24 Jul 2020 17:04:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 04DC861218;\n\tFri, 24 Jul 2020 19:04:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D622B605B2\n\tfor ;\n\tFri, 24 Jul 2020 19:03:59 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5511B538;\n\tFri, 24 Jul 2020 19:03:59 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ltIUMLUI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595610239;\n\tbh=z50WI0UIhZ7khcbpT7qqb7iwiIFKKuZ1Ujyvv78AceM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ltIUMLUIQwin8Bnbi0JVZYDgQyVAjCnXvmOFTornLixys0GzxTwgZt88r3ByMqQl0\n\tlZ+9A+xRRqKrqAZs7bFf5nZc6iQIfpO4fjFiLULG8lVM7G0VDmw/PhQdNeKIfC0X86\n\tp3y5A42LnTQUqKWpTbtb/T1q3/dAAv5Uia4EqRjQ=","Date":"Fri, 24 Jul 2020 20:03:52 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200724170352.GQ5921@pendragon.ideasonboard.com>","References":"<20200720224232.153717-1-kieran.bingham@ideasonboard.com>\n\t<20200720224232.153717-6-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200720224232.153717-6-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [RFC PATCH 5/8] android: camera_device:\n\tReport an error in notifyError()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]