{"id":888,"url":"https://patchwork.libcamera.org/api/patches/888/?format=json","web_url":"https://patchwork.libcamera.org/patch/888/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190403080148.11479-2-jacopo@jmondi.org>","date":"2019-04-03T08:01:36","name":"[libcamera-devel,v8,01/13] libcamera: geometry: Add 0-initialized SizeRange constructor","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"054d60131eca43a99eedcf8f4a22150ca82334dd","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/888/mbox/","series":[{"id":235,"url":"https://patchwork.libcamera.org/api/series/235/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=235","date":"2019-04-03T08:01:35","name":"libcamera: ipu3: Add ImgU support","version":8,"mbox":"https://patchwork.libcamera.org/series/235/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/888/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/888/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C0E2A6110D\n\tfor ;\n\tWed, 3 Apr 2019 10:01:10 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id EEEEF6000A;\n\tWed, 3 Apr 2019 08:01:08 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 3 Apr 2019 10:01:36 +0200","Message-Id":"<20190403080148.11479-2-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190403080148.11479-1-jacopo@jmondi.org>","References":"<20190403080148.11479-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v8 01/13] libcamera: geometry: Add\n\t0-initialized SizeRange constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 03 Apr 2019 08:01:11 -0000"},"content":"Add constructor to SizeRange which initialize all the size range fields\nto 0.\n\nWhile at there make the in-line constructor declarations respect the\ncoding style by moving braces to a new line.\n\nReviewed-by: Laurent Pinchart \nReviewed-by: Niklas Söderlund \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/geometry.cpp | 11 ++++++++++-\n src/libcamera/include/geometry.h | 9 ++++++++-\n 2 files changed, 18 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\nindex 6dc8e74d2801..f76001d94562 100644\n--- a/src/libcamera/geometry.cpp\n+++ b/src/libcamera/geometry.cpp\n@@ -73,7 +73,16 @@ const std::string Rectangle::toString() const\n \n /**\n * \\fn SizeRange::SizeRange()\n- * \\brief Construct a size range\n+ * \\brief Construct a size range initialized to 0\n+ */\n+\n+/**\n+ * \\fn SizeRange::SizeRange(unsigned int minW, unsigned int minH, unsigned int maxW, unsigned int maxH)\n+ * \\brief Construct an initialized size range\n+ * \\param minW The minimum width\n+ * \\param minH The minimum height\n+ * \\param maxW The maximum width\n+ * \\param maxH The maximum height\n */\n \n /**\ndiff --git a/src/libcamera/include/geometry.h b/src/libcamera/include/geometry.h\nindex b14f9732f3db..d8d587d3b47b 100644\n--- a/src/libcamera/include/geometry.h\n+++ b/src/libcamera/include/geometry.h\n@@ -22,10 +22,17 @@ struct Rectangle {\n };\n \n struct SizeRange {\n+\tSizeRange()\n+\t\t: SizeRange(0, 0, 0, 0)\n+\t{\n+\t}\n+\n \tSizeRange(unsigned int minW, unsigned int minH,\n \t\t unsigned int maxW, unsigned int maxH)\n \t\t: minWidth(minW), minHeight(minH), maxWidth(maxW),\n-\t\t maxHeight(maxH) {}\n+\t\t maxHeight(maxH)\n+\t{\n+\t}\n \n \tunsigned int minWidth;\n \tunsigned int minHeight;\n","prefixes":["libcamera-devel","v8","01/13"]}