[{"id":11733,"web_url":"https://patchwork.libcamera.org/comment/11733/","msgid":"<20200730164047.GC6107@pendragon.ideasonboard.com>","date":"2020-07-30T16:40:47","subject":"Re: [libcamera-devel] [PATCH v4 06/19] libcamera: ipu3: cio2:\n\tReport format and sizes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Jul 20, 2020 at 12:47:23PM +0200, Jacopo Mondi wrote:\n> Add two methods to the CIO2Device class to retrieve all the supported\n> PixelFormats and sizes.\n> \n> Reviewed-by: Niklas Söderlund \n> Signed-off-by: Jacopo Mondi \n\nThis feels a bit like an ad-hoc API, probably because it is :-) I'm sure\nwe'll rework the IPU3 code further, for now it should be fine.\n\nAcked-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/cio2.cpp | 40 ++++++++++++++++++++++++++++\n> src/libcamera/pipeline/ipu3/cio2.h | 5 ++++\n> 2 files changed, 45 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/cio2.cpp b/src/libcamera/pipeline/ipu3/cio2.cpp\n> index 77f54da47e28..abe6d8a592d6 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.cpp\n> +++ b/src/libcamera/pipeline/ipu3/cio2.cpp\n> @@ -10,6 +10,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> \n> #include \"libcamera/internal/camera_sensor.h\"\n> @@ -43,6 +44,45 @@ CIO2Device::~CIO2Device()\n> \tdelete sensor_;\n> }\n> \n> +/**\n> + * \\brief Retrieve the list of supported PixelFormats\n> + *\n> + * Retrieve the list of supported pixel formats by matching the sensor produced\n> + * media bus codes with the formats supported by the CIO2 unit.\n> + *\n> + * \\return The list of supported PixelFormat\n> + */\n> +std::vector CIO2Device::formats() const\n> +{\n> +\tif (!sensor_)\n> +\t\treturn {};\n> +\n> +\tstd::vector formats;\n> +\tfor (unsigned int code : sensor_->mbusCodes()) {\n> +\t\tauto it = mbusCodesToPixelFormat.find(code);\n> +\t\tif (it != mbusCodesToPixelFormat.end())\n> +\t\t\tformats.push_back(it->second);\n> +\t}\n> +\n> +\treturn formats;\n> +}\n> +\n> +/**\n> + * \\brief Retrieve the list of supported size ranges\n> + * \\return The list of supported SizeRange\n> + */\n> +std::vector CIO2Device::sizes() const\n> +{\n> +\tif (!sensor_)\n> +\t\treturn {};\n> +\n> +\tstd::vector sizes;\n> +\tfor (const Size &size : sensor_->sizes())\n> +\t\tsizes.emplace_back(size, size);\n> +\n> +\treturn sizes;\n> +}\n> +\n> /**\n> * \\brief Initialize components of the CIO2 device with \\a index\n> * \\param[in] media The CIO2 media device\n> diff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h\n> index 956355a0aa58..221cf817eee9 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.h\n> +++ b/src/libcamera/pipeline/ipu3/cio2.h\n> @@ -20,8 +20,10 @@ namespace libcamera {\n> class CameraSensor;\n> class FrameBuffer;\n> class MediaDevice;\n> +class PixelFormat;\n> class Request;\n> class Size;\n> +class SizeRange;\n> class V4L2Subdevice;\n> struct StreamConfiguration;\n> \n> @@ -33,6 +35,9 @@ public:\n> \tCIO2Device();\n> \t~CIO2Device();\n> \n> +\tstd::vector formats() const;\n> +\tstd::vector sizes() const;\n> +\n> \tint init(const MediaDevice *media, unsigned int index);\n> \tint configure(const Size &size, V4L2DeviceFormat *outputFormat);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2CDF6BD878\n\tfor ;\n\tThu, 30 Jul 2020 16:41:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A923561988;\n\tThu, 30 Jul 2020 18:41:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED36F611A2\n\tfor ;\n\tThu, 30 Jul 2020 18:40:58 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5B6FE9B1;\n\tThu, 30 Jul 2020 18:40:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gtPKwzMm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1596127258;\n\tbh=khtkp3fWdLQ3ub6myMVE6gdZNhqNxd1VQH5kTaE6cY4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gtPKwzMmIwJOIkxJb66DF3GzOYSEL4VotKIKqJKkNftUc3Vzkfu0cptgR95iw6wtG\n\tjt2cIxjjI05lDXtgXOjS9hanyF8nxgv09n55S0PyHbB7V406XOS/yP3rIXLHhS2Dao\n\tn1brt4na/sXhlSZM7TLiNRdLVyb3QOKAkfnytUps=","Date":"Thu, 30 Jul 2020 19:40:47 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200730164047.GC6107@pendragon.ideasonboard.com>","References":"<20200720104736.19986-1-jacopo@jmondi.org>\n\t<20200720104736.19986-7-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200720104736.19986-7-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v4 06/19] libcamera: ipu3: cio2:\n\tReport format and sizes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]