[{"id":11459,"web_url":"https://patchwork.libcamera.org/comment/11459/","msgid":"<20200721114607.GA1600405@oden.dyn.berto.se>","date":"2020-07-21T11:46:07","subject":"Re: [libcamera-devel] [PATCH v4 02/19] libcamera: utils: Add\n\talignUp and alignDown functions","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2020-07-20 12:47:19 +0200, Jacopo Mondi wrote:\n> Add to libcamera utils library two functions to round up or down a\n> value to an alignment and add a test in test/utils.cpp for the two\n> new functions.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/internal/utils.h | 10 ++++++++++\n> src/libcamera/utils.cpp | 16 ++++++++++++++++\n> test/utils.cpp | 11 +++++++++++\n> 3 files changed, 37 insertions(+)\n> \n> diff --git a/include/libcamera/internal/utils.h b/include/libcamera/internal/utils.h\n> index 8d026cc6c0fe..45cd6f120c51 100644\n> --- a/include/libcamera/internal/utils.h\n> +++ b/include/libcamera/internal/utils.h\n> @@ -200,6 +200,16 @@ details::StringSplitter split(const std::string &str, const std::string &delim);\n> std::string libcameraBuildPath();\n> std::string libcameraSourcePath();\n> \n> +constexpr unsigned int alignDown(unsigned int value, unsigned int alignment)\n> +{\n> +\treturn value / alignment * alignment;\n> +}\n> +\n> +constexpr unsigned int alignUp(unsigned int value, unsigned int alignment)\n> +{\n> +\treturn (value + alignment - 1) / alignment * alignment;\n> +}\n> +\n> } /* namespace utils */\n> \n> } /* namespace libcamera */\n> diff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\n> index 0567328fe31b..615df46ac142 100644\n> --- a/src/libcamera/utils.cpp\n> +++ b/src/libcamera/utils.cpp\n> @@ -444,6 +444,22 @@ std::string libcameraSourcePath()\n> \treturn path + \"/\";\n> }\n> \n> +/**\n> + * \\fn alignDown(unsigned int value, unsigned int alignment)\n> + * \\brief Align \\a value down to \\a alignment\n> + * \\param[in] value The value to align\n> + * \\param[in] alignment The alignment\n> + * \\return The value rounded down to the nearest multiple of \\a alignment\n> + */\n> +\n> +/**\n> + * \\fn alignUp(unsigned int value, unsigned int alignment)\n> + * \\brief Align \\a value up to \\a alignment\n> + * \\param[in] value The value to align\n> + * \\param[in] alignment The alignment\n> + * \\return The value rounded up to the nearest multiple of \\a alignment\n> + */\n> +\n> } /* namespace utils */\n> \n> } /* namespace libcamera */\n> diff --git a/test/utils.cpp b/test/utils.cpp\n> index f482e6a1d829..08f293898fd9 100644\n> --- a/test/utils.cpp\n> +++ b/test/utils.cpp\n> @@ -166,6 +166,17 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\t/* utils::alignUp() and utils::alignDown() tests. */\n> +\t\tif (utils::alignDown(6, 3) != 6 || utils::alignDown(7, 3) != 6) {\n> +\t\t\tcerr << \"utils::alignDown test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (utils::alignUp(6, 3) != 6 || utils::alignUp(7, 3) != 9) {\n> +\t\t\tcerr << \"utils::alignUp test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\treturn TestPass;\n> \t}\n> };\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5727BBD792\n\tfor ;\n\tTue, 21 Jul 2020 11:46:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B7D446087E;\n\tTue, 21 Jul 2020 13:46:11 +0200 (CEST)","from mail-lj1-x243.google.com (mail-lj1-x243.google.com\n\t[IPv6:2a00:1450:4864:20::243])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D885D60496\n\tfor ;\n\tTue, 21 Jul 2020 13:46:09 +0200 (CEST)","by mail-lj1-x243.google.com with SMTP id q7so23756923ljm.1\n\tfor ;\n\tTue, 21 Jul 2020 04:46:09 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tl1sm4326404ljc.65.2020.07.21.04.46.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 21 Jul 2020 04:46:08 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"e3lZ44BP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=GQNOIX5yR4aDVUWIPo0sXbFmnHlF82aSuT1TqCzztQ0=;\n\tb=e3lZ44BPijeC+VhA3+NHlYmMB+gC4rtFviZ3OJkniwmNRJAB3odpoVqLw3sGzSeKUe\n\tSHb/+MwmDIWz5Tu51iOezZW4vEwGc6bX7qxM/EEt/kT9+DRsjVUTcw7G4Tt5snpd9oHI\n\tuf9Q6QLq8N8au12d/GLVR0//LQRo4LF8HvrBuc1pYDaluFmD9lamUTMgKr9Fb84JAq6+\n\tRlli2X1mv/ME6qgA3Y4cCCy5+No1LFeSxxW8bj/z1QQ4KlpP+YLwCN7iozAeAMmdCMrb\n\tu60TYEqjxQWvE2utU4D8OngXuGTrmcZkssp4986TQ7JceJqMg+Of59TQaoc7JgYPnXfl\n\tuJ0A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=GQNOIX5yR4aDVUWIPo0sXbFmnHlF82aSuT1TqCzztQ0=;\n\tb=HUlLd9vY8w8kSll6nrrJZBeay+rTDIOutptCm5FluLwSmNXldVhgwqcfF6FmkIpDRp\n\to0YpTY52bljeEyv/ImCWBxqu2BRG/210T9DDRJ4D4HKzxIOh/bVVD47ICqfwHbzh3F5l\n\tCflin2hpIuLy8kmjXril0inXpZ9CExTKQEZLxI/ImazZK634xE2vfOX6lCtkgzTz8YjO\n\tf9cQtn/Pj2Zjyn1ZZkt+8/cK13+Uu5sgVgj6y/c5317WP2lWz7JfC+IWKxfPZ1/9TE95\n\tNmXFhuMxE1yTbF5iSfnCUCZVOJ1jX8MxqvwCUnxcK+oQIEjjs6AGShmXkAve0xTh0BZO\n\tZBNg==","X-Gm-Message-State":"AOAM532U90y6WU8YNUAUd4yleRs0qfCdgTun5w9fdX7Ai0SMZdFzoCBL\n\tTYGXLQ8c8ZPr+DUB44Id+S8GRDn40qg=","X-Google-Smtp-Source":"ABdhPJyn5TD03JbgoVcmZY4liEeO9tzGko3eKFKxQuyz07/NDeVFKMn9mJjiRWTVX8zY1t7aOBsSeQ==","X-Received":"by 2002:a2e:810e:: with SMTP id\n\td14mr11745756ljg.31.1595331968991; \n\tTue, 21 Jul 2020 04:46:08 -0700 (PDT)","Date":"Tue, 21 Jul 2020 13:46:07 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200721114607.GA1600405@oden.dyn.berto.se>","References":"<20200720104736.19986-1-jacopo@jmondi.org>\n\t<20200720104736.19986-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200720104736.19986-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v4 02/19] libcamera: utils: Add\n\talignUp and alignDown functions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11460,"web_url":"https://patchwork.libcamera.org/comment/11460/","msgid":"<433aa612-ed00-6d30-e1be-efa2d92a5d2e@ideasonboard.com>","date":"2020-07-21T11:59:13","subject":"Re: [libcamera-devel] [PATCH v4 02/19] libcamera: utils: Add\n\talignUp and alignDown functions","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 20/07/2020 11:47, Jacopo Mondi wrote:\n> Add to libcamera utils library two functions to round up or down a\n> value to an alignment and add a test in test/utils.cpp for the two\n> new functions.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nGiven that these introduce the two constexpr variants, I wonder if\n {constexpr , }Size::align{up,down}To()\n\nwould benefit from using these helpers to reduce duplication of the\ncalculation. I expect the compiler to appropriately inline the\nconstexpr's anyway...\n\nI think Laurent's previous response was that these are small and can\njust be separate, but that feels very un-dry now with 3 repeating\nimplementations of each of the up/down variants....\n\nStill, my point is, I think I do see value in this being in utils ;-)\n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/utils.h | 10 ++++++++++\n> src/libcamera/utils.cpp | 16 ++++++++++++++++\n> test/utils.cpp | 11 +++++++++++\n> 3 files changed, 37 insertions(+)\n> \n> diff --git a/include/libcamera/internal/utils.h b/include/libcamera/internal/utils.h\n> index 8d026cc6c0fe..45cd6f120c51 100644\n> --- a/include/libcamera/internal/utils.h\n> +++ b/include/libcamera/internal/utils.h\n> @@ -200,6 +200,16 @@ details::StringSplitter split(const std::string &str, const std::string &delim);\n> std::string libcameraBuildPath();\n> std::string libcameraSourcePath();\n> \n> +constexpr unsigned int alignDown(unsigned int value, unsigned int alignment)\n> +{\n> +\treturn value / alignment * alignment;\n> +}\n> +\n> +constexpr unsigned int alignUp(unsigned int value, unsigned int alignment)\n> +{\n> +\treturn (value + alignment - 1) / alignment * alignment;\n> +}\n> +\n> } /* namespace utils */\n> \n> } /* namespace libcamera */\n> diff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\n> index 0567328fe31b..615df46ac142 100644\n> --- a/src/libcamera/utils.cpp\n> +++ b/src/libcamera/utils.cpp\n> @@ -444,6 +444,22 @@ std::string libcameraSourcePath()\n> \treturn path + \"/\";\n> }\n> \n> +/**\n> + * \\fn alignDown(unsigned int value, unsigned int alignment)\n> + * \\brief Align \\a value down to \\a alignment\n> + * \\param[in] value The value to align\n> + * \\param[in] alignment The alignment\n> + * \\return The value rounded down to the nearest multiple of \\a alignment\n> + */\n> +\n> +/**\n> + * \\fn alignUp(unsigned int value, unsigned int alignment)\n> + * \\brief Align \\a value up to \\a alignment\n> + * \\param[in] value The value to align\n> + * \\param[in] alignment The alignment\n> + * \\return The value rounded up to the nearest multiple of \\a alignment\n> + */\n> +\n> } /* namespace utils */\n> \n> } /* namespace libcamera */\n> diff --git a/test/utils.cpp b/test/utils.cpp\n> index f482e6a1d829..08f293898fd9 100644\n> --- a/test/utils.cpp\n> +++ b/test/utils.cpp\n> @@ -166,6 +166,17 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n> \n> +\t\t/* utils::alignUp() and utils::alignDown() tests. */\n> +\t\tif (utils::alignDown(6, 3) != 6 || utils::alignDown(7, 3) != 6) {\n> +\t\t\tcerr << \"utils::alignDown test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (utils::alignUp(6, 3) != 6 || utils::alignUp(7, 3) != 9) {\n> +\t\t\tcerr << \"utils::alignUp test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> \t\treturn TestPass;\n> \t}\n> };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0588FC0109\n\tfor ;\n\tTue, 21 Jul 2020 11:59:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E37460832;\n\tTue, 21 Jul 2020 13:59:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5C2360496\n\tfor ;\n\tTue, 21 Jul 2020 13:59:16 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5904351A;\n\tTue, 21 Jul 2020 13:59:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BSiXnYmw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595332756;\n\tbh=W2mMQh8UrbL2tM/mDTSsyIPhtR1dn1IIhjOOIbQsgpE=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=BSiXnYmw0qd8PBYdJCNmaUDAOx/KMrtSDycggU3FOYs/Pn1gNf8D0FfxAoj5IgaZ/\n\td6/e7kZPK09uJeXqQKwaDk09kL+N7aJtiS2/1bZl/jVAIKujuB8PHpj7UjI45kgsXU\n\tqOfOF6GmmYMTtQz7JRQxcYYrDw8YdEMukLvuOhEg=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20200720104736.19986-1-jacopo@jmondi.org>\n\t<20200720104736.19986-3-jacopo@jmondi.org>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<433aa612-ed00-6d30-e1be-efa2d92a5d2e@ideasonboard.com>","Date":"Tue, 21 Jul 2020 12:59:13 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200720104736.19986-3-jacopo@jmondi.org>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v4 02/19] libcamera: utils: Add\n\talignUp and alignDown functions","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]