[{"id":11452,"web_url":"https://patchwork.libcamera.org/comment/11452/","msgid":"","date":"2020-07-21T11:13:58","subject":"Re: [libcamera-devel] [PATCH v4 7/9] libcamera: pipeline:\n\traspberrypi: Fix bug in passing configuration to IPA","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 20/07/2020 10:13, Naushir Patuck wrote:\n> The counter was not incremented, so multiple streams would only pass the\n> last stream config to the IPA.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: Niklas Söderlund \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index dbc22521..c28fe997 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -976,14 +976,14 @@ int RPiCameraData::configureIPA()\n> \tunicam_[Unicam::Image].dev()->getFormat(&sensorFormat);\n> \t/* Inform IPA of stream configuration and sensor controls. */\n> \tunsigned int i = 0;\n> -\tfor (auto const &stream : isp_) {\n> +\tfor (auto const &stream : isp_)\n> \t\tif (stream.isExternal()) {\n> -\t\t\tstreamConfig[i] = {\n> +\t\t\tstreamConfig[i++] = {\n> \t\t\t\t.pixelFormat = stream.configuration().pixelFormat,\n> \t\t\t\t.size = stream.configuration().size\n> \t\t\t};\n> \t\t}\n> -\t}\n> +\n\nHrm, I would have probably kept the outer scope braces on the for loop,\nit only has a single scope statement, but it's more complex than a\nsingle line.\n\nNot sure if we have a defined rule on this for style, but I don't object\nanyway...\n\n\n> \tentityControls.emplace(0, unicam_[Unicam::Image].dev()->controls());\n> \tentityControls.emplace(1, isp_[Isp::Input].dev()->controls());\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93928BD792\n\tfor ;\n\tTue, 21 Jul 2020 11:14:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 09DCC6087E;\n\tTue, 21 Jul 2020 13:14:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2150560496\n\tfor ;\n\tTue, 21 Jul 2020 13:14:02 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8BE8251A;\n\tTue, 21 Jul 2020 13:14:01 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hckl/G1Z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595330041;\n\tbh=RIhPVwMT79eVtSirs+tjqN5U3e9POvOpDL+DlVkYd2o=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=hckl/G1ZmJ4BYdgJDTNtOReYC0eRNiYdtTNkSEWcRCO5spazOlyXrvxBu55ngbWdY\n\tyn3VBarL888CUhujK8qjABU4fQGcvkLTjBlfH4H3eCYV+5xQlqXp59Kyzq8Xo+EnU9\n\tmNRTMd5O7oy9Zgo/6vMdvjmya4ZC0rnipvFs/cbY=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200720091311.805092-1-naush@raspberrypi.com>\n\t<20200720091311.805092-8-naush@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 21 Jul 2020 12:13:58 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200720091311.805092-8-naush@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v4 7/9] libcamera: pipeline:\n\traspberrypi: Fix bug in passing configuration to IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11473,"web_url":"https://patchwork.libcamera.org/comment/11473/","msgid":"","date":"2020-07-22T07:54:41","subject":"Re: [libcamera-devel] [PATCH v4 7/9] libcamera: pipeline:\n\traspberrypi: Fix bug in passing configuration to IPA","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nOn Tue, 21 Jul 2020 at 12:14, Kieran Bingham\n wrote:\n>\n> Hi Naush,\n>\n> On 20/07/2020 10:13, Naushir Patuck wrote:\n> > The counter was not incremented, so multiple streams would only pass the\n> > last stream config to the IPA.\n> >\n> > Signed-off-by: Naushir Patuck \n> > Reviewed-by: Niklas Söderlund \n>\n> Reviewed-by: Kieran Bingham \n>\n> > ---\n> > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 +++---\n> > 1 file changed, 3 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > index dbc22521..c28fe997 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > @@ -976,14 +976,14 @@ int RPiCameraData::configureIPA()\n> > unicam_[Unicam::Image].dev()->getFormat(&sensorFormat);\n> > /* Inform IPA of stream configuration and sensor controls. */\n> > unsigned int i = 0;\n> > - for (auto const &stream : isp_) {\n> > + for (auto const &stream : isp_)\n> > if (stream.isExternal()) {\n> > - streamConfig[i] = {\n> > + streamConfig[i++] = {\n> > .pixelFormat = stream.configuration().pixelFormat,\n> > .size = stream.configuration().size\n> > };\n> > }\n> > - }\n> > +\n>\n> Hrm, I would have probably kept the outer scope braces on the for loop,\n> it only has a single scope statement, but it's more complex than a\n> single line.\n>\n> Not sure if we have a defined rule on this for style, but I don't object\n> anyway...\n\nWas not sure what the accepted format was. I will likely submit a new\nversion of the patchset, so will add back the outer scope brackets.\n\nRegards,\nNaush\n\n\n>\n>\n> > entityControls.emplace(0, unicam_[Unicam::Image].dev()->controls());\n> > entityControls.emplace(1, isp_[Isp::Input].dev()->controls());\n> >\n> >\n>\n> --\n> Regards\n> --\n> Kieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3855EBDB1B\n\tfor ;\n\tWed, 22 Jul 2020 07:55:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 06D2960943;\n\tWed, 22 Jul 2020 09:55:00 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 829FE60540\n\tfor ;\n\tWed, 22 Jul 2020 09:54:58 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id q6so1479765ljp.4\n\tfor ;\n\tWed, 22 Jul 2020 00:54:58 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"mJnLFY3K\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=xonNRnEbtWYt7PeXNrGF+8pRpfLTwkv/+Tc7wViu1bc=;\n\tb=mJnLFY3KTokIanLP+yvpISPDvh6txk1YKW8StINE4J+b8QhuDvcdn+eO04WZtauTqS\n\tVjfObBlcIUZKUTArltkSR6uru0qHyOqFjhzK8OBat68iul0cjD/EI2IwTb00hFxwJlMC\n\twMmTDDG7HuPWQkj9PrbVbJESqDOPpfveA/SeExnjEjMioOEw0tDd/xZG9tIBt48W9tg2\n\tan6PeS9jku0iDRV5mUMYHk/mpKl/ZgujAQBxNbtW+BC4B1z9l75wWWnWYZJGI6BQmRYr\n\tpo0vr5Q/kqpuftlaBeezw3G+m6DmHi7KOCNJAMgZ1V6bvDvB5izGk1jMn5y/QTbFEVAs\n\tXVFg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=xonNRnEbtWYt7PeXNrGF+8pRpfLTwkv/+Tc7wViu1bc=;\n\tb=aZtvM5njGYispFL+RrSXwQqR3k2U8BrYpI73DkDRDhonrJKU/nQfgShycf1iAqx0dj\n\tkizseSSZNrzP2w5CBZYDP9rJ+BVntTeL/jcHtAH/99uQyu4d8qD5ojpscmydObLKToiR\n\tItNC4aF16ENWxn3jenLPDxbJc4LO3OoUKVXJaGzfEieJ3WoGVEIcWDKHBZounhiUTMGf\n\tP7BIjai+O/0Evy6I9Yp/t63rFXI+9aI2661TKBgMhC1Er3WP7E2YvH3DqUC3RfdxqwYy\n\tX04NRx82fapA4Rnkmj1DtnfLlNc8yYrdDJ4gaJ1TIWHGl4M6ulZ9jkZQl1bweMbS7ZMs\n\tjpUg==","X-Gm-Message-State":"AOAM532SsQTKupPv6HQctdXk+TVX1VLrPoM0GxKTXg/x6yaPe5yC0Lg4\n\tqcGj5n4CqlPtkWBrltBODTEdu1/k5DdD0H3lhvLuPg==","X-Google-Smtp-Source":"ABdhPJxgUCsEWnl2Wj9IRL9yDJiTaa6LW3cauqtm6dnTdl58Afy27Wn8FL15uFIvuWetLRiOg86waxWQj8Mo+uvfoTs=","X-Received":"by 2002:a2e:a30f:: with SMTP id\n\tl15mr14489442lje.228.1595404497904; \n\tWed, 22 Jul 2020 00:54:57 -0700 (PDT)","MIME-Version":"1.0","References":"<20200720091311.805092-1-naush@raspberrypi.com>\n\t<20200720091311.805092-8-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Wed, 22 Jul 2020 08:54:41 +0100","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH v4 7/9] libcamera: pipeline:\n\traspberrypi: Fix bug in passing configuration to IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11507,"web_url":"https://patchwork.libcamera.org/comment/11507/","msgid":"<20200722153228.GI29813@pendragon.ideasonboard.com>","date":"2020-07-22T15:32:28","subject":"Re: [libcamera-devel] [PATCH v4 7/9] libcamera: pipeline:\n\traspberrypi: Fix bug in passing configuration to IPA","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Wed, Jul 22, 2020 at 08:54:41AM +0100, Naushir Patuck wrote:\n> On Tue, 21 Jul 2020 at 12:14, Kieran Bingham wrote:\n> > On 20/07/2020 10:13, Naushir Patuck wrote:\n> > > The counter was not incremented, so multiple streams would only pass the\n> > > last stream config to the IPA.\n> > >\n> > > Signed-off-by: Naushir Patuck \n> > > Reviewed-by: Niklas Söderlund \n> >\n> > Reviewed-by: Kieran Bingham \n> >\n> > > ---\n> > > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 +++---\n> > > 1 file changed, 3 insertions(+), 3 deletions(-)\n> > >\n> > > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > > index dbc22521..c28fe997 100644\n> > > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > > @@ -976,14 +976,14 @@ int RPiCameraData::configureIPA()\n> > > unicam_[Unicam::Image].dev()->getFormat(&sensorFormat);\n> > > /* Inform IPA of stream configuration and sensor controls. */\n> > > unsigned int i = 0;\n> > > - for (auto const &stream : isp_) {\n> > > + for (auto const &stream : isp_)\n> > > if (stream.isExternal()) {\n> > > - streamConfig[i] = {\n> > > + streamConfig[i++] = {\n> > > .pixelFormat = stream.configuration().pixelFormat,\n> > > .size = stream.configuration().size\n> > > };\n> > > }\n> > > - }\n> > > +\n> >\n> > Hrm, I would have probably kept the outer scope braces on the for loop,\n> > it only has a single scope statement, but it's more complex than a\n> > single line.\n> >\n> > Not sure if we have a defined rule on this for style, but I don't object\n> > anyway...\n> \n> Was not sure what the accepted format was. I will likely submit a new\n> version of the patchset, so will add back the outer scope brackets.\n\nYes, that's the preferred style.\n\nReviewed-by: Laurent Pinchart \n\nEven though it likely won't make much of a difference, as the IPA\ndoesn't seem to use streamConfig :-)\n\n> > > entityControls.emplace(0, unicam_[Unicam::Image].dev()->controls());\n> > > entityControls.emplace(1, isp_[Isp::Input].dev()->controls());\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BF03FBDB1B\n\tfor ;\n\tWed, 22 Jul 2020 15:32:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3207A6099C;\n\tWed, 22 Jul 2020 17:32:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C15260540\n\tfor ;\n\tWed, 22 Jul 2020 17:32:37 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6035D329;\n\tWed, 22 Jul 2020 17:32:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gTg1jfjH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595431953;\n\tbh=EA8O5KQIbkPi9FgQ17wjHP5rX02kOcUfl35V5v2FdRk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gTg1jfjHU1lGCrN5bWZxLJDrd4jcv9MA8rskeRy9Pxgzs9s5eJ9EMRdxaAjDrODy1\n\tvYE8AZbMmxv74wPBNufQB/TWrgcFN5R6H+YTP1Wl0XkAJtWLIj80oyK8mbLIMlihDn\n\t1/K5yajwZ685ah6tqfxgg+ggXyVZV8fNN8W4ykaM=","Date":"Wed, 22 Jul 2020 18:32:28 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"<20200722153228.GI29813@pendragon.ideasonboard.com>","References":"<20200720091311.805092-1-naush@raspberrypi.com>\n\t<20200720091311.805092-8-naush@raspberrypi.com>\n\t\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v4 7/9] libcamera: pipeline:\n\traspberrypi: Fix bug in passing configuration to IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]