[{"id":11450,"web_url":"https://patchwork.libcamera.org/comment/11450/","msgid":"","date":"2020-07-21T11:09:25","subject":"Re: [libcamera-devel] [PATCH v4 3/9] libcamera: pipeline:\n\traspberrypi: Add some debug logging","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 20/07/2020 10:13, Naushir Patuck wrote:\n> No functional changes, only added some more trace points.\n\nWell, that could be classed as a form of a functional change, At least\nthat's what Dr Heisenbug told me ... :-D\n\n> Signed-off-by: Naushir Patuck \n> Reviewed-by: Niklas Söderlund \n\nStill, this looks fine to me:\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index d3639ce1..35f14dda 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1160,6 +1160,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n> \tif (state_ == State::Stopped)\n> \t\treturn;\n> \n> +\tLOG(RPI, Debug) << \"Stream ISP Input buffer complete\"\n> +\t\t\t<< \", buffer id \" << buffer->cookie()\n> +\t\t\t<< \", timestamp: \" << buffer->metadata().timestamp;\n> +\n> +\t/* The ISP input buffer gets re-queued into Unicam. */\n> \thandleStreamBuffer(buffer, &unicam_[Unicam::Image]);\n> \thandleState();\n> }\n> @@ -1324,6 +1329,8 @@ void RPiCameraData::checkRequestCompleted()\n> \t\tpipe_->completeRequest(camera_, request);\n> \t\trequestQueue_.pop_front();\n> \t\trequestCompleted = true;\n> +\n> +\t\tLOG(RPI, Debug) << \"Request is complete\";\n> \t}\n> \n> \t/*\n> @@ -1462,7 +1469,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t\n> \t\tif (b->metadata().timestamp < timestamp) {\n> \t\t\tq.pop();\n> \t\t\tdev->queueBuffer(b);\n> -\t\t\tLOG(RPI, Error) << \"Dropping input frame!\";\n> +\t\t\tLOG(RPI, Warning) << \"Dropping input frame!\";\n> \t\t} else if (b->metadata().timestamp == timestamp) {\n> \t\t\t/* The calling function will pop the item from the queue. */\n> \t\t\treturn b;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 439D6C0109\n\tfor ;\n\tTue, 21 Jul 2020 11:09:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0F3A60832;\n\tTue, 21 Jul 2020 13:09:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D9E3960496\n\tfor ;\n\tTue, 21 Jul 2020 13:09:28 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 57DDD51A;\n\tTue, 21 Jul 2020 13:09:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HX0bg41h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595329768;\n\tbh=N/+y/PbHUnbaTcBMesCiEVlb/ARSckp8j4IkQ2U0hi8=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=HX0bg41huX94HG42kJixliA3QTd55NwUKcUXDOoQS3iDArYdjrXf6Ah7298fOzZjn\n\tQmdxgjuLlXhe0fou7exnct/fxMB3l+OKYmtW+VgY67d7W4vtYZBs2GIf2pYqNRZrzA\n\tAtTM4elnbKd/6D+MhQIC3bu5tIjVAH42dfRT0CSU=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200720091311.805092-1-naush@raspberrypi.com>\n\t<20200720091311.805092-4-naush@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 21 Jul 2020 12:09:25 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200720091311.805092-4-naush@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v4 3/9] libcamera: pipeline:\n\traspberrypi: Add some debug logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11502,"web_url":"https://patchwork.libcamera.org/comment/11502/","msgid":"<20200722145830.GE29813@pendragon.ideasonboard.com>","date":"2020-07-22T14:58:30","subject":"Re: [libcamera-devel] [PATCH v4 3/9] libcamera: pipeline:\n\traspberrypi: Add some debug logging","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Jul 20, 2020 at 10:13:05AM +0100, Naushir Patuck wrote:\n> No functional changes, only added some more trace points.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: Niklas Söderlund \n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index d3639ce1..35f14dda 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1160,6 +1160,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n> \tif (state_ == State::Stopped)\n> \t\treturn;\n> \n> +\tLOG(RPI, Debug) << \"Stream ISP Input buffer complete\"\n\nDid you mean s/Stream ISP/ISP/ ?\n\n> +\t\t\t<< \", buffer id \" << buffer->cookie()\n\nMaybe s/id/cookie/ ?\n\n> +\t\t\t<< \", timestamp: \" << buffer->metadata().timestamp;\n> +\n> +\t/* The ISP input buffer gets re-queued into Unicam. */\n> \thandleStreamBuffer(buffer, &unicam_[Unicam::Image]);\n> \thandleState();\n> }\n> @@ -1324,6 +1329,8 @@ void RPiCameraData::checkRequestCompleted()\n> \t\tpipe_->completeRequest(camera_, request);\n> \t\trequestQueue_.pop_front();\n> \t\trequestCompleted = true;\n> +\n> +\t\tLOG(RPI, Debug) << \"Request is complete\";\n\nWould it make sense to add this to Request::complete() instead ? And\nmaybe print the request cookie ?\n\n> \t}\n> \n> \t/*\n> @@ -1462,7 +1469,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t\n> \t\tif (b->metadata().timestamp < timestamp) {\n> \t\t\tq.pop();\n> \t\t\tdev->queueBuffer(b);\n> -\t\t\tLOG(RPI, Error) << \"Dropping input frame!\";\n> +\t\t\tLOG(RPI, Warning) << \"Dropping input frame!\";\n> \t\t} else if (b->metadata().timestamp == timestamp) {\n> \t\t\t/* The calling function will pop the item from the queue. */\n> \t\t\treturn b;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D68A5BDB1B\n\tfor ;\n\tWed, 22 Jul 2020 14:58:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66BDE60948;\n\tWed, 22 Jul 2020 16:58:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C66EA6039F\n\tfor ;\n\tWed, 22 Jul 2020 16:58:35 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F0DA329;\n\tWed, 22 Jul 2020 16:58:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CSq1j1W7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595429915;\n\tbh=quQV6FqcruqikOIU2oytRSky++Vxrkgy86uCcT2+/gQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CSq1j1W7Q/ykiXKHIf8KzogUvMKrlGTcBdNfqVOGRmvgZlDaTSpxRo4nTuzAnnjM4\n\tLOoSPdUlc0gmUed6UzEAccfdd/N9H3X6ITeBSInMlPvgcDxKXLGep2C+ABV8U44mLV\n\tgdRzzHiFjy1CD/z3Q05JIYxb4RhYKYWLDqm4zvuQ=","Date":"Wed, 22 Jul 2020 17:58:30 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"<20200722145830.GE29813@pendragon.ideasonboard.com>","References":"<20200720091311.805092-1-naush@raspberrypi.com>\n\t<20200720091311.805092-4-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200720091311.805092-4-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v4 3/9] libcamera: pipeline:\n\traspberrypi: Add some debug logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11505,"web_url":"https://patchwork.libcamera.org/comment/11505/","msgid":"","date":"2020-07-22T15:18:29","subject":"Re: [libcamera-devel] [PATCH v4 3/9] libcamera: pipeline:\n\traspberrypi: Add some debug logging","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nThank you for the review.\n\nOn Wed, 22 Jul 2020 at 15:58, Laurent Pinchart\n wrote:\n>\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Mon, Jul 20, 2020 at 10:13:05AM +0100, Naushir Patuck wrote:\n> > No functional changes, only added some more trace points.\n> >\n> > Signed-off-by: Naushir Patuck \n> > Reviewed-by: Niklas Söderlund \n> > ---\n> > src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++++-\n> > 1 file changed, 8 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > index d3639ce1..35f14dda 100644\n> > --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> > @@ -1160,6 +1160,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n> > if (state_ == State::Stopped)\n> > return;\n> >\n> > + LOG(RPI, Debug) << \"Stream ISP Input buffer complete\"\n>\n> Did you mean s/Stream ISP/ISP/ ?\n\nI did mean to use the stream qualifier, in order to be consistent with\nthe other log points in ispOutputDequeue() and unicamBufferDequeue().\n\n>\n> > + << \", buffer id \" << buffer->cookie()\n>\n> Maybe s/id/cookie/ ?\n\nPossibly, but see patch 9/9. We stop using buffer->cookie() entirely,\nso id will be the right term eventually :-)\n\n>\n> > + << \", timestamp: \" << buffer->metadata().timestamp;\n> > +\n> > + /* The ISP input buffer gets re-queued into Unicam. */\n> > handleStreamBuffer(buffer, &unicam_[Unicam::Image]);\n> > handleState();\n> > }\n> > @@ -1324,6 +1329,8 @@ void RPiCameraData::checkRequestCompleted()\n> > pipe_->completeRequest(camera_, request);\n> > requestQueue_.pop_front();\n> > requestCompleted = true;\n> > +\n> > + LOG(RPI, Debug) << \"Request is complete\";\n>\n> Would it make sense to add this to Request::complete() instead ? And\n> maybe print the request cookie ?\n\nSure, I can add a log point in Request::complete() to replace this one.\n\n>\n> > }\n> >\n> > /*\n> > @@ -1462,7 +1469,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t\n> > if (b->metadata().timestamp < timestamp) {\n> > q.pop();\n> > dev->queueBuffer(b);\n> > - LOG(RPI, Error) << \"Dropping input frame!\";\n> > + LOG(RPI, Warning) << \"Dropping input frame!\";\n> > } else if (b->metadata().timestamp == timestamp) {\n> > /* The calling function will pop the item from the queue. */\n> > return b;\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n\nRegards,\nNaush","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B18F0BDB1B\n\tfor ;\n\tWed, 22 Jul 2020 15:18:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41ADA60948;\n\tWed, 22 Jul 2020 17:18:48 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B86116039F\n\tfor ;\n\tWed, 22 Jul 2020 17:18:46 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id x9so2907756ljc.5\n\tfor ;\n\tWed, 22 Jul 2020 08:18:46 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"iFNDEWj+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=uAdHyCPaucYbO5QtVq9zw/wC/iPjviQbssKVpPD8psk=;\n\tb=iFNDEWj+VdE7mlh8cuwcTqQkFRTzi6lZwq3htpwlZtLw8MPjaZR6srocDGagWqef5c\n\tBhM7E+lXufukxKIFFR0lq2LhDMgyuowdI3HVRFSMGOHN5ik5yMenKpvLlte+RfMtjXSb\n\tFqewqazgF/XUbYheg9tBtKntia0pkqQc6ehfSVCErYEy4hwAzzdcvNIO6cSM0OvjeKUH\n\tO2bVw/Hp75RXxIjN9LwD2aYWhVyNvWbjmxi6J5X4YwSPz7KYBXh9Vi90YVHFRyg5twu8\n\tilxA5fcZWpoh682nMJK3RSJac6Deg4nT+33yHN67YI2I97yktEGsX6HWZYhDxsex91vN\n\tdmBw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=uAdHyCPaucYbO5QtVq9zw/wC/iPjviQbssKVpPD8psk=;\n\tb=o459AhIZcGYpe7WHho/BllVvx7UoEJHsxtKtE/aRTsTCorvIF6Sc6MjA+5V7vdc6t2\n\twXt/yTEVCaKFCm8JmqiRiXxDovvE/FIwXbxc24ASSOabzed9f8sGrnxDY+LKzUsGp+7p\n\tshtWbG/BUJVdPR3E2PWr02MtVXyjzDLfEMR2q39MlBJ0w8Piy/lvPysJeM/Gshhrd9WX\n\toZTMaliWUW4DflG7wAgW9LG6P+AlGoTQebnJolVjmxySefprXXH5Ou/N/Z7qlVSVRAuX\n\thhKlI4omhTJa1pPMtEZLpIxm/8STK3jCTSKwjBRpDbqU9gCZG6hAYP+2kedmQSm3ltXQ\n\tXDSg==","X-Gm-Message-State":"AOAM532a/CwLeWMRimH5bFkAgydVwAUSJyUiV+kXD4O2OVqz8ZZIWc0u\n\ta9JmHQ/9pRDY5TvkccAXRPDYsNMrrW4GwGGQod8xz4ZLQZM=","X-Google-Smtp-Source":"ABdhPJz+9f5XAOLqKztHCjLDJ25zWi6WGLriRpUFE2y7QMlIW/Vodny0IMsRxZshD4SsQ41i8epBtVoO7RZizN3fWK0=","X-Received":"by 2002:a2e:9dcc:: with SMTP id\n\tx12mr14994898ljj.415.1595431126044; \n\tWed, 22 Jul 2020 08:18:46 -0700 (PDT)","MIME-Version":"1.0","References":"<20200720091311.805092-1-naush@raspberrypi.com>\n\t<20200720091311.805092-4-naush@raspberrypi.com>\n\t<20200722145830.GE29813@pendragon.ideasonboard.com>","In-Reply-To":"<20200722145830.GE29813@pendragon.ideasonboard.com>","From":"Naushir Patuck ","Date":"Wed, 22 Jul 2020 16:18:29 +0100","Message-ID":"","To":"Laurent Pinchart ","Subject":"Re: [libcamera-devel] [PATCH v4 3/9] libcamera: pipeline:\n\traspberrypi: Add some debug logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]