{"id":8865,"url":"https://patchwork.libcamera.org/api/patches/8865/?format=json","web_url":"https://patchwork.libcamera.org/patch/8865/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200720091311.805092-4-naush@raspberrypi.com>","date":"2020-07-20T09:13:05","name":"[libcamera-devel,v4,3/9] libcamera: pipeline: raspberrypi: Add some debug logging","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6556ae99126d7e5905142182ad841022458d4870","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8865/mbox/","series":[{"id":1117,"url":"https://patchwork.libcamera.org/api/series/1117/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1117","date":"2020-07-20T09:13:02","name":"Zero-copy RAW stream work","version":4,"mbox":"https://patchwork.libcamera.org/series/1117/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8865/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8865/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C57FC2E67\n\tfor ;\n\tMon, 20 Jul 2020 09:13:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4AFC860724;\n\tMon, 20 Jul 2020 11:13:32 +0200 (CEST)","from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0BB8A60554\n\tfor ;\n\tMon, 20 Jul 2020 11:13:30 +0200 (CEST)","by mail-wm1-x343.google.com with SMTP id j18so21509730wmi.3\n\tfor ;\n\tMon, 20 Jul 2020 02:13:30 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tu1sm38137185wrb.78.2020.07.20.02.13.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 20 Jul 2020 02:13:28 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"hMsxiGef\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=h2usrW3kOg/PwxnrQi+Bi9R18693ZRttLpAYPr1ayMA=;\n\tb=hMsxiGefJL63ssdh0NoTVjQT6h80uttSozroJAHfsBNVzlO7TCsBP5qz/BXJ7I95TQ\n\tUPKqroXUOQe+pQxdhFg6D6zmpNr/SkBo3GTwBPuJcBym3JBM6gdntPZFnx6PWekzA2L5\n\tc+wsIMh1WRAs5DcuswPhu+mIXirvVTd2iVcJxPFyst4BGPCDh7D1kCkTwLtuDeb6CokP\n\tnyGoJ98oquz8iWFDFvBo2HKq+nak2uFaUfjgpJsYC13KreRejNq5xt+YRhrAO3ZX1mpH\n\t0VzEk+dFhauJ97reHSjcABeMzCG/R/WajPjPlhTj1tmCoNf6QrPNCcIWTsIppPoztxv7\n\tY+Tg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=h2usrW3kOg/PwxnrQi+Bi9R18693ZRttLpAYPr1ayMA=;\n\tb=aqPV63x4RnLDyR9McmN9yBb7dH0vuEvKisGQrAoFSkqBAn7wBhvoLMAUwQBWzVcIFq\n\tYoPMxV4+1lddDusOdLo96D3Vz8BCGC7PQQ1U+tp8VhQIfrFuX+FZGkJYzglDjB3/imIE\n\tp2rNpuVTc4ZjFeSz7iekPF4tVx4LeTL0tByyuPg+BxuQQ+6KDwv2L85OxmrY3gR1g5Ta\n\trDFh1VWU0Nf+C3RFub2233nrIL6jaKfea5o6/GVhAmWRpM6UxxyFJZwruFQs0obnvWhS\n\tTLHIQI0MvdzELn6rR/PaPC6/53lh4fQMunPqk9OwSGWNMumr0ZNzHFlUwUNV+X17ufqH\n\t9fPg==","X-Gm-Message-State":"AOAM533RaRXQJhH9D0yK/FThHAuMuzeyGv+hJg6nPCH43mFVrl2pc1VA\n\tjkD66D64XMKPmy71XpPej7nJh6qecvgIIQ==","X-Google-Smtp-Source":"ABdhPJyctXnzSXmxW85EZyjXMqMxwnKbTYrV+vitzMgCsGQFBywK+tGm0D8hptqwIrEXqvabMk5Y4w==","X-Received":"by 2002:a1c:a181:: with SMTP id\n\tk123mr20861498wme.172.1595236409429; \n\tMon, 20 Jul 2020 02:13:29 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 20 Jul 2020 10:13:05 +0100","Message-Id":"<20200720091311.805092-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200720091311.805092-1-naush@raspberrypi.com>","References":"<20200720091311.805092-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 3/9] libcamera: pipeline: raspberrypi:\n\tAdd some debug logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"No functional changes, only added some more trace points.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Niklas Söderlund \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex d3639ce1..35f14dda 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -1160,6 +1160,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \tif (state_ == State::Stopped)\n \t\treturn;\n \n+\tLOG(RPI, Debug) << \"Stream ISP Input buffer complete\"\n+\t\t\t<< \", buffer id \" << buffer->cookie()\n+\t\t\t<< \", timestamp: \" << buffer->metadata().timestamp;\n+\n+\t/* The ISP input buffer gets re-queued into Unicam. */\n \thandleStreamBuffer(buffer, &unicam_[Unicam::Image]);\n \thandleState();\n }\n@@ -1324,6 +1329,8 @@ void RPiCameraData::checkRequestCompleted()\n \t\tpipe_->completeRequest(camera_, request);\n \t\trequestQueue_.pop_front();\n \t\trequestCompleted = true;\n+\n+\t\tLOG(RPI, Debug) << \"Request is complete\";\n \t}\n \n \t/*\n@@ -1462,7 +1469,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t\n \t\tif (b->metadata().timestamp < timestamp) {\n \t\t\tq.pop();\n \t\t\tdev->queueBuffer(b);\n-\t\t\tLOG(RPI, Error) << \"Dropping input frame!\";\n+\t\t\tLOG(RPI, Warning) << \"Dropping input frame!\";\n \t\t} else if (b->metadata().timestamp == timestamp) {\n \t\t\t/* The calling function will pop the item from the queue. */\n \t\t\treturn b;\n","prefixes":["libcamera-devel","v4","3/9"]}