[{"id":11433,"web_url":"https://patchwork.libcamera.org/comment/11433/","msgid":"<20200720080317.hjylqt5n7fphujki@uno.localdomain>","date":"2020-07-20T08:03:17","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add support for RGB565\n\tformat","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Sat, Jul 18, 2020 at 04:34:28PM +0200, Niklas Söderlund wrote:\n> Add support for RGB565 format.\n>\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/formats.cpp | 10 ++++++++++\n> src/libcamera/formats.yaml | 3 +++\n> src/libcamera/v4l2_pixelformat.cpp | 1 +\n> 3 files changed, 14 insertions(+)\n>\n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 8f9bdafe821b2e69..af3996c954ae1457 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -233,6 +233,16 @@ const PixelFormatInfo pixelFormatInfoInvalid{};\n>\n> const std::map pixelFormatInfo{\n> \t/* RGB formats. */\n> +\t{ formats::RGB565, {\n> +\t\t.name = \"RGB565\",\n> +\t\t.format = formats::RGB565,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_RGB565),\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 1,\n> +\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n> \t{ formats::BGR888, {\n> \t\t.name = \"BGR888\",\n> \t\t.format = formats::BGR888,\n> diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\n> index 6b5f084bb2e4e970..3a69c05fcc04fb93 100644\n> --- a/src/libcamera/formats.yaml\n> +++ b/src/libcamera/formats.yaml\n> @@ -8,6 +8,9 @@ formats:\n> - R8:\n> fourcc: DRM_FORMAT_R8\n>\n> + - RGB565:\n> + fourcc: DRM_FORMAT_RGB565\n> +\n> - RGB888:\n> fourcc: DRM_FORMAT_RGB888\n> - BGR888:\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 1609f8bb6370fa65..9799d389e20b358d 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -45,6 +45,7 @@ namespace {\n>\n> const std::map vpf2pf{\n> \t/* RGB formats. */\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB565), formats::RGB565 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n\nShould RGB5 come after RGB2 ?\n\nThat apart\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EBE42BD792\n\tfor ;\n\tMon, 20 Jul 2020 07:59:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 543EA605A8;\n\tMon, 20 Jul 2020 09:59:46 +0200 (CEST)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E0CD6039E\n\tfor ;\n\tMon, 20 Jul 2020 09:59:45 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 06B752000D;\n\tMon, 20 Jul 2020 07:59:43 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Mon, 20 Jul 2020 10:03:17 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200720080317.hjylqt5n7fphujki@uno.localdomain>","References":"<20200718143428.1060441-1-niklas.soderlund@ragnatech.se>\n\t<20200718143428.1060441-3-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200718143428.1060441-3-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add support for RGB565\n\tformat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11436,"web_url":"https://patchwork.libcamera.org/comment/11436/","msgid":"<20200720082015.GC576734@oden.dyn.berto.se>","date":"2020-07-20T08:20:15","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add support for RGB565\n\tformat","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your feedback.\n\nOn 2020-07-20 10:03:17 +0200, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Sat, Jul 18, 2020 at 04:34:28PM +0200, Niklas Söderlund wrote:\n> > Add support for RGB565 format.\n> >\n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/libcamera/formats.cpp | 10 ++++++++++\n> > src/libcamera/formats.yaml | 3 +++\n> > src/libcamera/v4l2_pixelformat.cpp | 1 +\n> > 3 files changed, 14 insertions(+)\n> >\n> > diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> > index 8f9bdafe821b2e69..af3996c954ae1457 100644\n> > --- a/src/libcamera/formats.cpp\n> > +++ b/src/libcamera/formats.cpp\n> > @@ -233,6 +233,16 @@ const PixelFormatInfo pixelFormatInfoInvalid{};\n> >\n> > const std::map pixelFormatInfo{\n> > \t/* RGB formats. */\n> > +\t{ formats::RGB565, {\n> > +\t\t.name = \"RGB565\",\n> > +\t\t.format = formats::RGB565,\n> > +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_RGB565),\n> > +\t\t.bitsPerPixel = 16,\n> > +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > +\t\t.packed = false,\n> > +\t\t.pixelsPerGroup = 1,\n> > +\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> > +\t} },\n> > \t{ formats::BGR888, {\n> > \t\t.name = \"BGR888\",\n> > \t\t.format = formats::BGR888,\n> > diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\n> > index 6b5f084bb2e4e970..3a69c05fcc04fb93 100644\n> > --- a/src/libcamera/formats.yaml\n> > +++ b/src/libcamera/formats.yaml\n> > @@ -8,6 +8,9 @@ formats:\n> > - R8:\n> > fourcc: DRM_FORMAT_R8\n> >\n> > + - RGB565:\n> > + fourcc: DRM_FORMAT_RGB565\n> > +\n> > - RGB888:\n> > fourcc: DRM_FORMAT_RGB888\n> > - BGR888:\n> > diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> > index 1609f8bb6370fa65..9799d389e20b358d 100644\n> > --- a/src/libcamera/v4l2_pixelformat.cpp\n> > +++ b/src/libcamera/v4l2_pixelformat.cpp\n> > @@ -45,6 +45,7 @@ namespace {\n> >\n> > const std::map vpf2pf{\n> > \t/* RGB formats. */\n> > +\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB565), formats::RGB565 },\n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n> \n> Should RGB5 come after RGB2 ?\n\nI kept the same sorting order as videodev2.h, I'm open to define a \ndifferent sorting order here tho. What do you think?\n\n> \n> That apart\n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n> \n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n> > \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n> > --\n> > 2.27.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1D083BD792\n\tfor ;\n\tMon, 20 Jul 2020 08:20:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A10F3605A8;\n\tMon, 20 Jul 2020 10:20:18 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C77A06039E\n\tfor ;\n\tMon, 20 Jul 2020 10:20:17 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id f5so19241543ljj.10\n\tfor ;\n\tMon, 20 Jul 2020 01:20:17 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tc14sm3093335ljj.112.2020.07.20.01.20.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 20 Jul 2020 01:20:16 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"iCA3LZur\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=XgMBlRLizpQH831KrtoT2I5Gz5kAD6Yzy/ReuN8Z7wQ=;\n\tb=iCA3LZurWnc3hylL0fDHoBxKBRyaUg/OPpV2DbZ6ltbxeLH78EPLomRr0XU2zfPtrY\n\tDp3rnr1bof7h4NINJ3P6mbIKa/AlD/GX2St6sPKZSzS+Jo+PuWtNkTH0nVocFE7H/m4O\n\tsCASPHXXO/2NJuEYG9DYxcTEWLC6PBlfJFKHO8uSo6ym2ks3ahcsLwS/3oVGeEeklxIg\n\tHvu/j/6dz2apxHKiaijw0iFb4i6uOp/fly2rMD7SjO9FKCijWxCpwijgJ9mgMZnUF4Ph\n\t1HVNLXcsZAEaENz6DGvFNASDzVNwT4W53p4VEj/1fp0m545Hk901CCc1aD4phnqnLrtw\n\t+4NA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=XgMBlRLizpQH831KrtoT2I5Gz5kAD6Yzy/ReuN8Z7wQ=;\n\tb=M33bSpSQPCqWwOpu2wNroerwIFkvLtnqouyoXXvlYa91yvPrUNRzi7g0O+6h847oaz\n\tAdeHBEpLzlokldywOB4FpvPoK5WZZhUQEx2GWoOUdBSa5L2N4li5QjmkSR8J26rNvZl2\n\tfYq39zinRbf77Zsv2kWpFCE7QiZGZdwXbTJNkStmah6XFS6RIw/9JHyV2INmis4oKN0S\n\t55FDYDmSi8WxGHf8/aZ1YSLtvyTSsbLncnr3OB7x1hPqJaekSce8HwWByL+QpmnP489b\n\tVSR7tppC1UhJZB9ipJUuHyID6E3DtbUIxQlD9I03NwavYuxeynjiDInZ6TAxv6hYx3IB\n\t609w==","X-Gm-Message-State":"AOAM531aFcqUaoMZynRmEQ9WQySi8stHHJ2pSmcaQBDefyc40jSnOJOt\n\tgTfF0/w+iNJ+c/S8EDt3sYCG6yssqHo=","X-Google-Smtp-Source":"ABdhPJz+6Q3CWZ+5lpoNGFSw64ZGZ2lxvOsUaPLBR8m3FcYaFr3oALzIu5Kdy4h0c/Rn7P/ACDlViw==","X-Received":"by 2002:a2e:8710:: with SMTP id\n\tm16mr2501666lji.401.1595233217060; \n\tMon, 20 Jul 2020 01:20:17 -0700 (PDT)","Date":"Mon, 20 Jul 2020 10:20:15 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"<20200720082015.GC576734@oden.dyn.berto.se>","References":"<20200718143428.1060441-1-niklas.soderlund@ragnatech.se>\n\t<20200718143428.1060441-3-niklas.soderlund@ragnatech.se>\n\t<20200720080317.hjylqt5n7fphujki@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200720080317.hjylqt5n7fphujki@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add support for RGB565\n\tformat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11438,"web_url":"https://patchwork.libcamera.org/comment/11438/","msgid":"<20200720083724.27op76vh2yrczge6@uno.localdomain>","date":"2020-07-20T08:37:24","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add support for RGB565\n\tformat","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Mon, Jul 20, 2020 at 10:20:15AM +0200, Niklas Söderlund wrote:\n> Hi Jacopo,\n>\n> Thanks for your feedback.\n>\n> On 2020-07-20 10:03:17 +0200, Jacopo Mondi wrote:\n> > Hi Niklas,\n> >\n> > On Sat, Jul 18, 2020 at 04:34:28PM +0200, Niklas Söderlund wrote:\n> > > Add support for RGB565 format.\n> > >\n> > > Signed-off-by: Niklas Söderlund \n> > > ---\n> > > src/libcamera/formats.cpp | 10 ++++++++++\n> > > src/libcamera/formats.yaml | 3 +++\n> > > src/libcamera/v4l2_pixelformat.cpp | 1 +\n> > > 3 files changed, 14 insertions(+)\n> > >\n> > > diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> > > index 8f9bdafe821b2e69..af3996c954ae1457 100644\n> > > --- a/src/libcamera/formats.cpp\n> > > +++ b/src/libcamera/formats.cpp\n> > > @@ -233,6 +233,16 @@ const PixelFormatInfo pixelFormatInfoInvalid{};\n> > >\n> > > const std::map pixelFormatInfo{\n> > > \t/* RGB formats. */\n> > > +\t{ formats::RGB565, {\n> > > +\t\t.name = \"RGB565\",\n> > > +\t\t.format = formats::RGB565,\n> > > +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_RGB565),\n> > > +\t\t.bitsPerPixel = 16,\n> > > +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> > > +\t\t.packed = false,\n> > > +\t\t.pixelsPerGroup = 1,\n> > > +\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> > > +\t} },\n> > > \t{ formats::BGR888, {\n> > > \t\t.name = \"BGR888\",\n> > > \t\t.format = formats::BGR888,\n> > > diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\n> > > index 6b5f084bb2e4e970..3a69c05fcc04fb93 100644\n> > > --- a/src/libcamera/formats.yaml\n> > > +++ b/src/libcamera/formats.yaml\n> > > @@ -8,6 +8,9 @@ formats:\n> > > - R8:\n> > > fourcc: DRM_FORMAT_R8\n> > >\n> > > + - RGB565:\n> > > + fourcc: DRM_FORMAT_RGB565\n> > > +\n> > > - RGB888:\n> > > fourcc: DRM_FORMAT_RGB888\n> > > - BGR888:\n> > > diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> > > index 1609f8bb6370fa65..9799d389e20b358d 100644\n> > > --- a/src/libcamera/v4l2_pixelformat.cpp\n> > > +++ b/src/libcamera/v4l2_pixelformat.cpp\n> > > @@ -45,6 +45,7 @@ namespace {\n> > >\n> > > const std::map vpf2pf{\n> > > \t/* RGB formats. */\n> > > +\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB565), formats::RGB565 },\n> > > \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n> >\n> > Should RGB5 come after RGB2 ?\n>\n> I kept the same sorting order as videodev2.h, I'm open to define a\n> different sorting order here tho. What do you think?\n\nI don't see much value in staying aligned to videodev2.h, but as long\nas this was intentional I'm fine, really a minor thing. Up to you.\n\n>\n> >\n> > That apart\n> > Reviewed-by: Jacopo Mondi \n> >\n> > Thanks\n> > j\n> >\n> > > \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n> > > \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n> > > --\n> > > 2.27.0\n> > >\n> > > _______________________________________________\n> > > libcamera-devel mailing list\n> > > libcamera-devel@lists.libcamera.org\n> > > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C8B9C0109\n\tfor ;\n\tMon, 20 Jul 2020 08:33:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A2DDF605A8;\n\tMon, 20 Jul 2020 10:33:51 +0200 (CEST)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 939566039E\n\tfor ;\n\tMon, 20 Jul 2020 10:33:50 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 1254C24000C;\n\tMon, 20 Jul 2020 08:33:49 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Mon, 20 Jul 2020 10:37:24 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200720083724.27op76vh2yrczge6@uno.localdomain>","References":"<20200718143428.1060441-1-niklas.soderlund@ragnatech.se>\n\t<20200718143428.1060441-3-niklas.soderlund@ragnatech.se>\n\t<20200720080317.hjylqt5n7fphujki@uno.localdomain>\n\t<20200720082015.GC576734@oden.dyn.berto.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200720082015.GC576734@oden.dyn.berto.se>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add support for RGB565\n\tformat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11442,"web_url":"https://patchwork.libcamera.org/comment/11442/","msgid":"","date":"2020-07-20T22:52:22","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add support for RGB565\n\tformat","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas, Jacopo,\n\nOn 20/07/2020 09:37, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Mon, Jul 20, 2020 at 10:20:15AM +0200, Niklas Söderlund wrote:\n>> Hi Jacopo,\n>>\n>> Thanks for your feedback.\n>>\n>> On 2020-07-20 10:03:17 +0200, Jacopo Mondi wrote:\n>>> Hi Niklas,\n>>>\n>>> On Sat, Jul 18, 2020 at 04:34:28PM +0200, Niklas Söderlund wrote:\n>>>> Add support for RGB565 format.\n>>>>\n>>>> Signed-off-by: Niklas Söderlund \n>>>> ---\n>>>> src/libcamera/formats.cpp | 10 ++++++++++\n>>>> src/libcamera/formats.yaml | 3 +++\n>>>> src/libcamera/v4l2_pixelformat.cpp | 1 +\n>>>> 3 files changed, 14 insertions(+)\n>>>>\n>>>> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n>>>> index 8f9bdafe821b2e69..af3996c954ae1457 100644\n>>>> --- a/src/libcamera/formats.cpp\n>>>> +++ b/src/libcamera/formats.cpp\n>>>> @@ -233,6 +233,16 @@ const PixelFormatInfo pixelFormatInfoInvalid{};\n>>>>\n>>>> const std::map pixelFormatInfo{\n>>>> \t/* RGB formats. */\n>>>> +\t{ formats::RGB565, {\n>>>> +\t\t.name = \"RGB565\",\n>>>> +\t\t.format = formats::RGB565,\n>>>> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_RGB565),\n>>>> +\t\t.bitsPerPixel = 16,\n>>>> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n>>>> +\t\t.packed = false,\n>>>> +\t\t.pixelsPerGroup = 1,\n>>>> +\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n>>>> +\t} },\n>>>> \t{ formats::BGR888, {\n>>>> \t\t.name = \"BGR888\",\n>>>> \t\t.format = formats::BGR888,\n>>>> diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\n>>>> index 6b5f084bb2e4e970..3a69c05fcc04fb93 100644\n>>>> --- a/src/libcamera/formats.yaml\n>>>> +++ b/src/libcamera/formats.yaml\n>>>> @@ -8,6 +8,9 @@ formats:\n>>>> - R8:\n>>>> fourcc: DRM_FORMAT_R8\n>>>>\n>>>> + - RGB565:\n>>>> + fourcc: DRM_FORMAT_RGB565\n>>>> +\n>>>> - RGB888:\n>>>> fourcc: DRM_FORMAT_RGB888\n>>>> - BGR888:\n>>>> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n>>>> index 1609f8bb6370fa65..9799d389e20b358d 100644\n>>>> --- a/src/libcamera/v4l2_pixelformat.cpp\n>>>> +++ b/src/libcamera/v4l2_pixelformat.cpp\n>>>> @@ -45,6 +45,7 @@ namespace {\n>>>>\n>>>> const std::map vpf2pf{\n>>>> \t/* RGB formats. */\n>>>> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB565), formats::RGB565 },\n>>>> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n>>>\n>>> Should RGB5 come after RGB2 ?\n>>\n>> I kept the same sorting order as videodev2.h, I'm open to define a\n>> different sorting order here tho. What do you think?\n> \n> I don't see much value in staying aligned to videodev2.h, but as long\n> as this was intentional I'm fine, really a minor thing. Up to you.\n\nI prefer this sort order actually, as it keeps 565 < 888, and also\n16(bit) < 24(bit)...\n\nReviewed-by: Kieran Bingham \n\n>>\n>>>\n>>> That apart\n>>> Reviewed-by: Jacopo Mondi \n>>>\n>>> Thanks\n>>> j\n>>>\n>>>> \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n>>>> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGBA32), formats::ABGR8888 },\n>>>> --\n>>>> 2.27.0\n>>>>\n>>>> _______________________________________________\n>>>> libcamera-devel mailing list\n>>>> libcamera-devel@lists.libcamera.org\n>>>> https://lists.libcamera.org/listinfo/libcamera-devel\n>>\n>> --\n>> Regards,\n>> Niklas Söderlund\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52153C0109\n\tfor ;\n\tMon, 20 Jul 2020 22:52:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1C99605BF;\n\tTue, 21 Jul 2020 00:52:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 430C760540\n\tfor ;\n\tTue, 21 Jul 2020 00:52:26 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A6C052A4;\n\tTue, 21 Jul 2020 00:52:25 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qvScbpkA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595285545;\n\tbh=dMXSrdrl6gpgDyUx9fAnm9VJITmB6FaAiZXcR8zyFCE=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=qvScbpkAdI3Ba5EvKTLLseS8cpUE52N+xvXOAy4shyUdi6wxXuh0l2KhrQR0Pi87c\n\tB7Tu0n/eMOGkhDhg7xNVXKIEPHYKedsQyBrM+VShFaWxi6Xz7h7VDMy/DEHm7ACDOW\n\tYnL+PZg/PxN7Nmo0M7emX1S92bY8SqXfSGmqmVqY=","To":"Jacopo Mondi , =?utf-8?q?Niklas_S=C3=B6derlund?=\n\t","References":"<20200718143428.1060441-1-niklas.soderlund@ragnatech.se>\n\t<20200718143428.1060441-3-niklas.soderlund@ragnatech.se>\n\t<20200720080317.hjylqt5n7fphujki@uno.localdomain>\n\t<20200720082015.GC576734@oden.dyn.berto.se>\n\t<20200720083724.27op76vh2yrczge6@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 20 Jul 2020 23:52:22 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200720083724.27op76vh2yrczge6@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Add support for RGB565\n\tformat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]