[{"id":11434,"web_url":"https://patchwork.libcamera.org/comment/11434/","msgid":"<20200720080507.mf3hsv5qeeiudu4w@uno.localdomain>","date":"2020-07-20T08:05:07","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Add support for planar\n\tYVU420 format","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Sat, Jul 18, 2020 at 04:34:27PM +0200, Niklas Söderlund wrote:\n> Add support for planar YVU420.\n>\n> Signed-off-by: Niklas Söderlund \n\nLooks good!\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/formats.cpp | 10 ++++++++++\n> src/libcamera/formats.yaml | 2 ++\n> src/libcamera/v4l2_pixelformat.cpp | 1 +\n> 3 files changed, 13 insertions(+)\n>\n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 3f895a7c2badc34a..8f9bdafe821b2e69 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -407,6 +407,16 @@ const std::map pixelFormatInfo{\n> \t\t.pixelsPerGroup = 2,\n> \t\t.planes = {{ { 2, 1 }, { 1, 2 }, { 1, 2 } }},\n> \t} },\n> +\t{ formats::YVU420, {\n> +\t\t.name = \"YVU420\",\n> +\t\t.format = PixelFormat(formats::YVU420),\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YVU420),\n> +\t\t.bitsPerPixel = 12,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 2,\n> +\t\t.planes = {{ { 2, 1 }, { 1, 2 }, { 1, 2 } }},\n> +\t} },\n> \t{ formats::YUV422, {\n> \t\t.name = \"YUV422\",\n> \t\t.format = PixelFormat(formats::YUV422),\n> diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\n> index ce06dbc41aa13f5e..6b5f084bb2e4e970 100644\n> --- a/src/libcamera/formats.yaml\n> +++ b/src/libcamera/formats.yaml\n> @@ -55,6 +55,8 @@ formats:\n>\n> - YUV420:\n> fourcc: DRM_FORMAT_YUV420\n> + - YVU420:\n> + fourcc: DRM_FORMAT_YVU420\n> - YUV422:\n> fourcc: DRM_FORMAT_YUV422\n>\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 6745d17d49269bab..1609f8bb6370fa65 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -64,6 +64,7 @@ const std::map vpf2pf{\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_NV12), formats::NV12 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_NV21), formats::NV21 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV420), formats::YUV420 },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_YVU420), formats::YVU420},\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV422P), formats::YUV422 },\n>\n> \t/* Greyscale formats. */\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC640BD792\n\tfor ;\n\tMon, 20 Jul 2020 08:01:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8A666605A8;\n\tMon, 20 Jul 2020 10:01:34 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 29D176039E\n\tfor ;\n\tMon, 20 Jul 2020 10:01:33 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id A6E7760018;\n\tMon, 20 Jul 2020 08:01:32 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Mon, 20 Jul 2020 10:05:07 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200720080507.mf3hsv5qeeiudu4w@uno.localdomain>","References":"<20200718143428.1060441-1-niklas.soderlund@ragnatech.se>\n\t<20200718143428.1060441-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200718143428.1060441-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Add support for planar\n\tYVU420 format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11443,"web_url":"https://patchwork.libcamera.org/comment/11443/","msgid":"<232dec89-956c-ebee-376e-08dbcac5adb0@ideasonboard.com>","date":"2020-07-20T22:53:50","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Add support for planar\n\tYVU420 format","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 20/07/2020 09:05, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Sat, Jul 18, 2020 at 04:34:27PM +0200, Niklas Söderlund wrote:\n>> Add support for planar YVU420.\n>>\n>> Signed-off-by: Niklas Söderlund \n> \n> Looks good!\n> Reviewed-by: Jacopo Mondi \n\nLikewise,\n\nBut see below for a single space nit...\n\n\n> \n> Thanks\n> j\n> \n>> ---\n>> src/libcamera/formats.cpp | 10 ++++++++++\n>> src/libcamera/formats.yaml | 2 ++\n>> src/libcamera/v4l2_pixelformat.cpp | 1 +\n>> 3 files changed, 13 insertions(+)\n>>\n>> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n>> index 3f895a7c2badc34a..8f9bdafe821b2e69 100644\n>> --- a/src/libcamera/formats.cpp\n>> +++ b/src/libcamera/formats.cpp\n>> @@ -407,6 +407,16 @@ const std::map pixelFormatInfo{\n>> \t\t.pixelsPerGroup = 2,\n>> \t\t.planes = {{ { 2, 1 }, { 1, 2 }, { 1, 2 } }},\n>> \t} },\n>> +\t{ formats::YVU420, {\n>> +\t\t.name = \"YVU420\",\n>> +\t\t.format = PixelFormat(formats::YVU420),\n>> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_YVU420),\n>> +\t\t.bitsPerPixel = 12,\n>> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingYUV,\n>> +\t\t.packed = false,\n>> +\t\t.pixelsPerGroup = 2,\n>> +\t\t.planes = {{ { 2, 1 }, { 1, 2 }, { 1, 2 } }},\n>> +\t} },\n>> \t{ formats::YUV422, {\n>> \t\t.name = \"YUV422\",\n>> \t\t.format = PixelFormat(formats::YUV422),\n>> diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\n>> index ce06dbc41aa13f5e..6b5f084bb2e4e970 100644\n>> --- a/src/libcamera/formats.yaml\n>> +++ b/src/libcamera/formats.yaml\n>> @@ -55,6 +55,8 @@ formats:\n>>\n>> - YUV420:\n>> fourcc: DRM_FORMAT_YUV420\n>> + - YVU420:\n>> + fourcc: DRM_FORMAT_YVU420\n>> - YUV422:\n>> fourcc: DRM_FORMAT_YUV422\n>>\n>> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n>> index 6745d17d49269bab..1609f8bb6370fa65 100644\n>> --- a/src/libcamera/v4l2_pixelformat.cpp\n>> +++ b/src/libcamera/v4l2_pixelformat.cpp\n>> @@ -64,6 +64,7 @@ const std::map vpf2pf{\n>> \t{ V4L2PixelFormat(V4L2_PIX_FMT_NV12), formats::NV12 },\n>> \t{ V4L2PixelFormat(V4L2_PIX_FMT_NV21), formats::NV21 },\n>> \t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV420), formats::YUV420 },\n>> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_YVU420), formats::YVU420},\n\nShouldn't there be a space after YVU420 to match the other lines?\n\nWith that fixed,\n\nReviewed-by: Kieran Bingham \n\n>> \t{ V4L2PixelFormat(V4L2_PIX_FMT_YUV422P), formats::YUV422 },\n>>\n>> \t/* Greyscale formats. */\n>> --\n>> 2.27.0\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D9AFC0109\n\tfor ;\n\tMon, 20 Jul 2020 22:53:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5A30D605BF;\n\tTue, 21 Jul 2020 00:53:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A967D60540\n\tfor ;\n\tTue, 21 Jul 2020 00:53:53 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3DF872A4;\n\tTue, 21 Jul 2020 00:53:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DQxaYQ42\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1595285633;\n\tbh=XAcVHM0IKPvMrnYDkyBwse0SxmZX9yS6gaS63vOUVzo=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=DQxaYQ42E/oGEiMYLo/gGsRGr9EiH9Do6hbhc6jz7ByA+wZCv5K6OEhfKSfwbWF+k\n\tniwbcwItiyoUmYA6Oqe69zt57sSqozW8LP3+gI2y3vVcSliDPi0+w1EsymN1ezwYq7\n\tyrH8CgJuxGwUlrg86S8oCsfMQYef5oYqDWjgdssQ=","To":"Jacopo Mondi , =?utf-8?q?Niklas_S=C3=B6derlund?=\n\t","References":"<20200718143428.1060441-1-niklas.soderlund@ragnatech.se>\n\t<20200718143428.1060441-2-niklas.soderlund@ragnatech.se>\n\t<20200720080507.mf3hsv5qeeiudu4w@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<232dec89-956c-ebee-376e-08dbcac5adb0@ideasonboard.com>","Date":"Mon, 20 Jul 2020 23:53:50 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20200720080507.mf3hsv5qeeiudu4w@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: Add support for planar\n\tYVU420 format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]