{"id":8856,"url":"https://patchwork.libcamera.org/api/patches/8856/?format=json","web_url":"https://patchwork.libcamera.org/patch/8856/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200718132324.867815-8-niklas.soderlund@ragnatech.se>","date":"2020-07-18T13:23:22","name":"[libcamera-devel,7/9] libcamera: pipeline: raspberrypi: Align camera name","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"2f1f1003f56bff01c94183ca0038b4367aaa6da8","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":{"id":16,"url":"https://patchwork.libcamera.org/api/users/16/?format=json","username":"neg","first_name":"Niklas","last_name":"Söderlund","email":"niklas.soderlund@ragnatech.se"},"mbox":"https://patchwork.libcamera.org/patch/8856/mbox/","series":[{"id":1115,"url":"https://patchwork.libcamera.org/api/series/1115/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1115","date":"2020-07-18T13:23:15","name":"libcamera: camera: Add camera ID","version":1,"mbox":"https://patchwork.libcamera.org/series/1115/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8856/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8856/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D1CA9C2E67\n\tfor ;\n\tSat, 18 Jul 2020 13:23:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9286A60744;\n\tSat, 18 Jul 2020 15:23:39 +0200 (CEST)","from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8140060717\n\tfor ;\n\tSat, 18 Jul 2020 15:23:35 +0200 (CEST)","from bismarck.berto.se (p4fca2eca.dip0.t-ipconnect.de\n\t[79.202.46.202]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid e1009a03-c8f9-11ea-933e-005056917a89;\n\tSat, 18 Jul 2020 15:23:33 +0200 (CEST)"],"X-Halon-ID":"e1009a03-c8f9-11ea-933e-005056917a89","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 18 Jul 2020 15:23:22 +0200","Message-Id":"<20200718132324.867815-8-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200718132324.867815-1-niklas.soderlund@ragnatech.se>","References":"<20200718132324.867815-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 7/9] libcamera: pipeline: raspberrypi:\n\tAlign camera name","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The raspberrypi pipeline uses the sensor model as the camera name where\nother pipelines who has a sensor uses the sensors entity name. Align the\nraspberrypi pipeline to also use the entity name.\n\nThe sensor model is derived from the entity name but in case the sensor\nis attached to an i2c bus the i2c information is dropped from the entity\nname to create the model.\n\nBefore this change the camera name was\n\n'imx219'\n\nAfter this change the camera name is\n\n'imx219 10-0010'\n\nSigned-off-by: Niklas Söderlund \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 487dc819daa1d0ec..bead2a6220e207f5 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -975,7 +975,7 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n \t/* Create and register the camera. */\n \tstd::shared_ptr camera = Camera::create(this,\n \t\t\t\t\t\t\tdata->sensor_->id(),\n-\t\t\t\t\t\t\tdata->sensor_->model(),\n+\t\t\t\t\t\t\tdata->sensor_->entity()->name(),\n \t\t\t\t\t\t\tstreams);\n \tregisterCamera(std::move(camera), std::move(data));\n \n","prefixes":["libcamera-devel","7/9"]}