[{"id":11426,"web_url":"https://patchwork.libcamera.org/comment/11426/","msgid":"<20200718151159.GC555842@oden.dyn.berto.se>","date":"2020-07-18T15:11:59","subject":"Re: [libcamera-devel] [PATCH v3 03/10] libcamera: pipeline:\n\traspberrypi: Add some debug logging","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Naushir,\n\nThanks for your work.\n\nOn 2020-07-17 09:54:03 +0100, Naushir Patuck wrote:\n> No functional changes, only added some more trace points.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 9 ++++++++-\n> 1 file changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 3884d93d..56b7ee99 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -1183,6 +1183,11 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n> \tif (state_ == State::Stopped)\n> \t\treturn;\n> \n> +\tLOG(RPI, Debug) << \"Stream ISP Input buffer complete\"\n> +\t\t\t<< \", buffer id \" << buffer->cookie()\n> +\t\t\t<< \", timestamp: \" << buffer->metadata().timestamp;\n> +\n> +\t/* The ISP input buffer gets re-queued into Unicam. */\n> \thandleStreamBuffer(buffer, &unicam_[Unicam::Image]);\n> \thandleState();\n> }\n> @@ -1347,6 +1352,8 @@ void RPiCameraData::checkRequestCompleted()\n> \t\tpipe_->completeRequest(camera_, request);\n> \t\trequestQueue_.pop_front();\n> \t\trequestCompleted = true;\n> +\n> +\t\tLOG(RPI, Debug) << \"Request is complete\";\n> \t}\n> \n> \t/*\n> @@ -1485,7 +1492,7 @@ FrameBuffer *RPiCameraData::updateQueue(std::queue &q, uint64_t t\n> \t\tif (b->metadata().timestamp < timestamp) {\n> \t\t\tq.pop();\n> \t\t\tdev->queueBuffer(b);\n> -\t\t\tLOG(RPI, Error) << \"Dropping input frame!\";\n> +\t\t\tLOG(RPI, Warning) << \"Dropping input frame!\";\n> \t\t} else if (b->metadata().timestamp == timestamp) {\n> \t\t\t/* The calling function will pop the item from the queue. */\n> \t\t\treturn b;\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68F55C0109\n\tfor ;\n\tSat, 18 Jul 2020 15:12:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D905F60589;\n\tSat, 18 Jul 2020 17:12:02 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 689B160493\n\tfor ;\n\tSat, 18 Jul 2020 17:12:01 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id h22so15863614lji.9\n\tfor ;\n\tSat, 18 Jul 2020 08:12:01 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t11sm2222044ljw.69.2020.07.18.08.11.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSat, 18 Jul 2020 08:11:59 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"DMd39du6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=ZsZ9zkMgJ1OaCoAQWxT3+rg70hMwPnpgslMDlA6+4ik=;\n\tb=DMd39du6SVKdTSUbaIdRh97cGafS7zgUPQCBsckjf+VWG/9uofbDUlTzQwyk8eIDWq\n\taSVnYumzi4edfTw4Xgi4BPCaGKS45QjceEc8ZQ9xWvpj5HALCkhXKTqzSyXKxXzCnMYf\n\tv4ruBePYXuCNa5qVuOlzWu8La/2+FoMB+s5iTrS7Qj9l3SOKAaMoiMwglRXlLlSubdZT\n\t3B05xyJMbEgW2Pe4MWpx+bqBZoTVQhlEiyxV6wryNvqRtGvezFiCV7xGWiNQBq1fceO3\n\t6ufOGYS82oMg7sBk7Uddeh17lOA5yQdfep7zTvU7BDDqdd+9L6DFVn3Tm9Rq7E9myQzt\n\tWqQg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=ZsZ9zkMgJ1OaCoAQWxT3+rg70hMwPnpgslMDlA6+4ik=;\n\tb=KaGiQ4FDcJBSjjCYePg8vysmndeF4qKfypjubhSi2oSsqOjx/Pp3RgrJintcV+LMRB\n\tK2OVBlvSH3v0LfuEQIAnq019nj9u3W1oEQEGx4ncoPf3Fa2NtdhaEb/LjwijNwK9qCuN\n\tQ1WH6sQl8e2usSx6Ri7l5V2auHgDhW4uGM+Vimu/ecCPsLejr1+LegnckmObmj8he7YB\n\tpdSQ21dtiazi0S/l93knQ+ztA0fu5dTqveyPlkqt+KNQFjGhreyRip1Ku2I/3rfqZJE/\n\thbyNGf8t5rwoly98M5U3neNc5DJp1gR1r2z+MkFP1vF1o0BzWhi4h+p/GSC2GmnI/BxN\n\tQYjA==","X-Gm-Message-State":"AOAM530m9voMzQas4pGkJvo33NRPS26PesVwp/CvKttd0In5Ro2gpuk0\n\tO4wSZOSzYmVuelNhVhxNOakPiw==","X-Google-Smtp-Source":"ABdhPJzlpIh4TwWp1qz/V4JPI1kH8dlBKmMscpgF//GO4nC9/EJnsX9nRjTULq+X+ZQQgGdTZK7Hfg==","X-Received":"by 2002:a05:651c:1291:: with SMTP id\n\t17mr7092701ljc.286.1595085120801; \n\tSat, 18 Jul 2020 08:12:00 -0700 (PDT)","Date":"Sat, 18 Jul 2020 17:11:59 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Naushir Patuck ","Message-ID":"<20200718151159.GC555842@oden.dyn.berto.se>","References":"<20200717085410.732308-1-naush@raspberrypi.com>\n\t<20200717085410.732308-4-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200717085410.732308-4-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v3 03/10] libcamera: pipeline:\n\traspberrypi: Add some debug logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]