[{"id":11409,"web_url":"https://patchwork.libcamera.org/comment/11409/","msgid":"<20200715121214.73u7otfqe2nd3o5b@uno.localdomain>","date":"2020-07-15T12:12:14","subject":"Re: [libcamera-devel] [PATCH] libcamera: geometry: Provide in-place\n\tversions of the Size helpers","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Wed, Jul 15, 2020 at 01:23:39PM +0300, Laurent Pinchart wrote:\n> Add alignDownTo(), alignUpTo(), boundTo() and expandTo() helper\n> functions to the Size class. These are in-place versions of the existing\n> alignedDownTo(), alignedUpTo(), boundedTo() and expandedTo() functions.\n>\n> The new helpers return a reference to the size, to allow chaining the\n> functions. One can thus write\n>\n> \tsize.alignDownTo(16, 16).alignUpTo(32, 32)\n> \t    .boundTo({ 40, 80 }).expandTo({ 16, 80 });\n>\n> instead of\n>\n> \tsize.alignDownTo(16, 16);\n> \tsize.alignUpTo(32, 32);\n> \tsize.boundTo({ 40, 80 });\n> \tsize.expandTo({ 16, 80 });\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nGreat!\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n  j\n\n> ---\n> This patch applies on top of the previously submitted geometry series.\n> ---\n>  include/libcamera/geometry.h | 28 ++++++++++++++++++++++\n>  src/libcamera/geometry.cpp   | 46 ++++++++++++++++++++++++++++++++++++\n>  test/geometry.cpp            | 34 ++++++++++++++++++++++++++\n>  3 files changed, 108 insertions(+)\n>\n> diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> index 30aaa7a30fe2..d858f85cf1f0 100644\n> --- a/include/libcamera/geometry.h\n> +++ b/include/libcamera/geometry.h\n> @@ -32,6 +32,34 @@ public:\n>  \tbool isNull() const { return !width && !height; }\n>  \tconst std::string toString() const;\n>\n> +\tSize &alignDownTo(unsigned int hAlignment, unsigned int vAlignment)\n> +\t{\n> +\t\twidth = width / hAlignment * hAlignment;\n> +\t\theight = height / vAlignment * vAlignment;\n> +\t\treturn *this;\n> +\t}\n> +\n> +\tSize &alignUpTo(unsigned int hAlignment, unsigned int vAlignment)\n> +\t{\n> +\t\twidth = (width + hAlignment - 1) / hAlignment * hAlignment;\n> +\t\theight = (height + vAlignment - 1) / vAlignment * vAlignment;\n> +\t\treturn *this;\n> +\t}\n> +\n> +\tSize &boundTo(const Size &bound)\n> +\t{\n> +\t\twidth = std::min(width, bound.width);\n> +\t\theight = std::min(height, bound.height);\n> +\t\treturn *this;\n> +\t}\n> +\n> +\tSize &expandTo(const Size &expand)\n> +\t{\n> +\t\twidth = std::max(width, expand.width);\n> +\t\theight = std::max(height, expand.height);\n> +\t\treturn *this;\n> +\t}\n> +\n>  \tconstexpr Size alignedDownTo(unsigned int hAlignment,\n>  \t\t\t\t     unsigned int vAlignment) const\n>  \t{\n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index 3a3784df39e6..23181bdec969 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -61,6 +61,52 @@ const std::string Size::toString() const\n>  \treturn std::to_string(width) + \"x\" + std::to_string(height);\n>  }\n>\n> +/**\n> + * \\fn Size::alignDownTo(unsigned int hAlignment, unsigned int vAlignment)\n> + * \\brief Align the size down horizontally and vertically in place\n> + * \\param[in] hAlignment Horizontal alignment\n> + * \\param[in] vAlignment Vertical alignment\n> + *\n> + * This functions rounds the width and height down to the nearest multiple of\n> + * \\a hAlignment and \\a vAlignment respectively.\n> + *\n> + * \\return A reference to this object\n> + */\n> +\n> +/**\n> + * \\fn Size::alignUpTo(unsigned int hAlignment, unsigned int vAlignment)\n> + * \\brief Align the size up horizontally and vertically in place\n> + * \\param[in] hAlignment Horizontal alignment\n> + * \\param[in] vAlignment Vertical alignment\n> + *\n> + * This functions rounds the width and height up to the nearest multiple of\n> + * \\a hAlignment and \\a vAlignment respectively.\n> + *\n> + * \\return A reference to this object\n> + */\n> +\n> +/**\n> + * \\fn Size::boundTo(const Size &bound)\n> + * \\brief Bound the size to \\a bound in place\n> + * \\param[in] bound The maximum size\n> + *\n> + * This function sets the width and height to the minimum of this size and the\n> + * \\a bound size.\n> + *\n> + * \\return A reference to this object\n> + */\n> +\n> +/**\n> + * \\fn Size::expandTo(const Size &expand)\n> + * \\brief Expand the size to \\a expand\n> + * \\param[in] expand The minimum size\n> + *\n> + * This function sets the width and height to the maximum of this size and the\n> + * \\a expand size.\n> + *\n> + * \\return A reference to this object\n> + */\n> +\n>  /**\n>   * \\fn Size::alignedDownTo(unsigned int hAlignment, unsigned int vAlignment)\n>   * \\brief Align the size down horizontally and vertically\n> diff --git a/test/geometry.cpp b/test/geometry.cpp\n> index fd0132c03b02..1a9fc1b8e3ed 100644\n> --- a/test/geometry.cpp\n> +++ b/test/geometry.cpp\n> @@ -46,6 +46,40 @@ protected:\n>  \t\t\treturn TestFail;\n>  \t\t}\n>\n> +\t\t/* Test alignDownTo(), alignUpTo(), boundTo() and expandTo() */\n> +\t\tSize s(50, 50);\n> +\n> +\t\ts.alignDownTo(16, 16);\n> +\t\tif (s != Size(48, 48)) {\n> +\t\t\tcout << \"Size::alignDownTo() test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\ts.alignUpTo(32, 32);\n> +\t\tif (s != Size(64, 64)) {\n> +\t\t\tcout << \"Size::alignUpTo() test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\ts.boundTo({ 40, 40 });\n> +\t\tif (s != Size(40, 40)) {\n> +\t\t\tcout << \"Size::boundTo() test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\ts.expandTo({ 50, 50 });\n> +\t\tif (s != Size(50, 50)) {\n> +\t\t\tcout << \"Size::expandTo() test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\ts.alignDownTo(16, 16).alignUpTo(32, 32)\n> +\t\t .boundTo({ 40, 80 }).expandTo({ 16, 80 });\n> +\t\tif (s != Size(40, 80)) {\n> +\t\t\tcout << \"Size chained in-place modifiers test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n>  \t\t/* Test alignedDownTo(), alignedUpTo(), boundedTo() and expandedTo() */\n>  \t\tif (Size(0, 0).alignedDownTo(16, 8) != Size(0, 0) ||\n>  \t\t    Size(1, 1).alignedDownTo(16, 8) != Size(0, 0) ||\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BDDC6BD792\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Jul 2020 12:08:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42A2F609A0;\n\tWed, 15 Jul 2020 14:08:42 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CE2E60940\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Jul 2020 14:08:41 +0200 (CEST)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 9D9CC1C0007;\n\tWed, 15 Jul 2020 12:08:40 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 15 Jul 2020 14:12:14 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20200715121214.73u7otfqe2nd3o5b@uno.localdomain>","References":"<20200715102339.14025-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200715102339.14025-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: geometry: Provide in-place\n\tversions of the Size helpers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":11410,"web_url":"https://patchwork.libcamera.org/comment/11410/","msgid":"<3eaa3c7a-38dd-93bb-5bd6-8d21183940b2@ideasonboard.com>","date":"2020-07-15T14:33:00","subject":"Re: [libcamera-devel] [PATCH] libcamera: geometry: Provide in-place\n\tversions of the Size helpers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 15/07/2020 11:23, Laurent Pinchart wrote:\n> Add alignDownTo(), alignUpTo(), boundTo() and expandTo() helper\n> functions to the Size class. These are in-place versions of the existing\n> alignedDownTo(), alignedUpTo(), boundedTo() and expandedTo() functions.\n> \n> The new helpers return a reference to the size, to allow chaining the\n> functions. One can thus write\n> \n> \tsize.alignDownTo(16, 16).alignUpTo(32, 32)\n> \t    .boundTo({ 40, 80 }).expandTo({ 16, 80 });\n> \n> instead of\n> \n> \tsize.alignDownTo(16, 16);\n> \tsize.alignUpTo(32, 32);\n> \tsize.boundTo({ 40, 80 });\n> \tsize.expandTo({ 16, 80 });\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nI do like the chaining in this case.\n\nI actually have a local patch in an old branch that added chaning to the\nDeviceMatch dm.add(\"A\").add(\"B\") as an experiment, but I wasn't sure it\nwas much benefit, as really it ended up being:\n\ndm.add(\"a\")\n  .add(\"b\");\n\ninstead of\n\ndm.add(\"a\");\ndm.add(\"b);\n\nBut seeing this patch makes me rethink it, and maybe I'll post it for\nfun (if it still applies).\n\nAnyway, I digress, for this patch,\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n\n\n\n> ---\n> This patch applies on top of the previously submitted geometry series.\n> ---\n>  include/libcamera/geometry.h | 28 ++++++++++++++++++++++\n>  src/libcamera/geometry.cpp   | 46 ++++++++++++++++++++++++++++++++++++\n>  test/geometry.cpp            | 34 ++++++++++++++++++++++++++\n>  3 files changed, 108 insertions(+)\n> \n> diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> index 30aaa7a30fe2..d858f85cf1f0 100644\n> --- a/include/libcamera/geometry.h\n> +++ b/include/libcamera/geometry.h\n> @@ -32,6 +32,34 @@ public:\n>  \tbool isNull() const { return !width && !height; }\n>  \tconst std::string toString() const;\n>  \n> +\tSize &alignDownTo(unsigned int hAlignment, unsigned int vAlignment)\n> +\t{\n> +\t\twidth = width / hAlignment * hAlignment;\n> +\t\theight = height / vAlignment * vAlignment;\n> +\t\treturn *this;\n> +\t}\n> +\n> +\tSize &alignUpTo(unsigned int hAlignment, unsigned int vAlignment)\n> +\t{\n> +\t\twidth = (width + hAlignment - 1) / hAlignment * hAlignment;\n> +\t\theight = (height + vAlignment - 1) / vAlignment * vAlignment;\n> +\t\treturn *this;\n> +\t}\n> +\n> +\tSize &boundTo(const Size &bound)\n> +\t{\n> +\t\twidth = std::min(width, bound.width);\n> +\t\theight = std::min(height, bound.height);\n> +\t\treturn *this;\n> +\t}\n> +\n> +\tSize &expandTo(const Size &expand)\n> +\t{\n> +\t\twidth = std::max(width, expand.width);\n> +\t\theight = std::max(height, expand.height);\n> +\t\treturn *this;\n> +\t}\n> +\n>  \tconstexpr Size alignedDownTo(unsigned int hAlignment,\n>  \t\t\t\t     unsigned int vAlignment) const\n>  \t{\n> diff --git a/src/libcamera/geometry.cpp b/src/libcamera/geometry.cpp\n> index 3a3784df39e6..23181bdec969 100644\n> --- a/src/libcamera/geometry.cpp\n> +++ b/src/libcamera/geometry.cpp\n> @@ -61,6 +61,52 @@ const std::string Size::toString() const\n>  \treturn std::to_string(width) + \"x\" + std::to_string(height);\n>  }\n>  \n> +/**\n> + * \\fn Size::alignDownTo(unsigned int hAlignment, unsigned int vAlignment)\n> + * \\brief Align the size down horizontally and vertically in place\n> + * \\param[in] hAlignment Horizontal alignment\n> + * \\param[in] vAlignment Vertical alignment\n> + *\n> + * This functions rounds the width and height down to the nearest multiple of\n> + * \\a hAlignment and \\a vAlignment respectively.\n> + *\n> + * \\return A reference to this object\n> + */\n> +\n> +/**\n> + * \\fn Size::alignUpTo(unsigned int hAlignment, unsigned int vAlignment)\n> + * \\brief Align the size up horizontally and vertically in place\n> + * \\param[in] hAlignment Horizontal alignment\n> + * \\param[in] vAlignment Vertical alignment\n> + *\n> + * This functions rounds the width and height up to the nearest multiple of\n> + * \\a hAlignment and \\a vAlignment respectively.\n> + *\n> + * \\return A reference to this object\n> + */\n> +\n> +/**\n> + * \\fn Size::boundTo(const Size &bound)\n> + * \\brief Bound the size to \\a bound in place\n> + * \\param[in] bound The maximum size\n> + *\n> + * This function sets the width and height to the minimum of this size and the\n> + * \\a bound size.\n> + *\n> + * \\return A reference to this object\n> + */\n> +\n> +/**\n> + * \\fn Size::expandTo(const Size &expand)\n> + * \\brief Expand the size to \\a expand\n> + * \\param[in] expand The minimum size\n> + *\n> + * This function sets the width and height to the maximum of this size and the\n> + * \\a expand size.\n> + *\n> + * \\return A reference to this object\n> + */\n> +\n>  /**\n>   * \\fn Size::alignedDownTo(unsigned int hAlignment, unsigned int vAlignment)\n>   * \\brief Align the size down horizontally and vertically\n> diff --git a/test/geometry.cpp b/test/geometry.cpp\n> index fd0132c03b02..1a9fc1b8e3ed 100644\n> --- a/test/geometry.cpp\n> +++ b/test/geometry.cpp\n> @@ -46,6 +46,40 @@ protected:\n>  \t\t\treturn TestFail;\n>  \t\t}\n>  \n> +\t\t/* Test alignDownTo(), alignUpTo(), boundTo() and expandTo() */\n> +\t\tSize s(50, 50);\n> +\n> +\t\ts.alignDownTo(16, 16);\n> +\t\tif (s != Size(48, 48)) {\n> +\t\t\tcout << \"Size::alignDownTo() test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\ts.alignUpTo(32, 32);\n> +\t\tif (s != Size(64, 64)) {\n> +\t\t\tcout << \"Size::alignUpTo() test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\ts.boundTo({ 40, 40 });\n> +\t\tif (s != Size(40, 40)) {\n> +\t\t\tcout << \"Size::boundTo() test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\ts.expandTo({ 50, 50 });\n> +\t\tif (s != Size(50, 50)) {\n> +\t\t\tcout << \"Size::expandTo() test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\ts.alignDownTo(16, 16).alignUpTo(32, 32)\n> +\t\t .boundTo({ 40, 80 }).expandTo({ 16, 80 });\n> +\t\tif (s != Size(40, 80)) {\n> +\t\t\tcout << \"Size chained in-place modifiers test failed\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n>  \t\t/* Test alignedDownTo(), alignedUpTo(), boundedTo() and expandedTo() */\n>  \t\tif (Size(0, 0).alignedDownTo(16, 8) != Size(0, 0) ||\n>  \t\t    Size(1, 1).alignedDownTo(16, 8) != Size(0, 0) ||\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B5E9BD790\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 15 Jul 2020 14:33:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 22A036092A;\n\tWed, 15 Jul 2020 16:33:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF5406092A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 15 Jul 2020 16:33:07 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 90C56564;\n\tWed, 15 Jul 2020 16:33:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"V6PJMM/j\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594823587;\n\tbh=JYzXbEa+mH3wCRcEnD/nIR2QqTu0P2XObKI4oJrSEHk=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=V6PJMM/jMRZzj9ZSOvdeGXPyL3SNNz9v2lBoV7iJ+16Vh2fR/rpAhEbPZ4V9KKomT\n\tx+lKvI/idyR6vKLbaHEObhVak5Ad2AHX3iUYQv3b5/G0Obo0+wNWb3+tOrZuMmoown\n\tqQ2YknZdZf3SNeeH5cJlc2PFItEOPETEtObp4hbY=","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200715102339.14025-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<3eaa3c7a-38dd-93bb-5bd6-8d21183940b2@ideasonboard.com>","Date":"Wed, 15 Jul 2020 15:33:00 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200715102339.14025-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: geometry: Provide in-place\n\tversions of the Size helpers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]