{"id":8815,"url":"https://patchwork.libcamera.org/api/patches/8815/?format=json","web_url":"https://patchwork.libcamera.org/patch/8815/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200715011833.24600-10-laurent.pinchart@ideasonboard.com>","date":"2020-07-15T01:18:29","name":"[libcamera-devel,v2,09/13] media: i2c: imx219: Parse and register properties","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7e022cb0bf318c70e8e7927937eaf702d2320d9d","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8815/mbox/","series":[{"id":1108,"url":"https://patchwork.libcamera.org/api/series/1108/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1108","date":"2020-07-15T01:18:21","name":"raspberrypi: Report sensor orientation through DT","version":2,"mbox":"https://patchwork.libcamera.org/series/1108/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8815/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8815/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EBE70BDB1C\n\tfor ;\n\tWed, 15 Jul 2020 01:18:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B92F86093C;\n\tWed, 15 Jul 2020 03:18:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F1A5C60942\n\tfor ;\n\tWed, 15 Jul 2020 03:18:48 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 82A2E11FE;\n\tWed, 15 Jul 2020 03:18:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CMZNLvvi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594775928;\n\tbh=y0E3xpxJJLvCJQL8iIUt0Sabp97CMegsICPoEDxExjI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=CMZNLvvi5aw68kWJq/F9qFqa61cjEvNEsdubmb858ggilUEIB/3gL2phKFyTx8IQZ\n\tSun0B8yQ4/JBw2PXS7xngJLmTGYo4DEhvHFQSwsFjpfQDWGylsE7U72AkkaWWzbD04\n\tGczgaQ8uhRzy55LP/kKHCsE9+EBpcnzvEqhqxKn0=","From":"Laurent Pinchart ","To":"Dave Stevenson ","Date":"Wed, 15 Jul 2020 04:18:29 +0300","Message-Id":"<20200715011833.24600-10-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200715011833.24600-1-laurent.pinchart@ideasonboard.com>","References":"<20200715011833.24600-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 09/13] media: i2c: imx219: Parse and\n\tregister properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Jacopo Mondi \n\nParse device properties and register controls for them using the newly\nintroduced helpers.\n\nSigned-off-by: Jacopo Mondi \nSigned-off-by: Hans Verkuil \nSigned-off-by: Mauro Carvalho Chehab \n\nCommit ad3a44cbd1b2e1559c6b93e80dc0c9c29632969a upstream\n\nSigned-off-by: Laurent Pinchart \n---\n drivers/media/i2c/imx219.c | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c\nindex b84fc19e9ff7..812323107f36 100644\n--- a/drivers/media/i2c/imx219.c\n+++ b/drivers/media/i2c/imx219.c\n@@ -1348,11 +1348,12 @@ static int imx219_init_controls(struct imx219 *imx219)\n \tstruct i2c_client *client = v4l2_get_subdevdata(&imx219->sd);\n \tstruct v4l2_ctrl_handler *ctrl_hdlr;\n \tunsigned int height = imx219->mode->height;\n+\tstruct v4l2_fwnode_device_properties props;\n \tint exposure_max, exposure_def, hblank;\n \tint i, ret;\n \n \tctrl_hdlr = &imx219->ctrl_handler;\n-\tret = v4l2_ctrl_handler_init(ctrl_hdlr, 9);\n+\tret = v4l2_ctrl_handler_init(ctrl_hdlr, 11);\n \tif (ret)\n \t\treturn ret;\n \n@@ -1431,6 +1432,15 @@ static int imx219_init_controls(struct imx219 *imx219)\n \t\tgoto error;\n \t}\n \n+\tret = v4l2_fwnode_device_parse(&client->dev, &props);\n+\tif (ret)\n+\t\tgoto error;\n+\n+\tret = v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &imx219_ctrl_ops,\n+\t\t\t\t\t &props);\n+\tif (ret)\n+\t\tgoto error;\n+\n \timx219->sd.ctrl_handler = ctrl_hdlr;\n \n \treturn 0;\n","prefixes":["libcamera-devel","v2","09/13"]}