{"id":8804,"url":"https://patchwork.libcamera.org/api/patches/8804/?format=json","web_url":"https://patchwork.libcamera.org/patch/8804/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200714234009.16596-5-laurent.pinchart@ideasonboard.com>","date":"2020-07-14T23:40:08","name":"[libcamera-devel,4/5] libcamera: geometry: Turn Size and Rectangle into classes","commit_ref":"945eedaf2f1106b1ac580cb43f259d33c785776c","pull_url":null,"state":"accepted","archived":false,"hash":"7cac2c99ce1d8113b077e8fc8d860b9f0f93d9ac","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8804/mbox/","series":[{"id":1107,"url":"https://patchwork.libcamera.org/api/series/1107/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1107","date":"2020-07-14T23:40:04","name":"libcamera: Various improvements to geometry classes","version":1,"mbox":"https://patchwork.libcamera.org/series/1107/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8804/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8804/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BB0CBDB1C\n\tfor ;\n\tTue, 14 Jul 2020 23:40:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24AD260939;\n\tWed, 15 Jul 2020 01:40:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A5EB260905\n\tfor ;\n\tWed, 15 Jul 2020 01:40:21 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4701671D\n\tfor ;\n\tWed, 15 Jul 2020 01:40:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KhN+u/85\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594770021;\n\tbh=detGMdE8pu6zBfzhpVatFuJPitvKO/s97GBeJhxMryI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=KhN+u/85DacML7Liw4Yj4EoaBSMmzCeUo9WeXgqlrVVK9c6LgsXsLXBKAmcfV413O\n\tcc/SW3Pqq/Fnsf6CPK2tWs7ttZQjgfGXiHxnXYCm1QVlY4pQmjxVbQTbocB/LdsE/g\n\t66StzPKZ+y5yT29Wf+81KuiW6+SM0jFovNXjiQq4=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 15 Jul 2020 02:40:08 +0300","Message-Id":"<20200714234009.16596-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200714234009.16596-1-laurent.pinchart@ideasonboard.com>","References":"<20200714234009.16596-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 4/5] libcamera: geometry: Turn Size and\n\tRectangle into classes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"SizeRange is defined as a class while Size and Rectangle are defined as\nstruct. This is confusing for users in forward declarations. Simplify it\nby turning both structures into classes.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/geometry.h | 10 +++++++---\n src/libcamera/pipeline/ipu3/cio2.h | 2 +-\n src/libcamera/pipeline/ipu3/imgu.h | 2 +-\n src/libcamera/pipeline/simple/converter.h | 2 +-\n 4 files changed, 10 insertions(+), 6 deletions(-)","diff":"diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\nindex 380248ac9a50..16c94a4861d6 100644\n--- a/include/libcamera/geometry.h\n+++ b/include/libcamera/geometry.h\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2019, Google Inc.\n *\n- * geometry.h - Geometry-related structure\n+ * geometry.h - Geometry-related classes\n */\n \n #ifndef __LIBCAMERA_GEOMETRY_H__\n@@ -13,7 +13,9 @@\n \n namespace libcamera {\n \n-struct Size {\n+class Size\n+{\n+public:\n \tSize()\n \t\t: Size(0, 0)\n \t{\n@@ -126,7 +128,9 @@ static inline bool operator!=(const SizeRange &lhs, const SizeRange &rhs)\n \treturn !(lhs == rhs);\n }\n \n-struct Rectangle {\n+class Rectangle\n+{\n+public:\n \tRectangle()\n \t\t: Rectangle(0, 0, 0, 0)\n \t{\ndiff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h\nindex 4fd949f8e513..956355a0aa58 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.h\n+++ b/src/libcamera/pipeline/ipu3/cio2.h\n@@ -21,8 +21,8 @@ class CameraSensor;\n class FrameBuffer;\n class MediaDevice;\n class Request;\n+class Size;\n class V4L2Subdevice;\n-struct Size;\n struct StreamConfiguration;\n \n class CIO2Device\ndiff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\nindex 5c124af2e9fe..23ec1ca1c6ae 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.h\n+++ b/src/libcamera/pipeline/ipu3/imgu.h\n@@ -17,7 +17,7 @@ namespace libcamera {\n \n class FrameBuffer;\n class MediaDevice;\n-struct Size;\n+class Size;\n struct StreamConfiguration;\n \n class ImgUDevice\ndiff --git a/src/libcamera/pipeline/simple/converter.h b/src/libcamera/pipeline/simple/converter.h\nindex 8ca88912b4be..78296680aa14 100644\n--- a/src/libcamera/pipeline/simple/converter.h\n+++ b/src/libcamera/pipeline/simple/converter.h\n@@ -20,7 +20,7 @@ namespace libcamera {\n \n class FrameBuffer;\n class MediaDevice;\n-struct Size;\n+class Size;\n class SizeRange;\n struct StreamConfiguration;\n class V4L2M2MDevice;\n","prefixes":["libcamera-devel","4/5"]}