{"id":8801,"url":"https://patchwork.libcamera.org/api/patches/8801/?format=json","web_url":"https://patchwork.libcamera.org/patch/8801/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200714234009.16596-2-laurent.pinchart@ideasonboard.com>","date":"2020-07-14T23:40:05","name":"[libcamera-devel,1/5] libcamera: geometry: Don't default-initialize Size unnecessarily","commit_ref":"120cbd802463803165d342a0206f820bd1e11e6c","pull_url":null,"state":"accepted","archived":false,"hash":"8e154c310e735858b865e3e57f4543dda7fa272e","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8801/mbox/","series":[{"id":1107,"url":"https://patchwork.libcamera.org/api/series/1107/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1107","date":"2020-07-14T23:40:04","name":"libcamera: Various improvements to geometry classes","version":1,"mbox":"https://patchwork.libcamera.org/series/1107/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8801/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8801/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A92ACBD792\n\tfor ;\n\tTue, 14 Jul 2020 23:40:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1353960926;\n\tWed, 15 Jul 2020 01:40:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C32E860913\n\tfor ;\n\tWed, 15 Jul 2020 01:40:20 +0200 (CEST)","from pendragon.bb.dnainternet.fi (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5DEDD10F6\n\tfor ;\n\tWed, 15 Jul 2020 01:40:20 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"O0wYJovU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594770020;\n\tbh=tWEqVyXXzJm1nnlSSSVjmRc8BW/umlVfUxftGjE2DoU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=O0wYJovUGQ0HHKmyStkBdS09g5I2DSx47t4MreVQmdpRylxvg9y/55xy8ERAxUwL7\n\tUYF/NRD3BEKXV3DJ2JTTcFHZ4CfbRQntNEzx0+cbDkNdfRxQs38VMiG4GXi+L1hqDl\n\tEeq6PnLioIYJ2GmB2yhWXj9fuzmKhQf/2VvWcn+w=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 15 Jul 2020 02:40:05 +0300","Message-Id":"<20200714234009.16596-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20200714234009.16596-1-laurent.pinchart@ideasonboard.com>","References":"<20200714234009.16596-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/5] libcamera: geometry: Don't\n\tdefault-initialize Size unnecessarily","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Size has a default constructor, there's no need to default-initialize\ninstances explicitly. Fix it.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex c6cb84e0b0c9..009e502b288c 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -418,7 +418,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n \n \tunsigned int rawCount = 0, outCount = 0, count = 0, maxIndex = 0;\n \tstd::pair outSize[2];\n-\tSize maxSize = {};\n+\tSize maxSize;\n \tfor (StreamConfiguration &cfg : config_) {\n \t\tif (isRaw(cfg.pixelFormat)) {\n \t\t\t/*\n@@ -621,7 +621,7 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \tfor (auto const stream : data->streams_)\n \t\tstream->reset();\n \n-\tSize maxSize = {}, sensorSize = {};\n+\tSize maxSize, sensorSize;\n \tunsigned int maxIndex = 0;\n \tbool rawStream = false;\n \n","prefixes":["libcamera-devel","1/5"]}