[{"id":11397,"web_url":"https://patchwork.libcamera.org/comment/11397/","msgid":"<20200715062008.GC3051471@oden.dyn.berto.se>","date":"2020-07-15T06:20:08","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Use\n\tstd::make_tuple()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-07-15 02:33:25 +0300, Laurent Pinchart wrote:\n> Prior to N4387 ([1]), the std::tuple::tuple(const Types&...) constructor\n> was unconditionally explicit. gcc 5 doesn't implement N4387, leading to\n> a compilation error in the simple pipeline handler. Use\n> std::make_tuple() to fix it.\n> \n> [1] http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4387.html\n> \n> Signed-off-by: Laurent Pinchart \n\nMaybe it's time we considered to drop support for gcc5 and possibly even \ngcc6? But that is a topic for a another thread,\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/simple/converter.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index dc7c046329f1..75fb297ebd58 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -271,9 +271,9 @@ SimpleConverter::strideAndFrameSize(const Size &size,\n> \n> \tint ret = m2m_->capture()->tryFormat(&format);\n> \tif (ret < 0)\n> -\t\treturn { 0, 0 };\n> +\t\treturn std::make_tuple(0, 0);\n> \n> -\treturn { format.planes[0].bpl, format.planes[0].size };\n> +\treturn std::make_tuple(format.planes[0].bpl, format.planes[0].size);\n> }\n> \n> } /* namespace libcamera */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F91CBD790\n\tfor ;\n\tWed, 15 Jul 2020 06:20:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A547B60930;\n\tWed, 15 Jul 2020 08:20:12 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2BC1A6091A\n\tfor ;\n\tWed, 15 Jul 2020 08:20:11 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id e4so1275000ljn.4\n\tfor ;\n\tTue, 14 Jul 2020 23:20:11 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\td6sm254896ljc.23.2020.07.14.23.20.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 14 Jul 2020 23:20:09 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"ll8ULC5l\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=oDeOhvYZaZqI8q3A/DS9qLPp/jq3bGC9EU5IBIyKHa4=;\n\tb=ll8ULC5lvA1kQwwhIsRNvVRYQNxAN0iQ2eEbDHsBUbSaly/yz3GMcUriIVdZIZ4i5U\n\tWifvXR6QEx5BmHRXP73ySTelQ4pRorSOUAuVsWYuK+7HeB6QGgxKHjqPhJjEgrVpFwyN\n\tMElKR92j2MqLK6yLxHizqL9+DbHNbtNqWAjGfF1ah6hA8wnZdEsy0JDJYzXrduOZL4zV\n\t3bZLvMop52sz+paggj3Jy8BfwPEzQ38GZQqO/V+J58NevqXzHis0n8XP/6WFzyHA+gT3\n\t26uzSotnc7Am9iUoJ4bK1q1NVCNyAAWItV32FRkrmczMtv8x49Zxymg0EizOzuMeom6X\n\t41/Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=oDeOhvYZaZqI8q3A/DS9qLPp/jq3bGC9EU5IBIyKHa4=;\n\tb=cJxpeCsu5QReznon47UI15Fg31jxPeWJ/Ga468JRnssLJdEfMuOEMedxtXkNaaWMT5\n\tXPXdC4N8N/iwCrR3kAfxX9LIfvt7xhmr+q2zNUdbpbZfkkq3oM6qQFF3HNd36YXplHx+\n\toCjzYwWlhO/nQ4z9QcdbjqlLrhYKknq9uUp/eBiASh1GWi1rgqTy50my50SdadeogLDa\n\tKADc0njLptjD01jhrFWXLjVLZrtZyPzwGvF2zZxcBzmiNyMhNDmeoL5DmVh27QOL27TZ\n\tb3iGJraXQIHiudRGy0QS4VwAEVR3q2ZbqkHuG7Wue6Ni7kJHVt9cRy1f6VKYKR/f0VNn\n\tqQiw==","X-Gm-Message-State":"AOAM533vLAiQGqZhJMHhhCXPOwEobnY5flswWLgu1NKQPGa/22Q+aFI9\n\tAY9iXnE3Gm/2P/FbKwyLzuwDeZoJQiI=","X-Google-Smtp-Source":"ABdhPJxFIWKkW4XX7RNTvJFiXXC8qbOs0s1xtpdt1cjbRyotrjF8SDMrqzdwv8hzia8n7NcIeBH7zQ==","X-Received":"by 2002:a05:651c:39a:: with SMTP id\n\te26mr4189820ljp.72.1594794010420; \n\tTue, 14 Jul 2020 23:20:10 -0700 (PDT)","Date":"Wed, 15 Jul 2020 08:20:08 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200715062008.GC3051471@oden.dyn.berto.se>","References":"<20200714233325.14951-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200714233325.14951-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Use\n\tstd::make_tuple()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11406,"web_url":"https://patchwork.libcamera.org/comment/11406/","msgid":"<20200715093537.GB6144@pendragon.ideasonboard.com>","date":"2020-07-15T09:35:37","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Use\n\tstd::make_tuple()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nOn Wed, Jul 15, 2020 at 08:20:08AM +0200, Niklas Söderlund wrote:\n> On 2020-07-15 02:33:25 +0300, Laurent Pinchart wrote:\n> > Prior to N4387 ([1]), the std::tuple::tuple(const Types&...) constructor\n> > was unconditionally explicit. gcc 5 doesn't implement N4387, leading to\n> > a compilation error in the simple pipeline handler. Use\n> > std::make_tuple() to fix it.\n> > \n> > [1] http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4387.html\n> > \n> > Signed-off-by: Laurent Pinchart \n> \n> Maybe it's time we considered to drop support for gcc5 and possibly even \n> gcc6? But that is a topic for a another thread,\n\nI wouldn't be against that.\n\n> Reviewed-by: Niklas Söderlund \n> \n> > ---\n> > src/libcamera/pipeline/simple/converter.cpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> > index dc7c046329f1..75fb297ebd58 100644\n> > --- a/src/libcamera/pipeline/simple/converter.cpp\n> > +++ b/src/libcamera/pipeline/simple/converter.cpp\n> > @@ -271,9 +271,9 @@ SimpleConverter::strideAndFrameSize(const Size &size,\n> > \n> > \tint ret = m2m_->capture()->tryFormat(&format);\n> > \tif (ret < 0)\n> > -\t\treturn { 0, 0 };\n> > +\t\treturn std::make_tuple(0, 0);\n> > \n> > -\treturn { format.planes[0].bpl, format.planes[0].size };\n> > +\treturn std::make_tuple(format.planes[0].bpl, format.planes[0].size);\n> > }\n> > \n> > } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B629FBD792\n\tfor ;\n\tWed, 15 Jul 2020 09:35:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3AD7F60962;\n\tWed, 15 Jul 2020 11:35:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 48670605B0\n\tfor ;\n\tWed, 15 Jul 2020 11:35:45 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B6873564;\n\tWed, 15 Jul 2020 11:35:44 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hqrrsGhu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594805744;\n\tbh=r+Dk/44Z/ebqfClw+zL7BQHnaEExYdXQlxQ1O/zfXF4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hqrrsGhuW5eQzXBYubYIirCXYnQftJtezzJQAgbXXNW3QPxyaGm0aZhN0zgcJB7io\n\t/kAdLKo4FO+xatcKrlkTjKy1zMLhlFDsUE+c90iqk4uUhqtxyMY0ybi/XF7SHcH49g\n\tC+JdpHJKvqPqANecNwzGuDosQlXEc5QC+CTYeDcM=","Date":"Wed, 15 Jul 2020 12:35:37 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20200715093537.GB6144@pendragon.ideasonboard.com>","References":"<20200714233325.14951-1-laurent.pinchart@ideasonboard.com>\n\t<20200715062008.GC3051471@oden.dyn.berto.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200715062008.GC3051471@oden.dyn.berto.se>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Use\n\tstd::make_tuple()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11419,"web_url":"https://patchwork.libcamera.org/comment/11419/","msgid":"","date":"2020-07-16T14:06:08","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Use\n\tstd::make_tuple()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas, Laurent,\n\nOn 15/07/2020 10:35, Laurent Pinchart wrote:\n> Hi Niklas,\n> \n> On Wed, Jul 15, 2020 at 08:20:08AM +0200, Niklas Söderlund wrote:\n>> On 2020-07-15 02:33:25 +0300, Laurent Pinchart wrote:\n>>> Prior to N4387 ([1]), the std::tuple::tuple(const Types&...) constructor\n>>> was unconditionally explicit. gcc 5 doesn't implement N4387, leading to\n>>> a compilation error in the simple pipeline handler. Use\n>>> std::make_tuple() to fix it.\n>>>\n>>> [1] http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4387.html\n>>>\n>>> Signed-off-by: Laurent Pinchart \n>>\n>> Maybe it's time we considered to drop support for gcc5 and possibly even \n>> gcc6? But that is a topic for a another thread,\n> \n> I wouldn't be against that.\n\nI can't recall if we discussed on IRC or a thread, but indeed, if a\ndistribution has a kernel older than we can support, then I don't think\nwe need to support the build on that system either.\n\n- Ubuntu only brought in kernel v5.0 at 18.04.3, and 18.04 ships with\ngcc v7.\n\n- On Debian, Stretch(9) uses kernel v4.14, and buster(10) has v5.4.\nBuster ships with GCC v8.\n\n- Fedora picks up a v5.0 kernel in Fedora 30, which ships gcc v9.\n\n\n\nSo I don't foresee much reason to keep gcc 5/6 support around ...\nDoes anyone know of a distribution that uses a kernel >= 5.0 which ships\ngcc <= 6?\n\n\n\n> \n>> Reviewed-by: Niklas Söderlund \n>>\n>>> ---\n>>> src/libcamera/pipeline/simple/converter.cpp | 4 ++--\n>>> 1 file changed, 2 insertions(+), 2 deletions(-)\n>>>\n>>> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n>>> index dc7c046329f1..75fb297ebd58 100644\n>>> --- a/src/libcamera/pipeline/simple/converter.cpp\n>>> +++ b/src/libcamera/pipeline/simple/converter.cpp\n>>> @@ -271,9 +271,9 @@ SimpleConverter::strideAndFrameSize(const Size &size,\n>>> \n>>> \tint ret = m2m_->capture()->tryFormat(&format);\n>>> \tif (ret < 0)\n>>> -\t\treturn { 0, 0 };\n>>> +\t\treturn std::make_tuple(0, 0);\n>>> \n>>> -\treturn { format.planes[0].bpl, format.planes[0].size };\n>>> +\treturn std::make_tuple(format.planes[0].bpl, format.planes[0].size);\n\nGCC support aside, I don't see anything wrong here in this patch though\nif you still want to integrate it...\n\nReviewed-by: Kieran Bingham \n\n>>> }\n>>> \n>>> } /* namespace libcamera */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 85257BD792\n\tfor ;\n\tThu, 16 Jul 2020 14:06:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C73A60553;\n\tThu, 16 Jul 2020 16:06:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 01A186048A\n\tfor ;\n\tThu, 16 Jul 2020 16:06:11 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 64AEC2B7;\n\tThu, 16 Jul 2020 16:06:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HsnI92jG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594908371;\n\tbh=0KmBaJaDTGQDgyBJEffq+JIsyuZa8hfHvS1z16qSAuY=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=HsnI92jGYLpxobW3Tex00c0gu3jzfO6yDTh1SN+q6/vgq+KD1axWspeYAsbw7yfSw\n\tgBHI8tA2/p0bw7Q8BKYP1uGQ2IDJbmVR1/p2guiIh6vxM1TeIP/QFnw1zXvaBI1QNN\n\tqzc2JUMSYc8JTQz3solb8G1ypDRDXJt5btHreWOc=","To":"Laurent Pinchart , =?utf-8?q?Niklas?=\n\t=?utf-8?q?_S=C3=B6derlund?= ","References":"<20200714233325.14951-1-laurent.pinchart@ideasonboard.com>\n\t<20200715062008.GC3051471@oden.dyn.berto.se>\n\t<20200715093537.GB6144@pendragon.ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 16 Jul 2020 15:06:08 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200715093537.GB6144@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Use\n\tstd::make_tuple()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11420,"web_url":"https://patchwork.libcamera.org/comment/11420/","msgid":"<20200716143957.GF5960@pendragon.ideasonboard.com>","date":"2020-07-16T14:39:57","subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Use\n\tstd::make_tuple()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Thu, Jul 16, 2020 at 03:06:08PM +0100, Kieran Bingham wrote:\n> On 15/07/2020 10:35, Laurent Pinchart wrote:\n> > On Wed, Jul 15, 2020 at 08:20:08AM +0200, Niklas Söderlund wrote:\n> >> On 2020-07-15 02:33:25 +0300, Laurent Pinchart wrote:\n> >>> Prior to N4387 ([1]), the std::tuple::tuple(const Types&...) constructor\n> >>> was unconditionally explicit. gcc 5 doesn't implement N4387, leading to\n> >>> a compilation error in the simple pipeline handler. Use\n> >>> std::make_tuple() to fix it.\n> >>>\n> >>> [1] http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4387.html\n> >>>\n> >>> Signed-off-by: Laurent Pinchart \n> >>\n> >> Maybe it's time we considered to drop support for gcc5 and possibly even \n> >> gcc6? But that is a topic for a another thread,\n> > \n> > I wouldn't be against that.\n> \n> I can't recall if we discussed on IRC or a thread, but indeed, if a\n> distribution has a kernel older than we can support, then I don't think\n> we need to support the build on that system either.\n> \n> - Ubuntu only brought in kernel v5.0 at 18.04.3, and 18.04 ships with\n> gcc v7.\n> \n> - On Debian, Stretch(9) uses kernel v4.14, and buster(10) has v5.4.\n> Buster ships with GCC v8.\n> \n> - Fedora picks up a v5.0 kernel in Fedora 30, which ships gcc v9.\n> \n> So I don't foresee much reason to keep gcc 5/6 support around ...\n> Does anyone know of a distribution that uses a kernel >= 5.0 which ships\n> gcc <= 6?\n\nYou've started a separate mail thread on that topic, so let's discuss it\nthere.\n\n> >> Reviewed-by: Niklas Söderlund \n> >>\n> >>> ---\n> >>> src/libcamera/pipeline/simple/converter.cpp | 4 ++--\n> >>> 1 file changed, 2 insertions(+), 2 deletions(-)\n> >>>\n> >>> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> >>> index dc7c046329f1..75fb297ebd58 100644\n> >>> --- a/src/libcamera/pipeline/simple/converter.cpp\n> >>> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> >>> @@ -271,9 +271,9 @@ SimpleConverter::strideAndFrameSize(const Size &size,\n> >>> \n> >>> \tint ret = m2m_->capture()->tryFormat(&format);\n> >>> \tif (ret < 0)\n> >>> -\t\treturn { 0, 0 };\n> >>> +\t\treturn std::make_tuple(0, 0);\n> >>> \n> >>> -\treturn { format.planes[0].bpl, format.planes[0].size };\n> >>> +\treturn std::make_tuple(format.planes[0].bpl, format.planes[0].size);\n> \n> GCC support aside, I don't see anything wrong here in this patch though\n> if you still want to integrate it...\n> \n> Reviewed-by: Kieran Bingham \n> \n> >>> }\n> >>> \n> >>> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 511A4C2E7A\n\tfor ;\n\tThu, 16 Jul 2020 14:40:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C57BC60552;\n\tThu, 16 Jul 2020 16:40:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91CA36048C\n\tfor ;\n\tThu, 16 Jul 2020 16:40:06 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 423562B7;\n\tThu, 16 Jul 2020 16:40:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RgPvjrkp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594910405;\n\tbh=zFTjAC48UN02aBF4Zkff4cG33NxDjWjjrv0Cn7KPeRU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RgPvjrkp4YyL/0mOjBQdbn2o1r3NzBDAB5eTnd7PKOI5OEwaH2XFghduJynGSKA/Y\n\tfox/2i4KaftkjT1o5OwuJRQAYEi9FIcJMjH9ni7PST3ZRjir9zay6xsDg45wq9aqi9\n\tcNZ/4aa4/Y+IEQl9O23nD2+10VZhnNqTXQdmKHRA=","Date":"Thu, 16 Jul 2020 17:39:57 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200716143957.GF5960@pendragon.ideasonboard.com>","References":"<20200714233325.14951-1-laurent.pinchart@ideasonboard.com>\n\t<20200715062008.GC3051471@oden.dyn.berto.se>\n\t<20200715093537.GB6144@pendragon.ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] libcamera: pipeline: simple: Use\n\tstd::make_tuple()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]