[{"id":11390,"web_url":"https://patchwork.libcamera.org/comment/11390/","msgid":"<20200714214330.GF5854@pendragon.ideasonboard.com>","date":"2020-07-14T21:43:30","subject":"Re: [libcamera-devel] [PATCH 16/20] libcamera: ipu3: Remove camera_\n\tfrom IPU3CameraConfiguration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Jul 14, 2020 at 12:42:08PM +0200, Jacopo Mondi wrote:\n> The IPU3CameraConfiguration::camera_ shared pointer is not used.\n> Remove it.\n> \n> Reviewed-by: Niklas Söderlund \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 9 +++------\n> 1 file changed, 3 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 2d8b3c501294..804d68d47c92 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -62,7 +62,7 @@ public:\n> class IPU3CameraConfiguration : public CameraConfiguration\n> {\n> public:\n> -\tIPU3CameraConfiguration(Camera *camera, IPU3CameraData *data);\n> +\tIPU3CameraConfiguration(IPU3CameraData *data);\n> \n> \tStatus validate() override;\n> \n> @@ -74,7 +74,6 @@ private:\n> \t * corresponding Camera instance is valid. In order to borrow a\n> \t * reference to the camera data, store a new reference to the camera.\n> \t */\n> -\tstd::shared_ptr camera_;\n> \tconst IPU3CameraData *data_;\n> \n> \tStreamConfiguration cio2Configuration_;\n> @@ -124,11 +123,9 @@ private:\n> \tMediaDevice *imguMediaDev_;\n> };\n> \n> -IPU3CameraConfiguration::IPU3CameraConfiguration(Camera *camera,\n> -\t\t\t\t\t\t IPU3CameraData *data)\n> +IPU3CameraConfiguration::IPU3CameraConfiguration(IPU3CameraData *data)\n> \t: CameraConfiguration()\n> {\n> -\tcamera_ = camera->shared_from_this();\n> \tdata_ = data;\n> }\n> \n> @@ -296,7 +293,7 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> \t\t\t\t\t\t\t\tconst StreamRoles &roles)\n> {\n> \tIPU3CameraData *data = cameraData(camera);\n> -\tIPU3CameraConfiguration *config = new IPU3CameraConfiguration(camera, data);\n> +\tIPU3CameraConfiguration *config = new IPU3CameraConfiguration(data);\n> \n> \tif (roles.empty())\n> \t\treturn config;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 964E0BD792\n\tfor ;\n\tTue, 14 Jul 2020 21:43:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2CF15605B0;\n\tTue, 14 Jul 2020 23:43:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C192605AC\n\tfor ;\n\tTue, 14 Jul 2020 23:43:37 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1128771D;\n\tTue, 14 Jul 2020 23:43:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dfWVG3Eo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594763017;\n\tbh=l+54YgmSHfWs5YVKdKqi/zKczjETCUruzym3P8Ls5M0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dfWVG3EoziK8TSJuyXFx/mcUKs8UqMH54zR3LIWri0w0fiRvTsXmACmlOV9NwbphM\n\t3kQiULHNUmcYHws0tXfrf9WSffWcQTEz7D+eftoKyhr+hVpLfnxHkz8bItYJ2Gs+2u\n\t1f4OQXEHQdFdpLUeirt8vcrCSpEeSHEyqErdA4UM=","Date":"Wed, 15 Jul 2020 00:43:30 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200714214330.GF5854@pendragon.ideasonboard.com>","References":"<20200714104212.48683-1-jacopo@jmondi.org>\n\t<20200714104212.48683-17-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200714104212.48683-17-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 16/20] libcamera: ipu3: Remove camera_\n\tfrom IPU3CameraConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]