[{"id":11391,"web_url":"https://patchwork.libcamera.org/comment/11391/","msgid":"<20200714214523.GG5854@pendragon.ideasonboard.com>","date":"2020-07-14T21:45:23","subject":"Re: [libcamera-devel] [PATCH 15/20] libcamera: ipu3: Remove streams\n\tfrom IPU3CameraConfiguration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Jul 14, 2020 at 12:42:07PM +0200, Jacopo Mondi wrote:\n> The IPU3CameraConfiguration::streams_ field was used to keep an\n> association between the StreamConfiguration and the assigned streams\n> before CameraConfiguration::setStream() was called at configure() time.\n> \n> The stream assignment was based on the order in which elements were\n> inserted in the vector, implementing a fragile association between\n> streams and their intended configurations.\n> \n> As it is now possible to assign streams at validation time, there is no\n> need to keep that association in place, and the streams_ vector is now\n> unused.\n> \n> Remove it and the associated accessor method from the\n> IPU3CameraConfiguration class.\n> \n> Reviewed-by: Niklas Söderlund \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 1161987a4322..2d8b3c501294 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -67,7 +67,6 @@ public:\n> \tStatus validate() override;\n> \n> \tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; };\n> -\tconst std::vector &streams() { return streams_; }\n> \n> private:\n> \t/*\n> @@ -79,7 +78,6 @@ private:\n> \tconst IPU3CameraData *data_;\n> \n> \tStreamConfiguration cio2Configuration_;\n> -\tstd::vector streams_;\n> };\n> \n> class PipelineHandlerIPU3 : public PipelineHandler","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1802FBD792\n\tfor ;\n\tTue, 14 Jul 2020 21:45:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A16DD60906;\n\tTue, 14 Jul 2020 23:45:31 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4AA43605AC\n\tfor ;\n\tTue, 14 Jul 2020 23:45:30 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BBA6B71D;\n\tTue, 14 Jul 2020 23:45:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WFrV3nN0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594763129;\n\tbh=AC+CVimci5g0fU7IwXrWAsge4woFz0oEzmySS0tDhCg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WFrV3nN0cTdIi4VOifgbzX18pUSm5s38wF6mo9fckNi2sGQuAqajPfevYMuHhjH9d\n\t3xddJGFmWFnnlE/YQdG0ode4xyw1ltRo2LuehKHF1EbM8AdHWo8/1krBZYo6sXTMZD\n\tmDxqY7UBO69g8SRjHhwaqeh9KEKz456GaqbL/h2g=","Date":"Wed, 15 Jul 2020 00:45:23 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200714214523.GG5854@pendragon.ideasonboard.com>","References":"<20200714104212.48683-1-jacopo@jmondi.org>\n\t<20200714104212.48683-16-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200714104212.48683-16-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 15/20] libcamera: ipu3: Remove streams\n\tfrom IPU3CameraConfiguration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]