[{"id":11389,"web_url":"https://patchwork.libcamera.org/comment/11389/","msgid":"<20200714213342.GE5854@pendragon.ideasonboard.com>","date":"2020-07-14T21:33:42","subject":"Re: [libcamera-devel] [PATCH 13/20] libcamera: ipu3: cio2: Mark\n\tsensor() as const","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Jul 14, 2020 at 12:42:05PM +0200, Jacopo Mondi wrote:\n> Mark the CIO2Device::sensor() method as const, and allow to call it\n> on const instances of the class.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/cio2.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h\n> index f905d97fa79d..0f75b0bc4572 100644\n> --- a/src/libcamera/pipeline/ipu3/cio2.h\n> +++ b/src/libcamera/pipeline/ipu3/cio2.h\n> @@ -49,7 +49,7 @@ public:\n> \tint start();\n> \tint stop();\n> \n> -\tCameraSensor *sensor() { return sensor_; }\n> +\tCameraSensor *sensor() const { return sensor_; }\n\nThis would calling non-const methods of the CameraSensor class from a\ncaller that only has access to a const CIO2Device. Wouldn't it be better\nto have two methods, a const and a non-const one ?\n\n\tCameraSensor *sensor() { return sensor_; }\n\tconst CameraSensor *sensor() const { return sensor_; }\n\nReviewed-by: Laurent Pinchart \n\n> \n> \tint queueBuffer(Request *request, FrameBuffer *rawBuffer);\n> \tvoid tryReturnBuffer(FrameBuffer *buffer);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80A67BD790\n\tfor ;\n\tTue, 14 Jul 2020 21:33:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1C761605B0;\n\tTue, 14 Jul 2020 23:33:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54F10605AC\n\tfor ;\n\tTue, 14 Jul 2020 23:33:49 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C8D3371D;\n\tTue, 14 Jul 2020 23:33:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"df2ENWa/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594762429;\n\tbh=zs7+nyMi9TYZHxMwtLzP79VIL2in4sKeihkHSNHuPRA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=df2ENWa/ehHOCqe7t7NAZuDk3Z96MJCKGLmI+jm6W243cGvgTEzP4N8K1IAJ5tPdW\n\tQSfa6xPG81QptiszsYb98YVcVbBnXjiK+xx9U0Sj9niCNrd3d7bHK2Jf3eBogymoI/\n\teDDkqrQKxuonEM5ZMlBv1SIp0gRnPWUbKOfREgl8=","Date":"Wed, 15 Jul 2020 00:33:42 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"<20200714213342.GE5854@pendragon.ideasonboard.com>","References":"<20200714104212.48683-1-jacopo@jmondi.org>\n\t<20200714104212.48683-14-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200714104212.48683-14-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 13/20] libcamera: ipu3: cio2: Mark\n\tsensor() as const","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]