[{"id":11366,"web_url":"https://patchwork.libcamera.org/comment/11366/","msgid":"<20200713115718.GI2866302@oden.dyn.berto.se>","date":"2020-07-13T11:57:18","subject":"Re: [libcamera-devel] [PATCH 7/9] libcamera: pipeline: raspberrypi:\n\tFix bug in passing configuration to IPA","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Naushir,\n\nThanks for your fix.\n\nOn 2020-07-13 09:47:26 +0100, Naushir Patuck wrote:\n> The counter was not incremented, so multiple streams would only pass the\n> last stream config to the IPA.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 ++---\n> 1 file changed, 2 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index f7e16a6c..e1a74d89 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -848,12 +848,11 @@ int PipelineHandlerRPi::configureIPA(Camera *camera)\n> \t/* Inform IPA of stream configuration and sensor controls. */\n> \tunsigned int i = 0;\n> \tfor (auto const &stream : data->isp_) {\n> -\t\tif (stream.isExternal()) {\n> -\t\t\tstreamConfig[i] = {\n> +\t\tif (stream.isExternal())\n> +\t\t\tstreamConfig[i++] = {\n> \t\t\t\t.pixelFormat = stream.configuration().pixelFormat,\n> \t\t\t\t.size = stream.configuration().size\n> \t\t\t};\n> -\t\t}\n> \t}\n> \tentityControls.emplace(0, data->unicam_[Unicam::Image].dev()->controls());\n> \tentityControls.emplace(1, data->isp_[Isp::Input].dev()->controls());\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E375BD790\n\tfor ;\n\tMon, 13 Jul 2020 11:57:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 349CA6055F;\n\tMon, 13 Jul 2020 13:57:21 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA41860553\n\tfor ;\n\tMon, 13 Jul 2020 13:57:19 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id e8so17382294ljb.0\n\tfor ;\n\tMon, 13 Jul 2020 04:57:19 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tl12sm4050016ljj.43.2020.07.13.04.57.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 13 Jul 2020 04:57:18 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"1Rcgapcc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=rxFy4qVFf8RSfC2jjRsskwkn4v9BPMTslx3LYhGUbc4=;\n\tb=1RcgapccD844vIH7eYUG4UlYZ2ayeixKro70lebF3fi9QxpbP25zPKoxLqtM9xHS3n\n\tstVATMs5+exLZqgSNH1/JQm9F8N2mM3TI+/OqeTnH4UDTa4MU6WEcjdzwPJ1+rjvun2j\n\ty0818gRAbnt9bwim4vU6Xn5DnBkR4UZcH7pMui4PKah5cM9g85Lkw19EZ7RxSJCggkVa\n\tEcOkK3hwiVh4JLZZLf+UGP0wAdsDBA2ZHUP0504Hjnn7Z9dpyRuOKiM6SG6ZkvJGlBPm\n\tlmqnYenA+ZTnBhZiyZqhZpGl8lLkIK5FxRFyKuPwVY//n0u41Fla+CXSR9+R8PIj28FP\n\tcvaw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=rxFy4qVFf8RSfC2jjRsskwkn4v9BPMTslx3LYhGUbc4=;\n\tb=YGEiCsgI7/x4+ZszQ+QWK7PyrEWIPF/Q0q9eS4XAiNy5rOJXjy+Pw2sujvkZM/4Lko\n\tgxrra1c4aYinBq5B7uFeRqJ26bLKEFAArk+WhlBQFrPKA0mHRatoNn+h2jy9FQP1t9IT\n\tjO1hein3xi4KARTcmuN1qLqs4sPotXwOmlo0iXWY7jJ/6rYDq5oWXR9wdZ3KDJb/NJq4\n\t8qKZuhXItE/1ekkWMQFkrqb+GtxcZ6/yzIsssxTHVcqJWtP2MVKv27g2JZeIRyKU/I4J\n\tOVpxioWkJgeozbgpcFUlb6321l/uEPecIx3TUnP04GOCULAtJUeSCCVmhflyBfzstGbL\n\tJ/OA==","X-Gm-Message-State":"AOAM5335yzaPoGpM/l/UqpfyYkil/XGtA+1LzuhtdJFsp0IM3eeo2QZa\n\t3Lzy7dyOjrzli/uvZSRwRHP7qK/zmSg=","X-Google-Smtp-Source":"ABdhPJwpERtTkevTasBcBkqzt/HT4PBWGIZCWUCN+NGtij0gyRP6o6ngbBFZN1KLbalkFYMJ0oPlew==","X-Received":"by 2002:a2e:b16c:: with SMTP id\n\ta12mr48032753ljm.146.1594641439224; \n\tMon, 13 Jul 2020 04:57:19 -0700 (PDT)","Date":"Mon, 13 Jul 2020 13:57:18 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Naushir Patuck ","Message-ID":"<20200713115718.GI2866302@oden.dyn.berto.se>","References":"<20200713084727.232422-1-naush@raspberrypi.com>\n\t<20200713084727.232422-8-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200713084727.232422-8-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 7/9] libcamera: pipeline: raspberrypi:\n\tFix bug in passing configuration to IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]