{"id":8757,"url":"https://patchwork.libcamera.org/api/patches/8757/?format=json","web_url":"https://patchwork.libcamera.org/patch/8757/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200713084727.232422-8-naush@raspberrypi.com>","date":"2020-07-13T08:47:26","name":"[libcamera-devel,7/9] libcamera: pipeline: raspberrypi: Fix bug in passing configuration to IPA","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"4fec1121eec6172e51e221efab14d27197a45f78","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8757/mbox/","series":[{"id":1100,"url":"https://patchwork.libcamera.org/api/series/1100/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1100","date":"2020-07-13T08:47:18","name":"Zero-copy RAW stream work","version":1,"mbox":"https://patchwork.libcamera.org/series/1100/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8757/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8757/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C920CBD790\n\tfor ;\n\tMon, 13 Jul 2020 08:48:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B97C605C1;\n\tMon, 13 Jul 2020 10:48:06 +0200 (CEST)","from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 167F46055F\n\tfor ;\n\tMon, 13 Jul 2020 10:48:05 +0200 (CEST)","by mail-wm1-x343.google.com with SMTP id q15so12483443wmj.2\n\tfor ;\n\tMon, 13 Jul 2020 01:48:05 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tg14sm23203357wrm.93.2020.07.13.01.48.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 13 Jul 2020 01:48:03 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"o+mLV7RT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=uvNMA7md3GEsF7CgFbQDovALSUX1eX1X5TxmnWVUmYg=;\n\tb=o+mLV7RTU+w1vO00nHATSv2+cMmlc85bZccjRARF+D/qu5buVEtLrF8nu2iS6n9+Mu\n\tX4CLzITU2PMXUw6LX8hgjXE67yySzSeil2YLIFoTQ0QnN1EYzhIdDX2BG3TyhZS8ed2g\n\tMFNWI05Z9o8bwGLTWe+bX/HnEQgCnc+UprC0fyesKiLwF5sM9KsK4o5IaG9/UyuWtGJ7\n\toSBx52+KswEaUEdpDZTBim7ncHK8UWrVSVSYxvoHV1HaRgEU22Niaz4vvxijBejdJJik\n\tBaAaYaCplpf6ibu89Dc1hczMXuSc3qArr8FudZUWC4pd/7iTV5LWYpm++4fJRNUloZUA\n\tTTgQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=uvNMA7md3GEsF7CgFbQDovALSUX1eX1X5TxmnWVUmYg=;\n\tb=f5Mw9ynFrRS+xezE6j0ETPEpy33OmVvubOmqWlX/hLTKVJdWihgVuJipooto4gKyxX\n\tPKe+NfHXqKY/AyF7bSWk1TnaNZLGLzUDPrclgi9/iS2lIR9m7ssgzC59sf1zgvtIns7i\n\t9Vl2WMwvsOaHLAVIFPIzYgsEAr5GRDXT1AoA5020vR4F4J+zWvyxdc9iC+myLejxN8BW\n\tWBGdJzFRSK/i//a7fMdh4XAYq2qQ4YmV8Ikauu6wc6nB3b0rSvIcHWtF/pGhSgqZ6B8n\n\tLTV+FtbmZMcMngqBAF518zXKs6mtpNoOeAYKPjt/yFKC+FKJOJbEFfQ3rGFSQ4QSlKJF\n\tFwfQ==","X-Gm-Message-State":"AOAM532ZUF1h+WGdT5/cvaHVJAbSSLkbr6hzwWUklX8b02ohPo4y11AA\n\t/VMxuebVe+gOAstRfdFRfQgfkV4a5I8=","X-Google-Smtp-Source":"ABdhPJyEXf2Bjcrygmrss6VyD4sq9SiduIMUBXvrh13+6Sfbl4BKH1jhmrrsEjfdOx2HwmqwpB5qKw==","X-Received":"by 2002:a7b:c14a:: with SMTP id\n\tz10mr17215192wmi.19.1594630084436; \n\tMon, 13 Jul 2020 01:48:04 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 13 Jul 2020 09:47:26 +0100","Message-Id":"<20200713084727.232422-8-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200713084727.232422-1-naush@raspberrypi.com>","References":"<20200713084727.232422-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 7/9] libcamera: pipeline: raspberrypi: Fix\n\tbug in passing configuration to IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The counter was not incremented, so multiple streams would only pass the\nlast stream config to the IPA.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex f7e16a6c..e1a74d89 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -848,12 +848,11 @@ int PipelineHandlerRPi::configureIPA(Camera *camera)\n \t/* Inform IPA of stream configuration and sensor controls. */\n \tunsigned int i = 0;\n \tfor (auto const &stream : data->isp_) {\n-\t\tif (stream.isExternal()) {\n-\t\t\tstreamConfig[i] = {\n+\t\tif (stream.isExternal())\n+\t\t\tstreamConfig[i++] = {\n \t\t\t\t.pixelFormat = stream.configuration().pixelFormat,\n \t\t\t\t.size = stream.configuration().size\n \t\t\t};\n-\t\t}\n \t}\n \tentityControls.emplace(0, data->unicam_[Unicam::Image].dev()->controls());\n \tentityControls.emplace(1, data->isp_[Isp::Input].dev()->controls());\n","prefixes":["libcamera-devel","7/9"]}