[{"id":11364,"web_url":"https://patchwork.libcamera.org/comment/11364/","msgid":"<20200713114237.GG2866302@oden.dyn.berto.se>","date":"2020-07-13T11:42:37","subject":"Re: [libcamera-devel] [PATCH 5/9] libcamera: pipeline: raspberrypi:\n\tRemove const qualifier from RPiStream","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Naushir,\n\nThanks for your work.\n\nOn 2020-07-13 09:47:24 +0100, Naushir Patuck wrote:\n> For the zero-copy RAW capture feature, the RPiStream will have to be\n> modified. Remove the const qualifier in anticipation of the future\n> commits for this feature.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------\n> 1 file changed, 6 insertions(+), 6 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index a613ce65..2f4255a4 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -163,7 +163,7 @@ public:\n> \tvoid ispOutputDequeue(FrameBuffer *buffer);\n> \n> \tvoid clearIncompleteRequests();\n> -\tvoid handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream);\n> +\tvoid handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream);\n> \tvoid handleState();\n> \n> \tCameraSensor *sensor_;\n> @@ -1120,12 +1120,12 @@ done:\n> \n> void RPiCameraData::unicamBufferDequeue(FrameBuffer *buffer)\n> {\n> -\tconst RPi::RPiStream *stream = nullptr;\n> +\tRPi::RPiStream *stream = nullptr;\n> \n> \tif (state_ == State::Stopped)\n> \t\treturn;\n> \n> -\tfor (RPi::RPiStream const &s : unicam_) {\n> +\tfor (RPi::RPiStream &s : unicam_) {\n> \t\tif (s.findFrameBuffer(buffer)) {\n> \t\t\tstream = &s;\n> \t\t\tbreak;\n> @@ -1186,12 +1186,12 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n> \n> void RPiCameraData::ispOutputDequeue(FrameBuffer *buffer)\n> {\n> -\tconst RPi::RPiStream *stream = nullptr;\n> +\tRPi::RPiStream *stream = nullptr;\n> \n> \tif (state_ == State::Stopped)\n> \t\treturn;\n> \n> -\tfor (RPi::RPiStream const &s : isp_) {\n> +\tfor (RPi::RPiStream &s : isp_) {\n> \t\tif (s.findFrameBuffer(buffer)) {\n> \t\t\tstream = &s;\n> \t\t\tbreak;\n> @@ -1272,7 +1272,7 @@ void RPiCameraData::clearIncompleteRequests()\n> \t}\n> }\n> \n> -void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream)\n> +void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream)\n> {\n> \tif (stream->isExternal()) {\n> \t\tif (!dropFrameCount_) {\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7120DBD790\n\tfor ;\n\tMon, 13 Jul 2020 11:42:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41F406048D;\n\tMon, 13 Jul 2020 13:42:39 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 98A5D60483\n\tfor ;\n\tMon, 13 Jul 2020 13:42:38 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id s9so17273366ljm.11\n\tfor ;\n\tMon, 13 Jul 2020 04:42:38 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\t132sm4567288lfl.37.2020.07.13.04.42.37\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 13 Jul 2020 04:42:37 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"ixDzdACn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Wdnd+N81ILxVnJAw5drC5krpHtz3eBijit0H6+QyhBc=;\n\tb=ixDzdACn0wc53dE9cCQrlaGGf064zP9slW7nrQ5SvakMgFFr+DCUPuyaxZrxbOx5Kf\n\t/wXSR76/2v6dKrqZIVnYUnTtNPHAdJ8BghIkHVDKs2uz2VJdicz38hO9b6RON1WmuhcA\n\t4CTdnBy3nsjkdOZ+6Qfw936Cw/sJpOENoCZbpt8U5BCUZQA48zqIQV/kRaPHqvKRTpf+\n\tbTb0nVhZkElQrWLP96dVxKpaywWqg4wKVJys4JNXbpJZ0W6ASVt76h8bpqYzWKrOnqQy\n\t64SftafpTCcM3cSJKScGTte/cDKtkcSo2zrW+Cw7ekF9hOKN2jf1g4YxznSAIJX+ye67\n\tZSxw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Wdnd+N81ILxVnJAw5drC5krpHtz3eBijit0H6+QyhBc=;\n\tb=do+Lwm37s1V0cM/PHTuywL3eYtVc74MCZ8COzq5wET00LGtvbezqscj1xyTu4YbZWL\n\tsAa+wIxRy5tAUsvweKiSDL6FzM6pPuNDBeztHp8UEDU2q13J4axLAOv52JKsRJK7MNgP\n\tC2zrVJwsrWKcjDzp8lh24IFj863FWhCruvP3mMcUB6Nje8hhOlZl7zM1mNvWco+hswiZ\n\tEAF7tcdNeQ4FY90unnyuzdGpylpn9rsmnr8CffDNBK4f8RsRNTMXCTFKg0Z2B6Byhpr2\n\tu1tkaADPVjOFqwZZVEc/4ZxmBeNRhQK0bVXkn8HserN2cO7FzvTFd0VWDmvQD4OxELm6\n\tYGqw==","X-Gm-Message-State":"AOAM5320CFKxqnumrhQ21cO5fdIM7/FdJLY9jbW+cem/O5edsH0+GaPG\n\tDlpB9FS/d7noGruNZq86q8VY5A==","X-Google-Smtp-Source":"ABdhPJzybLVcavTlphNsdN8iYqxKo/GcejHgaai+flTID2Bi+c0qvS27OvuqCgz+Rru0EkZmvmcYgQ==","X-Received":"by 2002:a2e:a17c:: with SMTP id\n\tu28mr39187868ljl.140.1594640558080; \n\tMon, 13 Jul 2020 04:42:38 -0700 (PDT)","Date":"Mon, 13 Jul 2020 13:42:37 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Naushir Patuck ","Message-ID":"<20200713114237.GG2866302@oden.dyn.berto.se>","References":"<20200713084727.232422-1-naush@raspberrypi.com>\n\t<20200713084727.232422-6-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200713084727.232422-6-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 5/9] libcamera: pipeline: raspberrypi:\n\tRemove const qualifier from RPiStream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]