{"id":8755,"url":"https://patchwork.libcamera.org/api/patches/8755/?format=json","web_url":"https://patchwork.libcamera.org/patch/8755/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200713084727.232422-6-naush@raspberrypi.com>","date":"2020-07-13T08:47:24","name":"[libcamera-devel,5/9] libcamera: pipeline: raspberrypi: Remove const qualifier from RPiStream","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"d3a8251a2f5e74688c84cc50425133bda0b6e516","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/8755/mbox/","series":[{"id":1100,"url":"https://patchwork.libcamera.org/api/series/1100/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1100","date":"2020-07-13T08:47:18","name":"Zero-copy RAW stream work","version":1,"mbox":"https://patchwork.libcamera.org/series/1100/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/8755/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/8755/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF3E8BD790\n\tfor ;\n\tMon, 13 Jul 2020 08:48:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BBA126055F;\n\tMon, 13 Jul 2020 10:48:05 +0200 (CEST)","from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23075605C2\n\tfor ;\n\tMon, 13 Jul 2020 10:48:03 +0200 (CEST)","by mail-wm1-x32e.google.com with SMTP id 22so12491504wmg.1\n\tfor ;\n\tMon, 13 Jul 2020 01:48:03 -0700 (PDT)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tg14sm23203357wrm.93.2020.07.13.01.48.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 13 Jul 2020 01:48:01 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"dLhfHdn/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=XqHsiNLBAY2ZmnuKeHpy0MW/ly4AmD1Jxn/qN65J8x8=;\n\tb=dLhfHdn/MrkyueYAD2ydUhhIFDcagtqZLEnkDQOolzhHh3+vd/LHX33BaVp3snQc96\n\tMCa0rT1TijVZmIzxaiufRYobpNwSxnXPjHEdYRhdaIVwOBI2V8M77W1MoUWi4lNJ+SXr\n\tZJyL5ZC4vl6ufUYktkUqMikLbImXl4OHyYdBGUAR9YUR65VRi8Cms10UjrlqKs3OV2me\n\tOvDHl1IWaFw6jhgbGX0zGJMsgveoGS+rmOb8ke1gPl98blEjcSnyWNHTnjnMBZEL2M7d\n\tmYJZi9pQSGwdNs5VJpS+5xN3YD+x4j/PQkQRMuEyQ7UrZJrm97Yr8tkFwSeiuDQ4siaQ\n\tYgmA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=XqHsiNLBAY2ZmnuKeHpy0MW/ly4AmD1Jxn/qN65J8x8=;\n\tb=QxucBJRa57xFmOXT7hvpoNJSIuTj0aZ4ql49z1JzkuiU7D5grLna5semQocqhuWYWQ\n\tkpvPXyO9xW9ZFSbxRw31/GAafoHE1WBFYvwbgjKkBuXAILigxFUUyAkQW1/wfR06zn3N\n\t0l1zJ0UBKELiLAhAdChXzHrIVdM53osOAhvpLhAH0NvTeTDpZ6cE/58Ir7PWAWtURu0Y\n\t2YvVPGhhHS1Fcsefz8NsswMAFCgrpuusgAJ1UG11xcFNZuh00YVFxkHfBum6LpwYWyap\n\twqtEtn0gjyCNjVgUkpr/Di2zwIbCQIs0+iovTyrvHUDBtusqwEnMLPmO6X6/rBLeCu7V\n\taNTA==","X-Gm-Message-State":"AOAM530cvJbvSwzJIH3jI0PdfdVmF/4tygTLgsxJitA/isFQMqkvZHf6\n\tO4FtnPkkz/2ez7uz2rStUy+4Ng4XWxM=","X-Google-Smtp-Source":"ABdhPJwfyr+7+vTejQ6MLw3KlDnD87XN3B1JxSqGUAt1KUORs78gqOZiHtb9GeMtW8wVZ84oOOG5Og==","X-Received":"by 2002:a05:600c:218f:: with SMTP id\n\te15mr16636207wme.63.1594630082474; \n\tMon, 13 Jul 2020 01:48:02 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 13 Jul 2020 09:47:24 +0100","Message-Id":"<20200713084727.232422-6-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20200713084727.232422-1-naush@raspberrypi.com>","References":"<20200713084727.232422-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 5/9] libcamera: pipeline: raspberrypi:\n\tRemove const qualifier from RPiStream","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"For the zero-copy RAW capture feature, the RPiStream will have to be\nmodified. Remove the const qualifier in anticipation of the future\ncommits for this feature.\n\nSigned-off-by: Naushir Patuck \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex a613ce65..2f4255a4 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -163,7 +163,7 @@ public:\n \tvoid ispOutputDequeue(FrameBuffer *buffer);\n \n \tvoid clearIncompleteRequests();\n-\tvoid handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream);\n+\tvoid handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream);\n \tvoid handleState();\n \n \tCameraSensor *sensor_;\n@@ -1120,12 +1120,12 @@ done:\n \n void RPiCameraData::unicamBufferDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : unicam_) {\n+\tfor (RPi::RPiStream &s : unicam_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1186,12 +1186,12 @@ void RPiCameraData::ispInputDequeue(FrameBuffer *buffer)\n \n void RPiCameraData::ispOutputDequeue(FrameBuffer *buffer)\n {\n-\tconst RPi::RPiStream *stream = nullptr;\n+\tRPi::RPiStream *stream = nullptr;\n \n \tif (state_ == State::Stopped)\n \t\treturn;\n \n-\tfor (RPi::RPiStream const &s : isp_) {\n+\tfor (RPi::RPiStream &s : isp_) {\n \t\tif (s.findFrameBuffer(buffer)) {\n \t\t\tstream = &s;\n \t\t\tbreak;\n@@ -1272,7 +1272,7 @@ void RPiCameraData::clearIncompleteRequests()\n \t}\n }\n \n-void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, const RPi::RPiStream *stream)\n+void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, RPi::RPiStream *stream)\n {\n \tif (stream->isExternal()) {\n \t\tif (!dropFrameCount_) {\n","prefixes":["libcamera-devel","5/9"]}