[{"id":11363,"web_url":"https://patchwork.libcamera.org/comment/11363/","msgid":"<20200713114127.GF2866302@oden.dyn.berto.se>","date":"2020-07-13T11:41:27","subject":"Re: [libcamera-devel] [PATCH 4/9] libcamera: pipeline: raspberrypi:\n\tIncrease the number of RAW buffers","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Naushir,\n\nThanks for your work.\n\nOn 2020-07-13 09:47:23 +0100, Naushir Patuck wrote:\n> Increase the number of expected RAW buffers in the stream configuration\n> to 2. This will avoid dropping Unicam frames when exporting RAW streams.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index 65c8557d..a613ce65 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -394,7 +394,7 @@ CameraConfiguration *PipelineHandlerRPi::generateConfiguration(Camera *camera,\n> \t\t\tsensorFormat = findBestMode(fmts, size);\n> \t\t\tpixelFormat = sensorFormat.fourcc.toPixelFormat();\n> \t\t\tASSERT(pixelFormat.isValid());\n> -\t\t\tbufferCount = 1;\n> +\t\t\tbufferCount = 2;\n> \t\t\trawCount++;\n> \t\t\tbreak;\n> \n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8B6ABD792\n\tfor ;\n\tMon, 13 Jul 2020 11:41:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 96AD2605C5;\n\tMon, 13 Jul 2020 13:41:30 +0200 (CEST)","from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4E7860483\n\tfor ;\n\tMon, 13 Jul 2020 13:41:28 +0200 (CEST)","by mail-lj1-x242.google.com with SMTP id h19so17256742ljg.13\n\tfor ;\n\tMon, 13 Jul 2020 04:41:28 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\te13sm4591351lfs.33.2020.07.13.04.41.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 13 Jul 2020 04:41:27 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"YUL2vHL3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=6qdoquVc2onHREO7lof7PH63B/ZX8aYca2qKfnIevnA=;\n\tb=YUL2vHL36nDQOlf4eK+h3HfanXwXG/1JaTgsPR1KtTQb9r6Tpv1CIKBf5ZeJR98Vjo\n\ttYzqizFSCP6dBkHXpW6wpdMqaz4CUAZ2XNhm426x/Or9i27ZYt56JBK2jWMCMxPQhvnC\n\tpkilvz9wEXFNna0PhMRNmMz7JAKkuumh45GgkYE5SSO+Bh76a9K9gQv2y1ax45cli1sx\n\tCaIROjRPDqf/3kglxaB89OS0QfjAkJF/fI/WJr+ElYpPTfC6z9HgMNkFYP3QCQCPY3nd\n\ts8JD/CkD94ryGH4Qpn0dCLAUROuTKrmYENgXjD4nBOoxA9V+QLXC0uA3VrSf3j++QzHr\n\tpf8Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=6qdoquVc2onHREO7lof7PH63B/ZX8aYca2qKfnIevnA=;\n\tb=OIrPu/7trbANNQvVTLICv4a924jjRyL1O4UPmjFawT/OMDldX306zM/we/4dM+JZfQ\n\t6UP7m8aAyiWMs21w6x8W2Z1rVmS1EEkHCm74X0yZAEZr4vnJEyRmgo9TR2Sidtq56fgp\n\tyMVglJLcOrDHH+sEkHhOQ2Yi/fnvzDafTV11eWwpYsGZBRXqZQ2KoqWJPnBEj17kPWdF\n\tDq5hDwThKEYdZmCNC8eTIEqhsEJeCnszLUO1NCQUSvRdt7JNCA+6EfaJTDNmDxSMcIO0\n\tYqurC/aJX4o6yWl6e3VUXdwUDHpLqruy/1tV5s6sWMt8ag8SjOWt9Od+UwBofvyV1CSW\n\tNXHw==","X-Gm-Message-State":"AOAM533K6PN0SuvLWQXhtIw1ysw1BuAF5D4dv5ob4/G3+pv4mMkLfa0Q\n\tTG2RaCCW3+fGzio+FBH599G3d71muL8=","X-Google-Smtp-Source":"ABdhPJwvf/+7NA3x7WZ94wTYGW0vMmywftAbaFJdfKLsnB4uOLTsc8I8EDG48ysxdxFiChuDXzYVGw==","X-Received":"by 2002:a2e:8545:: with SMTP id\n\tu5mr40416295ljj.258.1594640488378; \n\tMon, 13 Jul 2020 04:41:28 -0700 (PDT)","Date":"Mon, 13 Jul 2020 13:41:27 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Naushir Patuck ","Message-ID":"<20200713114127.GF2866302@oden.dyn.berto.se>","References":"<20200713084727.232422-1-naush@raspberrypi.com>\n\t<20200713084727.232422-5-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200713084727.232422-5-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 4/9] libcamera: pipeline: raspberrypi:\n\tIncrease the number of RAW buffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]