[{"id":11348,"web_url":"https://patchwork.libcamera.org/comment/11348/","msgid":"<13a4b138-dfa5-b0af-8d48-e4f563a70693@ideasonboard.com>","date":"2020-07-12T19:46:16","subject":"Re: [libcamera-devel] [PATCH 3/4] test: file: Add file creation test","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 12/07/2020 15:44, Laurent Pinchart wrote:\n> Add a test to verify file creation with File::open(). The test is\n> expected to fail as the File::open() implementation is not correct.\n> \n\nI guess as the previous two patches are not yet integrated, you could\nequally just merge 4/4 into 1/4 before and then it wouldn't fail ...\n\nBut given the patches were done at different times, I can understand why\nyou've built this on top :-)\n\n\nStill,\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> test/file.cpp | 28 ++++++++++++++++++++++++++--\n> 1 file changed, 26 insertions(+), 2 deletions(-)\n> \n> diff --git a/test/file.cpp b/test/file.cpp\n> index 7688a9dc224a..f458f355ccad 100644\n> --- a/test/file.cpp\n> +++ b/test/file.cpp\n> @@ -31,6 +31,7 @@ protected:\n> \t\t\treturn TestFail;\n> \n> \t\tclose(fd);\n> +\t\tunlink(fileName_.c_str());\n> \n> \t\treturn TestPass;\n> \t}\n> @@ -191,14 +192,37 @@ protected:\n> \n> \t\tfile.close();\n> \n> +\t\t/* Test file creation. */\n> +\t\tfile.setFileName(fileName_);\n> +\n> +\t\tif (file.exists()) {\n> +\t\t\tcerr << \"Temporary file already exists\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (file.open(File::ReadOnly)) {\n> +\t\t\tcerr << \"Read-only open succeeded on nonexistent file\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (!file.open(File::WriteOnly)) {\n> +\t\t\tcerr << \"Write-only open failed on nonexistent file\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (!file.exists()) {\n> +\t\t\tcerr << \"Write-only open failed to create file\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tfile.close();\n> +\n> \t\t/* Test read and write. */\n> \t\tstd::array buffer = { 0 };\n> \n> \t\tstrncpy(reinterpret_cast(buffer.data()), \"libcamera\",\n> \t\t\tbuffer.size());\n> \n> -\t\tfile.setFileName(fileName_);\n> -\n> \t\tif (file.read(buffer) >= 0) {\n> \t\t\tcerr << \"Read succeeded on closed file\" << endl;\n> \t\t\treturn TestFail;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E6DEBD792\n\tfor ;\n\tSun, 12 Jul 2020 19:46:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9FB4F60589;\n\tSun, 12 Jul 2020 21:46:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 186E66055B\n\tfor ;\n\tSun, 12 Jul 2020 21:46:22 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 537F824A;\n\tSun, 12 Jul 2020 21:46:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q6dXBZGy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594583181;\n\tbh=gk032mCF2FHAZTNnDUMdJxU06A/9+ss73B2V0LAavHs=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=q6dXBZGyKUs61xPRIaioNKNWeMv+GDaHl8Tnw7vIQZEvYW4/5gU1LJJt6n6Vvt8za\n\tNBBHFUXnZa/BJ3Cgg5yAUMRguKSS16qw1CfdcnaYXq0VIdfjbV5g3qEESS2SlSC1nZ\n\te71/EJpOuSOn2lah/Uw19zOg2rAaV+8RdobWMMFY=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20200712144419.21457-1-laurent.pinchart@ideasonboard.com>\n\t<20200712144419.21457-3-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<13a4b138-dfa5-b0af-8d48-e4f563a70693@ideasonboard.com>","Date":"Sun, 12 Jul 2020 20:46:16 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.8.0","MIME-Version":"1.0","In-Reply-To":"<20200712144419.21457-3-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 3/4] test: file: Add file creation test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11353,"web_url":"https://patchwork.libcamera.org/comment/11353/","msgid":"<20200713065801.GG1498036@oden.dyn.berto.se>","date":"2020-07-13T06:58:01","subject":"Re: [libcamera-devel] [PATCH 3/4] test: file: Add file creation test","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-07-12 17:44:18 +0300, Laurent Pinchart wrote:\n> Add a test to verify file creation with File::open(). The test is\n> expected to fail as the File::open() implementation is not correct.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> test/file.cpp | 28 ++++++++++++++++++++++++++--\n> 1 file changed, 26 insertions(+), 2 deletions(-)\n> \n> diff --git a/test/file.cpp b/test/file.cpp\n> index 7688a9dc224a..f458f355ccad 100644\n> --- a/test/file.cpp\n> +++ b/test/file.cpp\n> @@ -31,6 +31,7 @@ protected:\n> \t\t\treturn TestFail;\n> \n> \t\tclose(fd);\n> +\t\tunlink(fileName_.c_str());\n> \n> \t\treturn TestPass;\n> \t}\n> @@ -191,14 +192,37 @@ protected:\n> \n> \t\tfile.close();\n> \n> +\t\t/* Test file creation. */\n> +\t\tfile.setFileName(fileName_);\n> +\n> +\t\tif (file.exists()) {\n> +\t\t\tcerr << \"Temporary file already exists\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (file.open(File::ReadOnly)) {\n> +\t\t\tcerr << \"Read-only open succeeded on nonexistent file\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (!file.open(File::WriteOnly)) {\n> +\t\t\tcerr << \"Write-only open failed on nonexistent file\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (!file.exists()) {\n> +\t\t\tcerr << \"Write-only open failed to create file\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tfile.close();\n> +\n> \t\t/* Test read and write. */\n> \t\tstd::array buffer = { 0 };\n> \n> \t\tstrncpy(reinterpret_cast(buffer.data()), \"libcamera\",\n> \t\t\tbuffer.size());\n> \n> -\t\tfile.setFileName(fileName_);\n> -\n> \t\tif (file.read(buffer) >= 0) {\n> \t\t\tcerr << \"Read succeeded on closed file\" << endl;\n> \t\t\treturn TestFail;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31BC9BD792\n\tfor ;\n\tMon, 13 Jul 2020 06:58:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A53ED605AE;\n\tMon, 13 Jul 2020 08:58:04 +0200 (CEST)","from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2EB1605AA\n\tfor ;\n\tMon, 13 Jul 2020 08:58:02 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id g2so7928479lfb.0\n\tfor ;\n\tSun, 12 Jul 2020 23:58:02 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tw15sm4432091lff.25.2020.07.12.23.58.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 12 Jul 2020 23:58:01 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"ruLEw/ea\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=LTGdys24n74CkNCbpQD3OZxCrMYeee8bKGMcdwujql8=;\n\tb=ruLEw/ealMSX9pssT6mc1aqsmDVzuYuIIqRQsFehklFcPiQTiOGMzBgsIueXM92Qva\n\twNph08I6VBRWuuLO6o6RvgTlL9Fz4BMW7DfowfRibMq4A0hEkq18zcwXsY8FUYMROWmu\n\tle6q4RvZt1pN+zE1pwb4P5BDPDeNxboA2wgDhX95gy5NflUM/ddGX4aBp2enbYo5cOhP\n\tn/BuZ13QI7Ny4KhOFj1QHlYRRjiMwgpB5BU+z4kWUn8NYuwu683HLLiXjX7V/FfHEYhU\n\tTaFYY8PBllBVHwzlJHbPBV7KqT0whAhIQ9HxEH1FQ8PW1kKPo70Cc07opXLHCaSypDa5\n\tUPlA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=LTGdys24n74CkNCbpQD3OZxCrMYeee8bKGMcdwujql8=;\n\tb=EoFXtiBop0w/+10OOTSqgVRbK3WPzk8V0OAX7jR6Mt6eQ+sFH3Ct6+UaOTEwW9fQgL\n\tJ1v70qFJ7kU9iBSS00wMzypWPNj5Mpedf1QlsDp6Td9XBJkjSIHtuRnRsbz1KX32+tSn\n\tWYhbTstOCmlZM6NFfO7WjWMXVPhETPRu/LIlPy10dbVh2eJok49jBjpPhfhKvinWyupc\n\toGLzELBvuFknhTlHZIoIEk+5Ef7j9ou5wdmYupgpN//Z4lp67tOy4S9egHuwFeFsAdgF\n\taYyKSmjoQEqA0K3AUzlmdpoG/DG/0uDdPs9jRiMHD4Hh4d5vGD+47tUA8wvQrrzUEnUr\n\tF58w==","X-Gm-Message-State":"AOAM530DL5SkbZq7FpLSwDfeHu+qs25+N8Jz94dIgn58Xs62hWFDag2T\n\tjfEEbUhVHknl5BlSymx/Nr/sZNHgxbM=","X-Google-Smtp-Source":"ABdhPJwPc8zhSO8QUa4NIlAbxEBm7WAnZhS4/UAjiuEYPXkMlD1WLBgVoJDnBxrX0LEV2R/AHYMvuQ==","X-Received":"by 2002:ac2:5f07:: with SMTP id 7mr52856010lfq.132.1594623482196;\n\tSun, 12 Jul 2020 23:58:02 -0700 (PDT)","Date":"Mon, 13 Jul 2020 08:58:01 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"<20200713065801.GG1498036@oden.dyn.berto.se>","References":"<20200712144419.21457-1-laurent.pinchart@ideasonboard.com>\n\t<20200712144419.21457-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20200712144419.21457-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/4] test: file: Add file creation test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":11359,"web_url":"https://patchwork.libcamera.org/comment/11359/","msgid":"<20200713112730.GA6272@pendragon.ideasonboard.com>","date":"2020-07-13T11:27:30","subject":"Re: [libcamera-devel] [PATCH 3/4] test: file: Add file creation test","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Sun, Jul 12, 2020 at 08:46:16PM +0100, Kieran Bingham wrote:\n> Hi Laurent,\n> \n> On 12/07/2020 15:44, Laurent Pinchart wrote:\n> > Add a test to verify file creation with File::open(). The test is\n> > expected to fail as the File::open() implementation is not correct.\n> \n> I guess as the previous two patches are not yet integrated, you could\n> equally just merge 4/4 into 1/4 before and then it wouldn't fail ...\n> \n> But given the patches were done at different times, I can understand why\n> you've built this on top :-)\n\nIt's also because merging the test that reproduces the issue first\nallows making sure that the test correctly triggers the problem. If you\nmerge the fix first, there's a risk that both the fix and the test could\nbe incorrect, and cancel each other resulting in the test passing.\n\n> Still,\n> \n> Reviewed-by: Kieran Bingham \n> \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > test/file.cpp | 28 ++++++++++++++++++++++++++--\n> > 1 file changed, 26 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/test/file.cpp b/test/file.cpp\n> > index 7688a9dc224a..f458f355ccad 100644\n> > --- a/test/file.cpp\n> > +++ b/test/file.cpp\n> > @@ -31,6 +31,7 @@ protected:\n> > \t\t\treturn TestFail;\n> > \n> > \t\tclose(fd);\n> > +\t\tunlink(fileName_.c_str());\n> > \n> > \t\treturn TestPass;\n> > \t}\n> > @@ -191,14 +192,37 @@ protected:\n> > \n> > \t\tfile.close();\n> > \n> > +\t\t/* Test file creation. */\n> > +\t\tfile.setFileName(fileName_);\n> > +\n> > +\t\tif (file.exists()) {\n> > +\t\t\tcerr << \"Temporary file already exists\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tif (file.open(File::ReadOnly)) {\n> > +\t\t\tcerr << \"Read-only open succeeded on nonexistent file\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tif (!file.open(File::WriteOnly)) {\n> > +\t\t\tcerr << \"Write-only open failed on nonexistent file\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tif (!file.exists()) {\n> > +\t\t\tcerr << \"Write-only open failed to create file\" << endl;\n> > +\t\t\treturn TestFail;\n> > +\t\t}\n> > +\n> > +\t\tfile.close();\n> > +\n> > \t\t/* Test read and write. */\n> > \t\tstd::array buffer = { 0 };\n> > \n> > \t\tstrncpy(reinterpret_cast(buffer.data()), \"libcamera\",\n> > \t\t\tbuffer.size());\n> > \n> > -\t\tfile.setFileName(fileName_);\n> > -\n> > \t\tif (file.read(buffer) >= 0) {\n> > \t\t\tcerr << \"Read succeeded on closed file\" << endl;\n> > \t\t\treturn TestFail;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29C81BD792\n\tfor ;\n\tMon, 13 Jul 2020 11:27:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E6F26605C5;\n\tMon, 13 Jul 2020 13:27:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90C59603A4\n\tfor ;\n\tMon, 13 Jul 2020 13:27:37 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1798FC9;\n\tMon, 13 Jul 2020 13:27:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DVnjf3J9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1594639657;\n\tbh=07Lsdb0Sx2yaDzSUW2F4xotSn4jvQNbOLlZPN9Sd/h0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DVnjf3J9pCAQSPgDF+TMyywhZIwH85i/50eib+HdZYlC5uFtFazGJX172VovuZ5Q4\n\t76+rd/mIU/sd5E2lpalExaChEnIZzob2WdcftmsRDrqwDI7Z/TN0CsaXqq5WSz7y7S\n\tMnilhXDFDvODCEIGxLwkhiLZ9EYRSW5+CyCF1yqM=","Date":"Mon, 13 Jul 2020 14:27:30 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"<20200713112730.GA6272@pendragon.ideasonboard.com>","References":"<20200712144419.21457-1-laurent.pinchart@ideasonboard.com>\n\t<20200712144419.21457-3-laurent.pinchart@ideasonboard.com>\n\t<13a4b138-dfa5-b0af-8d48-e4f563a70693@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<13a4b138-dfa5-b0af-8d48-e4f563a70693@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/4] test: file: Add file creation test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]