[{"id":1254,"web_url":"https://patchwork.libcamera.org/comment/1254/","msgid":"<20190403132059.ae26qpsvndncwbng@uno.localdomain>","date":"2019-04-03T13:20:59","subject":"Re: [libcamera-devel] [PATCH 3/5] test: camera: Remove test for bad\n\tStream IDs","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Wed, Apr 03, 2019 at 03:12:19AM +0200, Niklas Söderlund wrote:\n> In preparation of reworking how a default configuration is retrieved\n> from a camera remove test that stream IDs must be valid as the data type\n> passed to Camera::streamConfiguration() will change. This change is in\n> preparation for an invasive change.\n>\n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Jacopo Mondi \n\n> Reviewed-by: Laurent Pinchart \n> ---\n> test/camera/configuration_default.cpp | 13 -------------\n> 1 file changed, 13 deletions(-)\n>\n> diff --git a/test/camera/configuration_default.cpp b/test/camera/configuration_default.cpp\n> index 53ee021d33ca39b1..856cd415f7a6aec1 100644\n> --- a/test/camera/configuration_default.cpp\n> +++ b/test/camera/configuration_default.cpp\n> @@ -49,19 +49,6 @@ protected:\n> \t\t\treturn TestFail;\n> \t\t}\n>\n> -\t\t/*\n> -\t\t * Test that asking for configuration for an array of bad streams\n> -\t\t * returns an empty list of configurations.\n> -\t\t */\n> -\t\tStream *stream_bad = reinterpret_cast(0xdeadbeef);\n> -\t\tstd::set streams_bad = { stream_bad };\n> -\t\tconf = camera_->streamConfiguration(streams_bad);\n> -\t\tif (!conf.empty()) {\n> -\t\t\tcout << \"Failed to retrieve configuration for bad streams\"\n> -\t\t\t << endl;\n> -\t\t\treturn TestFail;\n> -\t\t}\n> -\n> \t\treturn TestPass;\n> \t}\n> };\n> --\n> 2.21.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC98D600FB\n\tfor ;\n\tWed, 3 Apr 2019 15:20:13 +0200 (CEST)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 724A920003;\n\tWed, 3 Apr 2019 13:20:13 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","Date":"Wed, 3 Apr 2019 15:20:59 +0200","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190403132059.ae26qpsvndncwbng@uno.localdomain>","References":"<20190403011221.12711-1-niklas.soderlund@ragnatech.se>\n\t<20190403011221.12711-4-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"rhf66kuh3xxc4f44\"","Content-Disposition":"inline","In-Reply-To":"<20190403011221.12711-4-niklas.soderlund@ragnatech.se>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 3/5] test: camera: Remove test for bad\n\tStream IDs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 03 Apr 2019 13:20:14 -0000"}}]